nodebb-plugin-ezoic-infinite 1.6.73 → 1.6.74

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.73",
+  "version": "1.6.74",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -133,7 +133,29 @@ function tightenEzoicMinHeight(wrap) {
     if (!wrap || !wrap.querySelector) return;
 
     const iframes = wrap.querySelectorAll('iframe');
-    if (!iframes || !iframes.length) return;
+
+    // If the wrap is still empty, Ezoic often leaves inline `min-height:400px !important` on
+    // nested `.ezoic-ad` containers, which creates large blank gaps. We can't remove it with CSS.
+    // We collapse those gaps after a short grace period, while still allowing late fill.
+    if (!iframes || !iframes.length) {
+      try {
+        const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
+        const age = created ? (now() - created) : 0;
+        // Give auctions/CMP a bit of time; then collapse the notorious 400px gap.
+        if (age >= 12000) {
+          const nodes = wrap.querySelectorAll('.ezoic-ad, .ezoic-ad-adaptive');
+          nodes.forEach((n) => {
+            const st = (n.getAttribute('style') || '').toLowerCase();
+            if (st.includes('min-height:400') || st.includes('min-height: 400') || st.includes('min-height:400px')) {
+              try { n.style.setProperty('min-height', '1px', 'important'); } catch (e) { n.style.minHeight = '1px'; }
+              try { n.style.setProperty('height', 'auto', 'important'); } catch (e) {}
+              try { n.style.setProperty('line-height', '0', 'important'); } catch (e) {}
+            }
+          });
+        }
+      } catch (e) {}
+      return;
+    }
 
     // Find the closest "big" ezoic container that carries the 400px min-height.
     const firstIframe = iframes[0];
@@ -738,17 +760,15 @@ function globalGapFixInit() {
         if (wrap.getAttribute('data-ezoic-pin') === '1') return;
       } catch (e) {}
 
-      // For message pages AND category topic lists, NodeBB may virtualize/recycle items.
-      // If we never hide/prune filled wraps, they can "pile up" when their anchor items
-      // temporarily leave the DOM (especially on /category/... lists).
-      //
-      // Strategy:
-      //  - always hide orphan wraps (filled or empty) when their anchor item is gone
-      //  - only *release* (remove) them if they are far offscreen, to avoid "vanishing" feel
+      // For message/topic pages we may prune filled or empty orphans if they are far away,
+      // otherwise consecutive "stacks" can appear when posts are virtualized.
       const isMessage = (kindClass === 'ezoic-ad-message');
-      const isTopicList = (kindClass === 'ezoic-ad-between');
-      const allowOrphanForFilled = (isMessage || isTopicList);
-      if (!allowOrphanForFilled && isFilled(wrap)) return; // keep filled ads for non-virtualized lists
+      // IMPORTANT:
+      // On category/topic lists, NodeBB can virtualize/recycle list items while scrolling.
+      // If we keep *filled* wraps when their anchor items are gone, they can visually
+      // "stack" together on upward scroll. We therefore allow filled wraps to be hidden
+      // when orphaned, but we still avoid fully releasing them (so they can come back
+      // when anchors reappear).
 
       // Never prune a fresh wrap: it may fill late.
       try {
@@ -765,8 +785,9 @@ if (hasNearbyItem(wrap)) {
 // back-to-back while scrolling. We'll recycle it when its anchor comes back.
 try { wrap.classList && wrap.classList.add('ez-orphan-hidden'); wrap.style && (wrap.style.display = 'none'); } catch (e) {}
 
-// For message ads and topic-list ads: only release if far offscreen to avoid perceived "vanishing" during fast scroll.
-if (isMessage || isTopicList) {
+// For message ads: only release if far offscreen to avoid perceived "vanishing" during fast scroll.
+// For non-message lists (topics/categories): do not release filled wraps at all; only hide.
+if (isMessage) {
   try {
     const r = wrap.getBoundingClientRect();
     const vh = Math.max(1, window.innerHeight || 1);
@@ -778,6 +799,9 @@ if (isMessage || isTopicList) {
   }
 }
 
+// Never release filled wraps on non-message lists; hiding is enough to prevent stacks.
+if (!isMessage && isFilled(wrap)) return;
+
 withInternalDomChange(() => releaseWrapNode(wrap));
 removed++;
     });
@@ -1026,6 +1050,8 @@ removed++;
               watchWrapForFill(ww);
               setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 900);
               setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 2200);
+              // Collapse the notorious 400px inline min-height if the slot stays empty.
+              setTimeout(() => { try { tightenEzoicMinHeight(ww); } catch (e) {} }, 12500);
             }
           } catch (e) {}
           setTimeout(() => { clearTimeout(hardTimer); release(); }, 650);