nodebb-plugin-ezoic-infinite 1.6.72 → 1.6.73

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.72",
+  "version": "1.6.73",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",
@@ -18,4 +18,4 @@
     "compatibility": "^4.0.0"
   },
   "private": false
-}
+}

package/public/client.js

@@ -738,10 +738,17 @@ function globalGapFixInit() {
         if (wrap.getAttribute('data-ezoic-pin') === '1') return;
       } catch (e) {}
 
-      // For message/topic pages we may prune filled or empty orphans if they are far away,
-      // otherwise consecutive "stacks" can appear when posts are virtualized.
+      // For message pages AND category topic lists, NodeBB may virtualize/recycle items.
+      // If we never hide/prune filled wraps, they can "pile up" when their anchor items
+      // temporarily leave the DOM (especially on /category/... lists).
+      //
+      // Strategy:
+      //  - always hide orphan wraps (filled or empty) when their anchor item is gone
+      //  - only *release* (remove) them if they are far offscreen, to avoid "vanishing" feel
       const isMessage = (kindClass === 'ezoic-ad-message');
-      if (!isMessage && isFilled(wrap)) return; // never prune filled ads for non-message lists
+      const isTopicList = (kindClass === 'ezoic-ad-between');
+      const allowOrphanForFilled = (isMessage || isTopicList);
+      if (!allowOrphanForFilled && isFilled(wrap)) return; // keep filled ads for non-virtualized lists
 
       // Never prune a fresh wrap: it may fill late.
       try {
@@ -758,8 +765,8 @@ if (hasNearbyItem(wrap)) {
 // back-to-back while scrolling. We'll recycle it when its anchor comes back.
 try { wrap.classList && wrap.classList.add('ez-orphan-hidden'); wrap.style && (wrap.style.display = 'none'); } catch (e) {}
 
-// For message ads: only release if far offscreen to avoid perceived "vanishing" during fast scroll.
-if (isMessage) {
+// For message ads and topic-list ads: only release if far offscreen to avoid perceived "vanishing" during fast scroll.
+if (isMessage || isTopicList) {
   try {
     const r = wrap.getBoundingClientRect();
     const vh = Math.max(1, window.innerHeight || 1);
@@ -1091,21 +1098,6 @@ function buildOrdinalMap(items) {
       const el = ordinalMap.get(afterPos);
       if (!el) continue;
       if (!el || !el.isConnected) continue;
-
-      // Viewport guard (loose): NodeBB may load batches above the fold when the user scrolls up.
-      // If we inject immediately into anchors that are *far* above the viewport, wraps tend to
-      // accumulate/pile near the top once the DOM is recycled.
-      //
-      // Important: do NOT skip when the anchor is only slightly above the viewport (e.g. -10px),
-      // otherwise injection feels "missing" compared to v17. We only skip when it's well above.
-      try {
-        if (scrollDir < 0) {
-          const bottom = el.getBoundingClientRect().bottom;
-          const cutoff = -Math.max(240, (window.innerHeight || 800) * 0.75);
-          if (bottom < cutoff) continue;
-        }
-      } catch (e) {}
-
       if (isAdjacentAd(el)) continue;
       if (findWrap(kindClass, afterPos)) continue;