nodebb-plugin-ezoic-infinite 1.6.65 → 1.6.67

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.65",
+  "version": "1.6.67",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -79,17 +79,12 @@
     } catch (e) {}
   }
 
-  // ─── CMP/TCF stability ──────────────────────────────────────────────────────
-  function ensureTcfApiLocator() {
-    try {
-      if (typeof window.__tcfapi !== 'function' && typeof window.__cmp !== 'function') return;
-      if (document.getElementById('__tcfapiLocator')) return;
-      const f = document.createElement('iframe');
-      f.style.display = 'none';
-      f.id = f.name = '__tcfapiLocator';
-      (document.body || document.documentElement).appendChild(f);
-    } catch (e) {}
-  }
+  // ensureTcfApiLocator intentionally removed:
+  // Creating our own __tcfapiLocator iframe conflicts with the CMP's own locator
+  // management and causes "Cannot read properties of null (reading 'postMessage')"
+  // errors when the CMP tries to postMessage to an iframe we created then navigated away.
+  // The CMP (Ezoic/IAB TCF) handles its own locator iframe lifecycle.
+  function ensureTcfApiLocator() { /* no-op */ }
 
   // ─── Ezoic min-height tightener ─────────────────────────────────────────────
   // Ezoic injects `min-height:400px !important` on nested wrappers via inline
@@ -468,10 +463,8 @@
   // ─── Orphan / cluster management ────────────────────────────────────────────
   function pruneOrphanWraps(kindClass, items) {
     if (!items || !items.length) return 0;
-    const itemSet   = new Set(items);
-    const isMessage = kindClass === 'ezoic-ad-message';
-    // Between/category ads are NEVER fully released — only hidden/shown.
-    // Releasing frees IDs into the pool → re-injection at wrong positions.
+    const itemSet      = new Set(items);
+    const isMessage    = kindClass === 'ezoic-ad-message';
     const allowRelease = isMessage;
     let removed = 0;
 
@@ -495,19 +488,26 @@
 
     document.querySelectorAll('.' + WRAP_CLASS + '.' + kindClass).forEach((wrap) => {
       if (wrap.getAttribute('data-ezoic-pin') === '1') return;
-      const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
-      if (created && (now() - created) < keepEmptyWrapMs()) return;
 
       if (hasNearbyItem(wrap)) {
+        // Anchor is in the DOM → always restore visibility, regardless of age.
         try { wrap.classList.remove('ez-orphan-hidden'); wrap.style.display = ''; } catch (e) {}
         return;
       }
 
-      // Anchor gone → hide.
+      // Anchor is NOT in the DOM → always hide immediately, regardless of age.
+      // KEY FIX: the previous code skipped this for fresh wraps (< keepEmptyWrapMs).
+      // That meant a wrap whose anchor topic was virtualized away within the first
+      // 60-120s would stay visible and float to the top of the list.
       try { wrap.classList.add('ez-orphan-hidden'); wrap.style.display = 'none'; } catch (e) {}
+
+      // Release (message-ads only): only after the freshness window, and only
+      // when far off-screen — we still want late-filling ads to have a chance.
       if (!allowRelease) return;
 
-      // Message-ads only: release when far off-screen.
+      const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
+      if (created && (now() - created) < keepEmptyWrapMs()) return;
+
       try {
         const r  = wrap.getBoundingClientRect();
         const vh = Math.max(1, window.innerHeight || 1);
@@ -909,23 +909,18 @@
     const maxInserts = MAX_INSERTS_PER_RUN + (isBoosted() ? 1 : 0);
     let inserted = 0;
 
-    // Viewport top — we never inject after an element that is fully above this.
-    // This is the definitive guard against NodeBB loading content above the fold
-    // and our scanner immediately injecting ads on those newly-loaded top items.
-    // We use a generous negative margin so items just barely scrolled above still
-    // get ads injected (they'll be visible when the user scrolls back a little).
-    const viewportSafeTop = -(window.innerHeight || 800) * 0.5;
-
     for (const afterPos of targets) {
       if (inserted >= maxInserts) break;
       const el = ordinalMap.get(afterPos);
       if (!el || !el.isConnected) continue;
 
-      // Skip elements that are well above the viewport.
-      // getBoundingClientRect is cheap on modern engines (no forced layout).
+      // Never inject after an element that is fully above the viewport top.
+      // This is the definitive guard: NodeBB loads items above the fold when the
+      // user scrolls up. Those items have rect.bottom < 0 at the moment of load.
+      // Any negative margin ("a little above is ok") still causes the pile-up
+      // because NodeBB loads a whole batch just above — we must use exactly 0.
       try {
-        const rect = el.getBoundingClientRect();
-        if (rect.bottom < viewportSafeTop) continue;
+        if (el.getBoundingClientRect().bottom < 0) continue;
       } catch (e) {}
 
       if (isAdjacentAd(el)) continue;