nodebb-plugin-ezoic-infinite 1.6.63 → 1.6.65

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.63",
+  "version": "1.6.65",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -401,6 +401,7 @@
   }
 
   // ─── Insertion primitives ───────────────────────────────────────────────────
+
   function buildWrap(id, kindClass, afterPos, createPlaceholder) {
     const wrap = document.createElement('div');
     wrap.className = WRAP_CLASS + ' ' + kindClass;
@@ -469,23 +470,16 @@
     if (!items || !items.length) return 0;
     const itemSet   = new Set(items);
     const isMessage = kindClass === 'ezoic-ad-message';
-    // Between-ads and category-ads are NEVER fully released — only hidden/shown.
-    // Releasing them frees their placeholder IDs back into the pool. When the
-    // anchor topics return (scroll-up / NodeBB re-render), injectBetween would
-    // re-insert those IDs, but DOM ordinals have shifted → all wraps pile at top.
-    // Keeping the wrap node in DOM at its original position means findWrap() will
-    // always find it and injectBetween() will never create a duplicate.
+    // Between/category ads are NEVER fully released — only hidden/shown.
+    // Releasing frees IDs into the pool → re-injection at wrong positions.
     const allowRelease = isMessage;
     let removed = 0;
 
     const hasNearbyItem = (wrap) => {
-      // If the wrap is inside a li.nodebb-ezoic-host, we must check the HOST's
-      // siblings, not the wrap's own siblings (the wrap has no siblings inside host).
+      // If wrap is inside a li.nodebb-ezoic-host, check the HOST's siblings.
       const pivot = (wrap.parentElement && wrap.parentElement.classList &&
                      wrap.parentElement.classList.contains(HOST_CLASS))
-        ? wrap.parentElement
-        : wrap;
-
+        ? wrap.parentElement : wrap;
       let prev = pivot.previousElementSibling;
       for (let i = 0; i < 14 && prev; i++) {
         if (itemSet.has(prev)) return true;
@@ -500,31 +494,24 @@
     };
 
     document.querySelectorAll('.' + WRAP_CLASS + '.' + kindClass).forEach((wrap) => {
-      // Never touch pinned placements.
       if (wrap.getAttribute('data-ezoic-pin') === '1') return;
-
-      // Never prune very fresh wraps (slow auction / CMP fills).
       const created = parseInt(wrap.getAttribute('data-created') || '0', 10);
       if (created && (now() - created) < keepEmptyWrapMs()) return;
 
       if (hasNearbyItem(wrap)) {
-        // Anchor back in DOM → restore visibility.
         try { wrap.classList.remove('ez-orphan-hidden'); wrap.style.display = ''; } catch (e) {}
         return;
       }
 
-      // Anchor is gone (virtualized) → hide so ads don't stack visually.
+      // Anchor gone → hide.
       try { wrap.classList.add('ez-orphan-hidden'); wrap.style.display = 'none'; } catch (e) {}
-
-      // For between/category ads: stop here — never release the node.
-      // The wrap stays in DOM (hidden) at its correct data-ezoic-after position.
       if (!allowRelease) return;
 
-      // For message-ads only: fully release when far off-screen.
+      // Message-ads only: release when far off-screen.
       try {
         const r  = wrap.getBoundingClientRect();
         const vh = Math.max(1, window.innerHeight || 1);
-        if (r.bottom > -vh * 2 && r.top < vh * 4) return; // still near viewport
+        if (r.bottom > -vh * 2 && r.top < vh * 4) return;
       } catch (e) { return; }
 
       withInternalDomChange(() => releaseWrapNode(wrap));
@@ -922,10 +909,25 @@
     const maxInserts = MAX_INSERTS_PER_RUN + (isBoosted() ? 1 : 0);
     let inserted = 0;
 
+    // Viewport top — we never inject after an element that is fully above this.
+    // This is the definitive guard against NodeBB loading content above the fold
+    // and our scanner immediately injecting ads on those newly-loaded top items.
+    // We use a generous negative margin so items just barely scrolled above still
+    // get ads injected (they'll be visible when the user scrolls back a little).
+    const viewportSafeTop = -(window.innerHeight || 800) * 0.5;
+
     for (const afterPos of targets) {
       if (inserted >= maxInserts) break;
       const el = ordinalMap.get(afterPos);
       if (!el || !el.isConnected) continue;
+
+      // Skip elements that are well above the viewport.
+      // getBoundingClientRect is cheap on modern engines (no forced layout).
+      try {
+        const rect = el.getBoundingClientRect();
+        if (rect.bottom < viewportSafeTop) continue;
+      } catch (e) {}
+
       if (isAdjacentAd(el)) continue;
       if (findWrap(kindClass, afterPos)) continue;