nodebb-plugin-ezoic-infinite 1.6.32 → 1.6.34

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.32",
+  "version": "1.6.34",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1514,7 +1514,7 @@ function buildOrdinalMap(items) {
 
 
 
-// ===== V17.4: Hide top pile (supports ul>div OR li hosts), no moving, keeps injection intact =====
+// ===== V17.3: keep injection; hide top pile on upscroll; rehome EMPTY hosts on downscroll =====
 (function(){
   var TOPIC_LI_SEL = 'li[component="category/topic"]';
   var BETWEEN_WRAP_SEL = 'div.nodebb-ezoic-wrap.ezoic-ad-between';
@@ -1524,7 +1524,7 @@ function buildOrdinalMap(items) {
   var lastY = window.pageYOffset || document.documentElement.scrollTop || 0;
   var scheduled = false;
   var lastRun = 0;
-  var COOLDOWN = 90;
+  var COOLDOWN = 120;
 
   function getY(){ return window.pageYOffset || document.documentElement.scrollTop || 0; }
 
@@ -1536,54 +1536,113 @@ function buildOrdinalMap(items) {
     } catch(e){ return null; }
   }
 
-  function isBetweenNode(el){
-    try {
-      if (!el || el.nodeType !== 1) return false;
-      if (el.matches && el.matches(BETWEEN_WRAP_SEL)) return true; // ul>div case
-      if (el.tagName === 'LI' && el.classList && el.classList.contains(HOST_CLASS)) {
-        return !!(el.querySelector && el.querySelector(BETWEEN_WRAP_SEL));
+  function ensureHostForWrap(wrap, ul){
+    try{
+      if (!wrap || wrap.nodeType!==1) return null;
+      if (!(wrap.matches && wrap.matches(BETWEEN_WRAP_SEL))) return null;
+
+      var host = wrap.closest ? wrap.closest('li.'+HOST_CLASS) : null;
+      if (host) return host;
+
+      if (!ul) ul = wrap.closest ? wrap.closest('ul,ol') : null;
+      if (!ul || !(ul.tagName==='UL' || ul.tagName==='OL')) return null;
+
+      if (wrap.parentElement === ul){
+        host = document.createElement('li');
+        host.className = HOST_CLASS;
+        host.setAttribute('role','listitem');
+        host.style.listStyle='none';
+        host.style.width='100%';
+        // preserve after
+        try {
+          var after = wrap.getAttribute('data-ezoic-after');
+          if (after) host.setAttribute('data-ezoic-after', after);
+        } catch(e){}
+        ul.insertBefore(host, wrap);
+        host.appendChild(wrap);
+        try { wrap.style.width='100%'; } catch(e){}
+        return host;
       }
-    } catch(e){}
-    return false;
+    }catch(e){}
+    return null;
   }
 
-  function isTopicNode(el){
-    try { return !!(el && el.nodeType===1 && el.matches && el.matches(TOPIC_LI_SEL)); } catch(e){ return false; }
+  function hostHasAdContent(host){
+    // iframes/amp ads mean it's already rendered; moving might reduce fill
+    try{
+      return !!(host.querySelector && host.querySelector('iframe, amp-ad, amp-iframe, .amp-ads, .ezoic-ad iframe'));
+    }catch(e){ return false; }
   }
 
-  function clearPiled(ul){
-    try {
-      if (!ul) return;
-      ul.querySelectorAll('['+PILED_ATTR+'="1"]').forEach(function(n){
-        try { n.removeAttribute(PILED_ATTR); } catch(e){}
-      });
-    } catch(e){}
+  function nthTopic(ul, n){
+    try{
+      var topics = ul.querySelectorAll(TOPIC_LI_SEL);
+      if (!topics || !topics.length) return null;
+      if (n<1) n=1;
+      if (n>topics.length) n=topics.length;
+      return topics[n-1] || null;
+    }catch(e){ return null; }
   }
 
-  function markTopPile(ul){
-    // Mark any consecutive between nodes near top (keep the first, hide the rest until next topic).
-    try {
-      if (!ul) return;
+  function getAfter(host){
+    try{
+      var v = host.getAttribute('data-ezoic-after');
+      if (!v){
+        var wrap = host.querySelector && host.querySelector(BETWEEN_WRAP_SEL);
+        if (wrap) v = wrap.getAttribute('data-ezoic-after');
+      }
+      var n = parseInt(v,10);
+      return isNaN(n)? null : n;
+    }catch(e){ return null; }
+  }
+
+  function detectAndHideTopPile(ul){
+    // Hide piled hosts near top so user doesn't see the stack.
+    try{
       var kids = ul.children;
-      var limit = Math.min(kids.length, 140);
-      var inRun = 0;
+      var limit = Math.min(kids.length, 60);
+      var run = 0;
       for (var i=0;i<limit;i++){
         var el = kids[i];
-        if (isBetweenNode(el)){
-          inRun++;
-          if (inRun >= 2){
-            try { el.setAttribute(PILED_ATTR,'1'); } catch(e){}
-          } else {
-            try { el.removeAttribute(PILED_ATTR); } catch(e){}
+        var isBetweenHost = (el.tagName==='LI' && el.classList && el.classList.contains(HOST_CLASS) && el.querySelector && el.querySelector(BETWEEN_WRAP_SEL));
+        var isTopic = (el.matches && el.matches(TOPIC_LI_SEL));
+        if (isBetweenHost){
+          run++;
+          if (run>=2){
+            // mark piled beyond the first
+            el.setAttribute(PILED_ATTR,'1');
           }
-        } else if (isTopicNode(el)){
-          inRun = 0;
+        } else if (isTopic){
+          run=0;
         } else {
-          // other node breaks run as well
-          inRun = 0;
+          // reset on any non-topic
         }
       }
-    } catch(e){}
+    }catch(e){}
+  }
+
+  function rehomePiledEmptyOnDownscroll(ul){
+    // On downscroll, try to move only EMPTY (not yet rendered) piled hosts to intended anchors and unhide them.
+    try{
+      var piled = ul.querySelectorAll('li.'+HOST_CLASS+'['+PILED_ATTR+'="1"]');
+      if (!piled.length) return;
+
+      piled.forEach(function(host){
+        try{
+          // if it already has rendered ad, just unhide; do not move
+          if (hostHasAdContent(host)){
+            host.removeAttribute(PILED_ATTR);
+            return;
+          }
+          var after = getAfter(host);
+          var anchor = after!=null ? nthTopic(ul, after) : null;
+          if (anchor){
+            anchor.insertAdjacentElement('afterend', host);
+          }
+          host.removeAttribute(PILED_ATTR);
+        }catch(e){}
+      });
+    }catch(e){}
   }
 
   function schedule(fn){
@@ -1592,7 +1651,7 @@ function buildOrdinalMap(items) {
     if (scheduled) return;
     scheduled = true;
     requestAnimationFrame(function(){
-      scheduled = false;
+      scheduled=false;
       lastRun = Date.now();
       fn();
     });
@@ -1602,16 +1661,18 @@ function buildOrdinalMap(items) {
     var y = getY();
     var dy = y - lastY;
     lastY = y;
-
     var ul = getTopicList();
     if (!ul) return;
 
-    // Only manage pile visibility when user is near the top area.
-    if (y < 1100 && dy < -6){
-      schedule(function(){ markTopPile(ul); });
-    } else if (y > 1300 || dy > 10){
-      // leaving top area or scrolling down: restore visibility
-      schedule(function(){ clearPiled(ul); });
+    // always wrap invalid ul>div (cheap)
+    try { ul.querySelectorAll(':scope > '+BETWEEN_WRAP_SEL).forEach(function(w){ ensureHostForWrap(w, ul); }); } catch(e){}
+
+    if (dy < -8 && y < 900){
+      // upscroll near top: hide pile quickly (no moving)
+      schedule(function(){ detectAndHideTopPile(ul); });
+    } else if (dy > 8){
+      // downscroll: rehome only empty piled hosts (safe) and unhide
+      schedule(function(){ rehomePiledEmptyOnDownscroll(ul); });
     }
   }
 
@@ -1621,16 +1682,14 @@ function buildOrdinalMap(items) {
     if (window.jQuery){
       try{
         window.jQuery(window).on('action:ajaxify.end action:infiniteScroll.loaded', function(){
-          // if we are near top, re-evaluate pile quickly; otherwise ensure no stale hiding
+          // wrap invalids only
           setTimeout(function(){
-            try {
+            try{
               var ul = getTopicList();
               if (!ul) return;
-              var y = getY();
-              if (y < 1100) markTopPile(ul);
-              else clearPiled(ul);
-            } catch(e){}
-          }, 80);
+              ul.querySelectorAll(':scope > '+BETWEEN_WRAP_SEL).forEach(function(w){ ensureHostForWrap(w, ul); });
+            }catch(e){}
+          }, 50);
         });
       }catch(e){}
     }
@@ -1639,5 +1698,5 @@ function buildOrdinalMap(items) {
   if (document.readyState === 'loading') document.addEventListener('DOMContentLoaded', init);
   else init();
 })();
-// ===== /V17.4 =====
+// ===== /V17.3 =====
 

package/public/style.css

@@ -88,10 +88,10 @@ li.nodebb-ezoic-host > .nodebb-ezoic-wrap.ezoic-ad-between { width: 100%; displa
 
 
 
-/* ===== V17.4 pile hide ===== */
-[data-ezoic-piled="1"] { display: none !important; }
+/* ===== V17.3 piled hide ===== */
+li.nodebb-ezoic-host[data-ezoic-piled="1"] { display: none !important; }
 /* keep host stable */
 li.nodebb-ezoic-host { list-style:none; width:100%; display:block; }
 li.nodebb-ezoic-host > .nodebb-ezoic-wrap.ezoic-ad-between { width:100%; display:block; }
-/* ===== /V17.4 ===== */
+/* ===== /V17.3 ===== */