nodebb-plugin-ezoic-infinite 1.6.25 → 1.6.26

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.6.25",
+  "version": "1.6.26",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,36 +1,37 @@
 (function () {
   'use strict';
 
-function ezoicClosestTopicLi(el) {
+function ezoicInsertAfterTopicHost(target, wrap, kindClass) {
   try {
-    if (!el) return null;
-    if (el.closest) {
-      return el.closest('li[component="category/topic"]') || el.closest('li');
-    }
-  } catch (e) {}
-  return null;
-}
-
-function ezoicPlaceBetweenInLi(target, wrap) {
-  // Place between-ad WRAP inside the previous topic <li>, not as a sibling in the <ul>.
-  try {
-    var li = ezoicClosestTopicLi(target) || target;
-    if (!li || !wrap) return false;
-
-    // avoid duplicates per anchor+after
-    try {
-      var after = wrap.getAttribute && wrap.getAttribute('data-ezoic-after');
-      if (after && li.querySelector) {
-        var existing = li.querySelector('.nodebb-ezoic-wrap.ezoic-ad-between[data-ezoic-after="' + after + '"]');
-        if (existing && existing !== wrap) {
-          try { wrap.remove(); } catch(e) {}
-          return true;
-        }
-      }
-    } catch (e) {}
-
-    try { wrap.setAttribute('data-ezoic-in-li', '1'); } catch (e) {}
-    li.appendChild(wrap);
+    if (!target || !wrap) return false;
+    if (kindClass !== 'ezoic-ad-between') return false;
+
+    // Ensure we insert a LI host that looks like a topic item so NodeBB list virtualization keeps ordering.
+    var anchorLi = target.closest ? (target.closest('li[component="category/topic"]') || target.closest('li')) : null;
+    if (!anchorLi && target.tagName === 'LI') anchorLi = target;
+    if (!anchorLi) return false;
+
+    var ul = anchorLi.parentElement;
+    if (!ul || !(ul.tagName === 'UL' || ul.tagName === 'OL')) return false;
+
+    // If wrap already hosted, do nothing
+    var existingHost = wrap.closest ? wrap.closest('li.nodebb-ezoic-host') : null;
+    if (existingHost) return true;
+
+    var host = document.createElement('li');
+    host.className = 'nodebb-ezoic-host';
+    // mimic topic list item so NodeBB doesn't relocate it
+    host.setAttribute('component', 'category/topic');
+    host.setAttribute('data-ezoic-host', 'between');
+    host.style.listStyle = 'none';
+    host.style.width = '100%';
+
+    // Insert host after anchorLi
+    if (anchorLi.insertAdjacentElement) anchorLi.insertAdjacentElement('afterend', host);
+    else ul.insertBefore(host, anchorLi.nextSibling);
+
+    host.appendChild(wrap);
+    try { wrap.style.width = '100%'; } catch (e) {}
     return true;
   } catch (e) {}
   return false;
@@ -704,9 +705,7 @@ function globalGapFixInit() {
     insertingIds.add(id);
     try {
       const wrap = buildWrap(id, kindClass, afterPos, !existingPh);
-      if (kindClass === 'ezoic-ad-between') {
-      if (ezoicPlaceBetweenInLi(target, wrap)) return;
-    }
+      if (ezoicInsertAfterTopicHost(target, wrap, kindClass)) return;
     target.insertAdjacentElement('afterend', wrap);
 
       // If placeholder exists elsewhere (including pool), move it into the wrapper.
@@ -1199,9 +1198,7 @@ function buildOrdinalMap(items) {
       if (!anchorEl || !wrap || !wrap.isConnected) return null;
 
       wrap.setAttribute('data-ezoic-after', String(afterPos));
-      if (kindClass === 'ezoic-ad-between') {
-      if (ezoicPlaceBetweenInLi(anchorEl, wrap)) return;
-    }
+      if (ezoicInsertAfterTopicHost(anchorEl, wrap, kindClass)) return;
     anchorEl.insertAdjacentElement('afterend', wrap);
 
       // Ensure minimal layout impact.
@@ -1553,26 +1550,27 @@ function buildOrdinalMap(items) {
 
 
 
-// ===== V15 one-shot repair (no heavy observers) =====
-function ezoicRepairBetweenPlacement() {
+// ===== V16 repair invalid UL children (between) =====
+function ezoicRepairBetweenHosts() {
   try {
     var bad = document.querySelectorAll('ul > div.nodebb-ezoic-wrap.ezoic-ad-between, ol > div.nodebb-ezoic-wrap.ezoic-ad-between');
     bad.forEach(function(wrap){
       try {
         var prev = wrap.previousElementSibling;
-        if (prev) ezoicPlaceBetweenInLi(prev, wrap);
+        if (!prev) return;
+        ezoicInsertAfterTopicHost(prev, wrap, 'ezoic-ad-between');
       } catch (e) {}
     });
   } catch (e) {}
 }
-try { ezoicRepairBetweenPlacement(); } catch (e) {}
+try { ezoicRepairBetweenHosts(); } catch (e) {}
 if (window.jQuery) {
   try {
     window.jQuery(window).on('action:ajaxify.end action:infiniteScroll.loaded', function(){
-      setTimeout(function(){ try { ezoicRepairBetweenPlacement(); } catch(e) {} }, 0);
-      setTimeout(function(){ try { ezoicRepairBetweenPlacement(); } catch(e) {} }, 250);
+      setTimeout(function(){ try { ezoicRepairBetweenHosts(); } catch(e) {} }, 0);
+      setTimeout(function(){ try { ezoicRepairBetweenHosts(); } catch(e) {} }, 250);
     });
   } catch (e) {}
 }
-// ===== /V15 =====
+// ===== /V16 =====
 

package/public/style.css

@@ -81,15 +81,14 @@
 }
 
 
-/* ===== V15 between in li ===== */
-li[component="category/topic"] > .nodebb-ezoic-wrap.ezoic-ad-between[data-ezoic-in-li="1"] {
-  display: block;
-  width: 100%;
-  margin-top: 12px;
-  margin-bottom: 12px;
+/* ===== V16 host topic li ===== */
+li.nodebb-ezoic-host[component="category/topic"]{
+  list-style:none;
+  width:100%;
 }
-li[component="category/topic"] > .nodebb-ezoic-wrap.ezoic-ad-between[data-ezoic-in-li="1"] * {
-  max-width: 100%;
+/* ensure host doesn't inherit topic card layout */
+li.nodebb-ezoic-host[component="category/topic"] > .nodebb-ezoic-wrap.ezoic-ad-between{
+  width:100%;
 }
-/* ===== /V15 ===== */
+/* ===== /V16 ===== */