nodebb-plugin-ezoic-infinite 1.5.90 → 1.5.92

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.90",
+  "version": "1.5.92",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,32 +1,15 @@
 (function () {
   'use strict';
 
-// ===== V5.1 multi-ads stable anchors =====
-function getStableAnchorKey(el, fallbackPos) {
+function ezoicTrySetAnchor(wrap, el, kindClass, afterPos) {
   try {
-    if (!el) return 'pos:' + String(fallbackPos || 0);
+    if (!wrap || !el) return;
     var pid = el.getAttribute && (el.getAttribute('data-pid') || el.getAttribute('data-id'));
-    if (pid) return 'pid:' + String(pid);
     var tid = el.getAttribute && (el.getAttribute('data-tid') || el.getAttribute('data-topic-id'));
-    if (tid) return 'tid:' + String(tid);
-    var topic = el.querySelector && el.querySelector('[data-tid],[data-topic-id]');
-    if (topic) {
-      var t = topic.getAttribute('data-tid') || topic.getAttribute('data-topic-id');
-      if (t) return 'tid:' + String(t);
-    }
+    var key = kindClass + ':' + (pid ? ('pid:' + pid) : (tid ? ('tid:' + tid) : ('pos:' + String(afterPos || 0))));
+    wrap.setAttribute('data-ezoic-anchor', key);
   } catch (e) {}
-  return 'pos:' + String(fallbackPos || 0);
-}
-
-function findWrapByAnchor(kindClass, anchorKey) {
-  try {
-    var sel = '.nodebb-ezoic-wrap.' + kindClass + '[data-ezoic-anchor="' + anchorKey.replace(/"/g, '') + '"]';
-    return document.querySelector(sel);
-  } catch (e) {
-    return null;
-  }
 }
-// ===== /V5.1 =====
 
 
   // Track scroll direction to avoid aggressive recycling when the user scrolls upward.
@@ -668,7 +651,7 @@ function globalGapFixInit() {
     const wrap = document.createElement('div');
     wrap.className = `${WRAP_CLASS} ${kindClass}`;
     wrap.setAttribute('data-ezoic-after', String(afterPos));
-      try { wrap.setAttribute('data-ezoic-anchor', getStableAnchorKey(el, afterPos)); } catch (e) {}
+      ezoicTrySetAnchor(wrap, el, kindClass, afterPos);
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.setAttribute('data-created', String(now()));
     // "Pinned" placements (after the first item) should remain stable.
@@ -796,8 +779,8 @@ if (isMessage) {
     const farBelow = r.top > vh * 4;
     if (!farAbove && !farBelow) return;
   } catch (e) {
-  // keep original behavior in base build
-}
+    return;
+  }
 }
 
 withInternalDomChange(() => releaseWrapNode(wrap));
@@ -1108,9 +1091,6 @@ function buildOrdinalMap(items) {
   }
 
   function injectBetween(kindClass, items, interval, showFirst, allIds, cursorKey) {
-
-  // V5.1: stable anchor dedupe (prevents regrouping while preserving multiple ads)
-
     if (!items.length) return 0;
 
     const { map: ordinalMap, max: maxOrdinal } = buildOrdinalMap(items);
@@ -1134,9 +1114,10 @@ function buildOrdinalMap(items) {
       // This avoids "Placeholder Id X has already been defined" and also ensures ads keep
       // appearing on very long infinite scroll sessions.
       if (!id) {
-        // Only recycle while scrolling down. Recycling while scrolling up tends to
-        // cause perceived instability (ads bunching/disappearing).
-        recycledWrap = scrollDir > 0 ? pickRecyclableWrap(kindClass) : null;
+        // Safe mode: disable recycling for topic message ads to prevent visual "jumping"
+        // (ads seemingly moving back under the first post during virtualized scroll).
+        const allowRecycle = kindClass !== 'ezoic-ad-message';
+        recycledWrap = (allowRecycle && scrollDir > 0) ? pickRecyclableWrap(kindClass) : null;
         if (recycledWrap) {
           id = recycledWrap.getAttribute('data-ezoic-wrapid') || '';
         }
@@ -1163,7 +1144,7 @@ function buildOrdinalMap(items) {
 }
 
   function moveWrapAfter(anchorEl, wrap, kindClass, afterPos) {
-  // keep original behavior in base build
+  return;
 }
 
   async function runCore() {