nodebb-plugin-ezoic-infinite 1.5.90 → 1.5.91

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.90",
+  "version": "1.5.91",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,32 +1,54 @@
 (function () {
   'use strict';
 
-// ===== V5.1 multi-ads stable anchors =====
-function getStableAnchorKey(el, fallbackPos) {
+// ===== V6 anchor-map stability layer =====
+var __ezoicAnchorMap = Object.create(null);
+
+function ezoicGetAnchorKey(el, afterPos, kindClass) {
   try {
-    if (!el) return 'pos:' + String(fallbackPos || 0);
+    if (!el) return kindClass + ':pos:' + String(afterPos || 0);
     var pid = el.getAttribute && (el.getAttribute('data-pid') || el.getAttribute('data-id'));
-    if (pid) return 'pid:' + String(pid);
+    if (pid) return kindClass + ':pid:' + String(pid);
     var tid = el.getAttribute && (el.getAttribute('data-tid') || el.getAttribute('data-topic-id'));
-    if (tid) return 'tid:' + String(tid);
-    var topic = el.querySelector && el.querySelector('[data-tid],[data-topic-id]');
-    if (topic) {
-      var t = topic.getAttribute('data-tid') || topic.getAttribute('data-topic-id');
-      if (t) return 'tid:' + String(t);
+    if (tid) return kindClass + ':tid:' + String(tid);
+    var a = el.querySelector && el.querySelector('[data-pid],[data-id],[data-tid],[data-topic-id]');
+    if (a) {
+      var p = a.getAttribute('data-pid') || a.getAttribute('data-id');
+      if (p) return kindClass + ':pid:' + String(p);
+      var t = a.getAttribute('data-tid') || a.getAttribute('data-topic-id');
+      if (t) return kindClass + ':tid:' + String(t);
     }
   } catch (e) {}
-  return 'pos:' + String(fallbackPos || 0);
+  return kindClass + ':pos:' + String(afterPos || 0);
 }
 
-function findWrapByAnchor(kindClass, anchorKey) {
+function ezoicRegisterWrapAnchor(wrap, anchorKey) {
   try {
-    var sel = '.nodebb-ezoic-wrap.' + kindClass + '[data-ezoic-anchor="' + anchorKey.replace(/"/g, '') + '"]';
-    return document.querySelector(sel);
-  } catch (e) {
-    return null;
-  }
+    if (!wrap || !anchorKey) return;
+    wrap.setAttribute('data-ezoic-anchor', anchorKey);
+    __ezoicAnchorMap[anchorKey] = wrap;
+  } catch (e) {}
+}
+
+function ezoicFindWrapByAnchor(anchorKey) {
+  try {
+    var w = __ezoicAnchorMap[anchorKey];
+    if (w && w.isConnected) return w;
+  } catch (e) {}
+  try {
+    return document.querySelector('.nodebb-ezoic-wrap[data-ezoic-anchor="' + String(anchorKey).replace(/"/g, '') + '"]');
+  } catch (e) { return null; }
+}
+
+function ezoicCleanupAnchorMap() {
+  try {
+    Object.keys(__ezoicAnchorMap).forEach(function(k){
+      var w = __ezoicAnchorMap[k];
+      if (!w || !w.isConnected) delete __ezoicAnchorMap[k];
+    });
+  } catch (e) {}
 }
-// ===== /V5.1 =====
+// ===== /V6 =====
 
 
   // Track scroll direction to avoid aggressive recycling when the user scrolls upward.
@@ -668,7 +690,8 @@ function globalGapFixInit() {
     const wrap = document.createElement('div');
     wrap.className = `${WRAP_CLASS} ${kindClass}`;
     wrap.setAttribute('data-ezoic-after', String(afterPos));
-      try { wrap.setAttribute('data-ezoic-anchor', getStableAnchorKey(el, afterPos)); } catch (e) {}
+      var __anchorKey = ezoicGetAnchorKey(el, afterPos, kindClass);
+      ezoicRegisterWrapAnchor(wrap, __anchorKey);
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.setAttribute('data-created', String(now()));
     // "Pinned" placements (after the first item) should remain stable.
@@ -796,8 +819,8 @@ if (isMessage) {
     const farBelow = r.top > vh * 4;
     if (!farAbove && !farBelow) return;
   } catch (e) {
-  // keep original behavior in base build
-}
+    return;
+  }
 }
 
 withInternalDomChange(() => releaseWrapNode(wrap));
@@ -1108,9 +1131,7 @@ function buildOrdinalMap(items) {
   }
 
   function injectBetween(kindClass, items, interval, showFirst, allIds, cursorKey) {
-
-  // V5.1: stable anchor dedupe (prevents regrouping while preserving multiple ads)
-
+  ezoicCleanupAnchorMap();
     if (!items.length) return 0;
 
     const { map: ordinalMap, max: maxOrdinal } = buildOrdinalMap(items);
@@ -1134,9 +1155,10 @@ function buildOrdinalMap(items) {
       // This avoids "Placeholder Id X has already been defined" and also ensures ads keep
       // appearing on very long infinite scroll sessions.
       if (!id) {
-        // Only recycle while scrolling down. Recycling while scrolling up tends to
-        // cause perceived instability (ads bunching/disappearing).
-        recycledWrap = scrollDir > 0 ? pickRecyclableWrap(kindClass) : null;
+        // Safe mode: disable recycling for topic message ads to prevent visual "jumping"
+        // (ads seemingly moving back under the first post during virtualized scroll).
+        const allowRecycle = kindClass !== 'ezoic-ad-message';
+        recycledWrap = (allowRecycle && scrollDir > 0) ? pickRecyclableWrap(kindClass) : null;
         if (recycledWrap) {
           id = recycledWrap.getAttribute('data-ezoic-wrapid') || '';
         }
@@ -1163,7 +1185,7 @@ function buildOrdinalMap(items) {
 }
 
   function moveWrapAfter(anchorEl, wrap, kindClass, afterPos) {
-  // keep original behavior in base build
+  return;
 }
 
   async function runCore() {
@@ -1503,3 +1525,28 @@ function buildOrdinalMap(items) {
   insertHeroAdEarly().catch(() => {});
   requestBurst();
 })();
+
+
+// V6 guard: prevent unexpected regrouping under first topic
+try {
+  if (typeof MutationObserver !== 'undefined' && !window.__ezoicWrapGuardInstalled) {
+    window.__ezoicWrapGuardInstalled = true;
+    var guardObserver = new MutationObserver(function() {
+      try {
+        Object.keys(__ezoicAnchorMap).forEach(function(k){
+          var w = __ezoicAnchorMap[k];
+          if (!w || !w.isConnected) return;
+          var anchor = w.getAttribute('data-ezoic-anchor') || '';
+          var m = anchor.match(/:(pid|tid):(.+)$/);
+          if (!m) return;
+          var val = m[2];
+          var anchorEl = document.querySelector('[data-pid="' + val + '"], [data-id="' + val + '"], [data-tid="' + val + '"], [data-topic-id="' + val + '"]');
+          if (anchorEl && w.previousElementSibling !== anchorEl) {
+            if (anchorEl.parentNode) anchorEl.parentNode.insertBefore(w, anchorEl.nextSibling);
+          }
+        });
+      } catch (e) {}
+    });
+    guardObserver.observe(document.body || document.documentElement, { childList: true, subtree: true });
+  }
+} catch (e) {}