nodebb-plugin-ezoic-infinite 1.5.84 → 1.5.86

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.84",
+  "version": "1.5.86",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -486,6 +486,24 @@ function globalGapFixInit() {
     return document.querySelector(`.${WRAP_CLASS}.${kindClass}[data-ezoic-after="${afterPos}"]`);
   }
 
+  function getStableAnchorKey(el) {
+    try {
+      if (!el) return '';
+      const pid = el.getAttribute('data-pid');
+      if (pid) return 'pid:' + pid;
+      const tid = el.getAttribute('data-tid');
+      if (tid) return 'tid:' + tid;
+      const slug = el.getAttribute('data-slug');
+      if (slug) return 'slug:' + slug;
+    } catch (e) {}
+    return '';
+  }
+
+  function findWrapByAnchor(kindClass, anchorKey) {
+    if (!anchorKey) return null;
+    return document.querySelector(`.${WRAP_CLASS}.${kindClass}[data-ezoic-anchor="${anchorKey}"]`);
+  }
+
   // ---------------- placeholder pool ----------------
 
   function getPoolEl() {
@@ -636,12 +654,13 @@ function globalGapFixInit() {
 
   // ---------------- insertion primitives ----------------
 
-  function buildWrap(id, kindClass, afterPos, createPlaceholder) {
+  function buildWrap(id, kindClass, afterPos, createPlaceholder, anchorKey) {
     const wrap = document.createElement('div');
     wrap.className = `${WRAP_CLASS} ${kindClass}`;
     wrap.setAttribute('data-ezoic-after', String(afterPos));
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.setAttribute('data-created', String(now()));
+    if (anchorKey) wrap.setAttribute('data-ezoic-anchor', String(anchorKey));
     // "Pinned" placements (after the first item) should remain stable.
     if (afterPos === 1) {
       wrap.setAttribute('data-ezoic-pin', '1');
@@ -658,16 +677,16 @@ function globalGapFixInit() {
     return wrap;
   }
 
-  function insertAfter(target, id, kindClass, afterPos) {
+  function insertAfter(target, id, kindClass, afterPos, anchorKey) {
     if (!target || !target.insertAdjacentElement) return null;
-    if (findWrap(kindClass, afterPos)) return null;
+    if (findWrap(kindClass, afterPos) || findWrapByAnchor(kindClass, anchorKey)) return null;
     if (insertingIds.has(id)) return null;
 
     const existingPh = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
 
     insertingIds.add(id);
     try {
-      const wrap = buildWrap(id, kindClass, afterPos, !existingPh);
+      const wrap = buildWrap(id, kindClass, afterPos, !existingPh, anchorKey);
       target.insertAdjacentElement('afterend', wrap);
 
       // If placeholder exists elsewhere (including pool), move it into the wrapper.
@@ -1092,6 +1111,16 @@ function buildOrdinalMap(items) {
       if (!el) continue;
       if (!el || !el.isConnected) continue;
       if (isAdjacentAd(el)) continue;
+      const anchorKey = getStableAnchorKey(el);
+      const existingByAnchor = findWrapByAnchor(kindClass, anchorKey);
+      if (existingByAnchor && existingByAnchor.isConnected) {
+        const next = el.nextElementSibling;
+        if (next !== existingByAnchor) {
+          try { el.insertAdjacentElement('afterend', existingByAnchor); } catch (e) {}
+        }
+        existingByAnchor.setAttribute('data-ezoic-after', String(afterPos));
+        continue;
+      }
       if (findWrap(kindClass, afterPos)) continue;
 
       let id = pickIdFromAll(allIds, cursorKey);
@@ -1104,7 +1133,7 @@ function buildOrdinalMap(items) {
       if (!id) {
         // Safe mode: disable recycling for topic message ads to prevent visual "jumping"
         // (ads seemingly moving back under the first post during virtualized scroll).
-        const allowRecycle = kindClass !== 'ezoic-ad-message';
+        const allowRecycle = false; // hard-disable recycling to prevent wrappers jumping to top on virtualized/infinite scroll
         recycledWrap = (allowRecycle && scrollDir > 0) ? pickRecyclableWrap(kindClass) : null;
         if (recycledWrap) {
           id = recycledWrap.getAttribute('data-ezoic-wrapid') || '';
@@ -1115,7 +1144,7 @@ function buildOrdinalMap(items) {
 
       const wrap = recycledWrap
         ? moveWrapAfter(el, recycledWrap, kindClass, afterPos)
-        : insertAfter(el, id, kindClass, afterPos);
+        : insertAfter(el, id, kindClass, afterPos, anchorKey);
       if (!wrap) continue;
 
       // observePlaceholder is safe for existing ids (it is idempotent) and helps with "late fill"
@@ -1195,7 +1224,7 @@ function buildOrdinalMap(items) {
           state.allPosts,
           'curPosts'
         );
-        decluster('ezoic-ad-message');
+        // decluster disabled for stability on virtualized lists
       }
     } else if (kind === 'categoryTopics') {
       if (normalizeBool(cfg.enableBetweenAds)) {
@@ -1209,7 +1238,7 @@ function buildOrdinalMap(items) {
           state.allTopics,
           'curTopics'
         );
-        decluster('ezoic-ad-between');
+        // decluster disabled for stability on virtualized lists
       }
     } else if (kind === 'categories') {
       if (normalizeBool(cfg.enableCategoryAds)) {
@@ -1223,7 +1252,7 @@ function buildOrdinalMap(items) {
           state.allCategories,
           'curCategories'
         );
-        decluster('ezoic-ad-categories');
+        // decluster disabled for stability on virtualized lists
       }
     }