nodebb-plugin-ezoic-infinite 1.5.78 → 1.5.80

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.78",
+  "version": "1.5.80",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,6 +1,26 @@
 (function () {
   'use strict';
 
+  // Track scroll direction to avoid aggressive recycling when the user scrolls upward.
+  // Recycling while scrolling up is a common cause of ads "bunching" and a "disappearing too fast" feeling.
+  let lastScrollY = 0;
+  let scrollDir = 1; // 1 = down, -1 = up
+  try {
+    lastScrollY = window.scrollY || 0;
+    window.addEventListener(
+      'scroll',
+      () => {
+        const y = window.scrollY || 0;
+        const d = y - lastScrollY;
+        if (Math.abs(d) > 4) {
+          scrollDir = d > 0 ? 1 : -1;
+          lastScrollY = y;
+        }
+      },
+      { passive: true }
+    );
+  } catch (e) {}
+
   // NodeBB client context
   const $ = (typeof window.jQuery === 'function') ? window.jQuery : null;
 
@@ -22,9 +42,11 @@
 
   // Preload margins
   const PRELOAD_MARGIN_DESKTOP = '2600px 0px 2600px 0px';
-  const PRELOAD_MARGIN_MOBILE = '1500px 0px 1500px 0px';
-  const PRELOAD_MARGIN_DESKTOP_BOOST = '4200px 0px 4200px 0px';
-  const PRELOAD_MARGIN_MOBILE_BOOST = '2500px 0px 2500px 0px';
+  // Mobile: larger preload window so ad fill requests start earlier and
+  // users don't scroll past empty placeholders.
+  const PRELOAD_MARGIN_MOBILE = '3200px 0px 3200px 0px';
+  const PRELOAD_MARGIN_DESKTOP_BOOST = '5200px 0px 5200px 0px';
+  const PRELOAD_MARGIN_MOBILE_BOOST = '5200px 0px 5200px 0px';
 
   const BOOST_DURATION_MS = 2500;
   const BOOST_SPEED_PX_PER_MS = 2.2; // ~2200px/s
@@ -81,6 +103,22 @@
     } catch (e) {}
   }
 
+  // Some CMP/TCF stubs rely on a hidden iframe named `__tcfapiLocator` to route postMessage calls.
+  // In SPA/Ajaxify navigations, that iframe can be removed/replaced unexpectedly, causing noisy
+  // "postMessage" / "addtlConsent" null errors. Ensuring it's present makes the environment stable.
+  function ensureTcfApiLocator() {
+    try {
+      // If a CMP is not present, do nothing.
+      if (typeof window.__tcfapi !== 'function' && typeof window.__cmp !== 'function') return;
+      if (document.getElementById('__tcfapiLocator')) return;
+      const f = document.createElement('iframe');
+      f.style.display = 'none';
+      f.id = '__tcfapiLocator';
+      f.name = '__tcfapiLocator';
+      (document.body || document.documentElement).appendChild(f);
+    } catch (e) {}
+  }
+
   
 
 function isFilledNode(node) {
@@ -751,11 +789,24 @@ function globalGapFixInit() {
             if (prev.getAttribute && prev.getAttribute('data-ezoic-pin') === '1') break;
           } catch (e) {}
 
-          // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
-          // Only decluster when at least one is filled, or when the newer one is stale.
+          // Never remove a wrap that is already filled; otherwise it looks like
+          // ads "disappear" while scrolling. Only remove the empty neighbour.
           const prevFilled = isFilled(prev);
           const curFilled = isFilled(w);
-          if (prevFilled || curFilled || !isFresh(w)) {
+
+          if (curFilled) {
+            // If the previous one is empty (and not fresh), drop the previous instead.
+            if (!prevFilled && !isFresh(prev)) {
+              withInternalDomChange(() => releaseWrapNode(prev));
+              removed++;
+            }
+            break;
+          }
+
+          // Current is empty.
+          // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
+          // Only decluster when previous is filled, or when current is stale.
+          if (prevFilled || !isFresh(w)) {
             withInternalDomChange(() => releaseWrapNode(w));
             removed++;
           }
@@ -817,10 +868,16 @@ function globalGapFixInit() {
     try { io && io.observe(ph); } catch (e) {}
 
     // If already near viewport, fire immediately.
+    // Mobile tends to scroll faster + has slower auctions, so we fire earlier.
     try {
       const r = ph.getBoundingClientRect();
-      const screens = isBoosted() ? 5.0 : 3.0;
-      const minBottom = isBoosted() ? -1500 : -800;
+      const mobile = isMobile();
+      const screens = isBoosted()
+        ? (mobile ? 9.0 : 5.0)
+        : (mobile ? 6.0 : 3.0);
+      const minBottom = isBoosted()
+        ? (mobile ? -2600 : -1500)
+        : (mobile ? -1400 : -800);
       if (r.top < window.innerHeight * screens && r.bottom > minBottom) enqueueShow(id);
     } catch (e) {}
   }
@@ -982,12 +1039,31 @@ function globalGapFixInit() {
       if (isAdjacentAd(el)) continue;
       if (findWrap(kindClass, afterPos)) continue;
 
-      const id = pickIdFromAll(allIds, cursorKey);
+      let id = pickIdFromAll(allIds, cursorKey);
+      let recycledWrap = null;
+
+      // If the pool is exhausted (all placeholder ids already mounted), recycle a wrap that is far
+      // above the viewport by moving it to the new target instead of creating a new placeholder.
+      // This avoids "Placeholder Id X has already been defined" and also ensures ads keep
+      // appearing on very long infinite scroll sessions.
+      if (!id) {
+        // Only recycle while scrolling down. Recycling while scrolling up tends to
+        // cause perceived instability (ads bunching/disappearing).
+        recycledWrap = scrollDir > 0 ? pickRecyclableWrap(kindClass) : null;
+        if (recycledWrap) {
+          id = recycledWrap.getAttribute('data-ezoic-wrapid') || '';
+        }
+      }
+
       if (!id) break;
 
-      const wrap = insertAfter(el, id, kindClass, afterPos);
+      const wrap = recycledWrap
+        ? moveWrapAfter(el, recycledWrap, kindClass, afterPos)
+        : insertAfter(el, id, kindClass, afterPos);
       if (!wrap) continue;
 
+      // observePlaceholder is safe for existing ids (it is idempotent) and helps with "late fill"
+      // after ajaxify/infinite scroll mutations.
       observePlaceholder(id);
       inserted++;
     }
@@ -995,6 +1071,60 @@ function globalGapFixInit() {
     return inserted;
   }
 
+  function pickRecyclableWrap(kindClass) {
+    // Only recycle wrappers that are well above the viewport to avoid visible "disappearing".
+    // With very small id pools (e.g. 6 ids), recycling is the only way to keep ads appearing
+    // on long topics without redefining placeholders.
+    const wraps = document.querySelectorAll('.' + kindClass + '[data-ezoic-wrapid]');
+    if (!wraps || !wraps.length) return null;
+
+    const vh = Math.max(300, window.innerHeight || 800);
+    // Recycle only when the wrapper is far above the viewport.
+    // This keeps ads on-screen longer (especially on mobile) and reduces "blink".
+    const threshold = -Math.min(9000, Math.round(vh * 6));
+
+    let best = null;
+    let bestBottom = Infinity;
+    for (const w of wraps) {
+      if (!w || !w.isConnected) continue;
+      const rect = w.getBoundingClientRect();
+      if (rect.bottom < threshold) {
+        if (rect.bottom < bestBottom) {
+          bestBottom = rect.bottom;
+          best = w;
+        }
+      }
+    }
+    return best;
+  }
+
+  function moveWrapAfter(anchorEl, wrap, kindClass, afterPos) {
+    try {
+      if (!anchorEl || !wrap || !wrap.isConnected) return null;
+
+      wrap.setAttribute('data-ezoic-after', String(afterPos));
+      anchorEl.insertAdjacentElement('afterend', wrap);
+
+      // Ensure minimal layout impact.
+      try { wrap.style.contain = 'layout style paint'; } catch (e) {}
+      try { tightenStickyIn(wrap); } catch (e) {}
+
+      const id = wrap.getAttribute('data-ezoic-wrapid');
+      if (id) {
+        setTimeout(() => {
+          try {
+            if (window.ezstandalone && typeof window.ezstandalone.showAds === 'function') {
+              window.ezstandalone.showAds(id);
+            }
+          } catch (e) {}
+        }, 0);
+      }
+      return wrap;
+    } catch (e) {
+      return null;
+    }
+  }
+
   async function runCore() {
     if (isBlocked()) return 0;
 
@@ -1247,6 +1377,7 @@ function globalGapFixInit() {
       blockedUntil = 0;
 
       muteNoisyConsole();
+      ensureTcfApiLocator();
       warmUpNetwork();
       patchShowAds();
       globalGapFixInit();
@@ -1318,6 +1449,7 @@ function globalGapFixInit() {
 
   state.pageKey = getPageKey();
   muteNoisyConsole();
+  ensureTcfApiLocator();
   warmUpNetwork();
   patchShowAds();
   ensurePreloadObserver();