nodebb-plugin-ezoic-infinite 1.5.77 → 1.5.79

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.77",
+  "version": "1.5.79",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -10,7 +10,10 @@
   const POOL_ID = 'nodebb-ezoic-placeholder-pool';
 
   // Smoothness caps
-  const MAX_INSERTS_PER_RUN = 3;
+  // Limit how many placements we inject per scan pass.
+  // Too low = you end up with only a handful of placeholders after ajaxify.
+  // Too high = jank on very long pages.
+  const MAX_INSERTS_PER_RUN = 8;
 
   // Keep empty (unfilled) wraps alive for a while. Topics/messages can fill late (auction/CMP).
   // Pruning too early makes ads look like they "disappear" while scrolling.
@@ -19,9 +22,11 @@
 
   // Preload margins
   const PRELOAD_MARGIN_DESKTOP = '2600px 0px 2600px 0px';
-  const PRELOAD_MARGIN_MOBILE = '1500px 0px 1500px 0px';
-  const PRELOAD_MARGIN_DESKTOP_BOOST = '4200px 0px 4200px 0px';
-  const PRELOAD_MARGIN_MOBILE_BOOST = '2500px 0px 2500px 0px';
+  // Mobile: larger preload window so ad fill requests start earlier and
+  // users don't scroll past empty placeholders.
+  const PRELOAD_MARGIN_MOBILE = '3200px 0px 3200px 0px';
+  const PRELOAD_MARGIN_DESKTOP_BOOST = '5200px 0px 5200px 0px';
+  const PRELOAD_MARGIN_MOBILE_BOOST = '5200px 0px 5200px 0px';
 
   const BOOST_DURATION_MS = 2500;
   const BOOST_SPEED_PX_PER_MS = 2.2; // ~2200px/s
@@ -586,12 +591,11 @@ function globalGapFixInit() {
     if (!state.allPosts.length) state.allPosts = parsePool(cfg.messagePlaceholderIds);
     if (!state.allCategories.length) state.allCategories = parsePool(cfg.categoryPlaceholderIds);
 
-    // Create placeholders up-front in an offscreen pool.
-    // Ezoic may attempt to define/show ids during load; if they don't exist yet,
-    // it can spam errors and sometimes short-circuit. Pooling keeps ids existing without layout.
-    primePlaceholderPool(state.allTopics);
-    primePlaceholderPool(state.allPosts);
-    primePlaceholderPool(state.allCategories);
+    // IMPORTANT:
+    // We do NOT prime a DOM pool anymore.
+    // Keeping placeholders connected (even offscreen) can lead Ezoic/GPT to
+    // pre-define slots, which then causes "Placeholder Id X has already been defined".
+    // Instead, we create the placeholder element only when we actually inject its wrapper.
   }
 
   // ---------------- insertion primitives ----------------
@@ -749,11 +753,24 @@ function globalGapFixInit() {
             if (prev.getAttribute && prev.getAttribute('data-ezoic-pin') === '1') break;
           } catch (e) {}
 
-          // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
-          // Only decluster when at least one is filled, or when the newer one is stale.
+          // Never remove a wrap that is already filled; otherwise it looks like
+          // ads "disappear" while scrolling. Only remove the empty neighbour.
           const prevFilled = isFilled(prev);
           const curFilled = isFilled(w);
-          if (prevFilled || curFilled || !isFresh(w)) {
+
+          if (curFilled) {
+            // If the previous one is empty (and not fresh), drop the previous instead.
+            if (!prevFilled && !isFresh(prev)) {
+              withInternalDomChange(() => releaseWrapNode(prev));
+              removed++;
+            }
+            break;
+          }
+
+          // Current is empty.
+          // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
+          // Only decluster when previous is filled, or when current is stale.
+          if (prevFilled || !isFresh(w)) {
             withInternalDomChange(() => releaseWrapNode(w));
             removed++;
           }
@@ -815,10 +832,16 @@ function globalGapFixInit() {
     try { io && io.observe(ph); } catch (e) {}
 
     // If already near viewport, fire immediately.
+    // Mobile tends to scroll faster + has slower auctions, so we fire earlier.
     try {
       const r = ph.getBoundingClientRect();
-      const screens = isBoosted() ? 5.0 : 3.0;
-      const minBottom = isBoosted() ? -1500 : -800;
+      const mobile = isMobile();
+      const screens = isBoosted()
+        ? (mobile ? 9.0 : 5.0)
+        : (mobile ? 6.0 : 3.0);
+      const minBottom = isBoosted()
+        ? (mobile ? -2600 : -1500)
+        : (mobile ? -1400 : -800);
       if (r.top < window.innerHeight * screens && r.bottom > minBottom) enqueueShow(id);
     } catch (e) {}
   }
@@ -908,6 +931,16 @@ function globalGapFixInit() {
         const ph = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
         if (!ph || !ph.isConnected) return;
 
+        // If the placeholder already has creative, avoid re-showing.
+        // Re-showing is a common source of "Placeholder Id X has already been defined".
+        try {
+          if (ph.querySelector && ph.querySelector('iframe, ins, img, video, [data-google-container-id]')) {
+            clearTimeout(hardTimer);
+            release();
+            return;
+          }
+        } catch (e) {}
+
         const t = now();
         const last = state.lastShowById.get(id) || 0;
         if (t - last < 900) return;
@@ -1245,13 +1278,29 @@ function globalGapFixInit() {
       requestBurst();
     });
 
+    // Some setups populate content in multiple phases; ensure we re-scan.
+    $(window).on('action:ajaxify.contentLoaded.ezoicInfinite', () => {
+      if (isBlocked()) return;
+      requestBurst();
+    });
+
     $(window).on(
-      'action:posts.loaded.ezoicInfinite action:topics.loaded.ezoicInfinite action:category.loaded.ezoicInfinite action:topic.loaded.ezoicInfinite',
+      'action:posts.loaded.ezoicInfinite action:topics.loaded.ezoicInfinite action:categories.loaded.ezoicInfinite action:category.loaded.ezoicInfinite action:topic.loaded.ezoicInfinite',
       () => {
         if (isBlocked()) return;
         requestBurst();
       }
     );
+
+    // Also listen through NodeBB's AMD hooks module when available.
+    try {
+      require(['hooks'], (hooks) => {
+        if (!hooks || typeof hooks.on !== 'function') return;
+        ['action:ajaxify.end', 'action:ajaxify.contentLoaded', 'action:posts.loaded', 'action:topics.loaded', 'action:categories.loaded', 'action:category.loaded', 'action:topic.loaded'].forEach((ev) => {
+          try { hooks.on(ev, () => { if (!isBlocked()) requestBurst(); }); } catch (e) {}
+        });
+      });
+    } catch (e) {}
   }
 
   function bindScroll() {