nodebb-plugin-ezoic-infinite 1.5.75 → 1.5.77

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.75",
+  "version": "1.5.77",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -38,6 +38,46 @@
   // Production build: debug disabled
   function dbg() {}
 
+  // Ezoic (and some partner scripts) can be very noisy in console on SPA/Ajaxify setups.
+  // These warnings are not actionable for end-users and can flood the console.
+  // We selectively silence the known spam patterns while keeping other warnings intact.
+  function muteNoisyConsole() {
+    try {
+      if (window.__nodebbEzoicConsoleMuted) return;
+      window.__nodebbEzoicConsoleMuted = true;
+
+      const shouldMute = (args) => {
+        try {
+          if (!args || !args.length) return false;
+          const s0 = typeof args[0] === 'string' ? args[0] : '';
+          // Duplicate placeholder definition spam (common when reusing ids in SPA/Ajaxify).
+          if (s0.includes('[EzoicAds JS]: Placeholder Id') && s0.includes('has already been defined')) return true;
+          // Ezoic debugger iframe spam.
+          if (s0.includes('Debugger iframe already exists')) return true;
+          // Missing placeholder spam (we already guard showAds; Ezoic still logs sometimes).
+          if (s0.includes('HTML element with id ezoic-pub-ad-placeholder-') && s0.includes('does not exist')) return true;
+          return false;
+        } catch (e) {
+          return false;
+        }
+      };
+
+      const wrap = (method) => {
+        const orig = console[method];
+        if (typeof orig !== 'function') return;
+        console[method] = function (...args) {
+          if (shouldMute(args)) return;
+          return orig.apply(console, args);
+        };
+      };
+
+      wrap('log');
+      wrap('info');
+      wrap('warn');
+      wrap('error');
+    } catch (e) {}
+  }
+
   
 
 function isFilledNode(node) {
@@ -95,11 +135,8 @@ function tightenEzoicMinHeight(wrap) {
     }
     if (!maxBottom) return;
 
-    // Account for the Ezoic badge (reportline) which is absolutely positioned.
-    const report = refNode.querySelector('.reportline');
-    if (report && report.offsetHeight) {
-      maxBottom += report.offsetHeight;
-    }
+    // NOTE: Do NOT add the Ezoic badge (reportline) height here.
+    // It is absolutely positioned and should not reserve layout space.
 
     const h = Math.max(1, Math.ceil(maxBottom));
 
@@ -189,6 +226,9 @@ function globalGapFixInit() {
     if (window.__nodebbEzoicGapFix) return;
     window.__nodebbEzoicGapFix = true;
 
+    // Observe only the main content area to minimize overhead.
+    const root = document.getElementById('content') || document.querySelector('[component="content"], #panel') || document.body;
+
     const inPostArea = (el) => {
       try {
         return !!(el && el.closest && el.closest('[component="post"], .topic, .posts, [component="topic"]'));
@@ -209,21 +249,37 @@ function globalGapFixInit() {
       });
     };
 
-    requestAnimationFrame(() => maybeFix(document));
+    requestAnimationFrame(() => maybeFix(root));
+
+    // Batch DOM mutation processing into a single rAF to avoid doing work per mutation.
+    const pending = new Set();
+    let scheduled = false;
+    const scheduleFlush = () => {
+      if (scheduled) return;
+      scheduled = true;
+      requestAnimationFrame(() => {
+        scheduled = false;
+        pending.forEach((n) => {
+          try { maybeFix(n); } catch (e) {}
+        });
+        pending.clear();
+      });
+    };
 
     const obs = new MutationObserver((muts) => {
       for (const m of muts) {
-        const t = m.target;
         if (m.type === 'attributes') {
-          maybeFix(t && t.nodeType === 1 ? t : t && t.parentElement);
+          const t = m.target && m.target.nodeType === 1 ? m.target : m.target && m.target.parentElement;
+          if (t) pending.add(t);
         } else if (m.addedNodes && m.addedNodes.length) {
           m.addedNodes.forEach((n) => {
-            if (n && n.nodeType === 1) maybeFix(n);
+            if (n && n.nodeType === 1) pending.add(n);
           });
         }
       }
+      if (pending.size) scheduleFlush();
     });
-    obs.observe(document.documentElement, { subtree: true, childList: true, attributes: true, attributeFilter: ['style'] });
+    obs.observe(root, { subtree: true, childList: true, attributes: true, attributeFilter: ['style'] });
   } catch (e) {}
 }
 
@@ -546,6 +602,10 @@ function globalGapFixInit() {
     wrap.setAttribute('data-ezoic-after', String(afterPos));
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.setAttribute('data-created', String(now()));
+    // "Pinned" placements (after the first item) should remain stable.
+    if (afterPos === 1) {
+      wrap.setAttribute('data-ezoic-pin', '1');
+    }
     wrap.style.width = '100%';
 
     if (createPlaceholder) {
@@ -604,8 +664,9 @@ function globalGapFixInit() {
   }
 
   function pruneOrphanWraps(kindClass, items) {
-    // On mobile topics/messages, keep wraps alive longer to avoid 'disappearing' ads.
-    if (kindClass === 'ezoic-ad-message' && isMobile()) return 0;
+    // Message ads should remain stable (desktop + mobile). Pruning them can make it look like
+    // ads vanish on scroll and can reduce fill on long topics.
+    if (kindClass === 'ezoic-ad-message') return 0;
     if (!items || !items.length) return 0;
     const itemSet = new Set(items);
     const wraps = document.querySelectorAll(`.${WRAP_CLASS}.${kindClass}`);
@@ -631,6 +692,11 @@ function globalGapFixInit() {
     };
 
     wraps.forEach((wrap) => {
+      // Never prune pinned placements.
+      try {
+        if (wrap.getAttribute('data-ezoic-pin') === '1') return;
+      } catch (e) {}
+
       if (isFilled(wrap)) return; // never prune filled ads
 
       // Never prune a fresh wrap: it may fill late.
@@ -670,9 +736,19 @@ function globalGapFixInit() {
 
     let removed = 0;
     for (const w of wraps) {
+      // Never decluster pinned placements.
+      try {
+        if (w.getAttribute && w.getAttribute('data-ezoic-pin') === '1') continue;
+      } catch (e) {}
+
       let prev = w.previousElementSibling;
       for (let i = 0; i < 3 && prev; i++) {
         if (isWrap(prev)) {
+          // If the previous wrap is pinned, keep this one (spacing is intentional).
+          try {
+            if (prev.getAttribute && prev.getAttribute('data-ezoic-pin') === '1') break;
+          } catch (e) {}
+
           // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
           // Only decluster when at least one is filled, or when the newer one is stale.
           const prevFilled = isFilled(prev);
@@ -1020,6 +1096,10 @@ function globalGapFixInit() {
 
     state.heroDoneForPage = true;
     observePlaceholder(id);
+    // Hero placement is expected to be visible right away (after first item),
+    // so kick a fill request immediately instead of waiting only for IO callbacks.
+    enqueueShow(id);
+    startShowQueue();
   }
 
   // ---------------- scheduler ----------------
@@ -1154,6 +1234,7 @@ function globalGapFixInit() {
       state.pageKey = getPageKey();
       blockedUntil = 0;
 
+      muteNoisyConsole();
       warmUpNetwork();
       patchShowAds();
       globalGapFixInit();
@@ -1208,6 +1289,7 @@ function globalGapFixInit() {
   // ---------------- boot ----------------
 
   state.pageKey = getPageKey();
+  muteNoisyConsole();
   warmUpNetwork();
   patchShowAds();
   ensurePreloadObserver();