nodebb-plugin-ezoic-infinite 1.5.74 → 1.5.76

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.74",
+  "version": "1.5.76",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -38,6 +38,46 @@
   // Production build: debug disabled
   function dbg() {}
 
+  // Ezoic (and some partner scripts) can be very noisy in console on SPA/Ajaxify setups.
+  // These warnings are not actionable for end-users and can flood the console.
+  // We selectively silence the known spam patterns while keeping other warnings intact.
+  function muteNoisyConsole() {
+    try {
+      if (window.__nodebbEzoicConsoleMuted) return;
+      window.__nodebbEzoicConsoleMuted = true;
+
+      const shouldMute = (args) => {
+        try {
+          if (!args || !args.length) return false;
+          const s0 = typeof args[0] === 'string' ? args[0] : '';
+          // Duplicate placeholder definition spam (common when reusing ids in SPA/Ajaxify).
+          if (s0.includes('[EzoicAds JS]: Placeholder Id') && s0.includes('has already been defined')) return true;
+          // Ezoic debugger iframe spam.
+          if (s0.includes('Debugger iframe already exists')) return true;
+          // Missing placeholder spam (we already guard showAds; Ezoic still logs sometimes).
+          if (s0.includes('HTML element with id ezoic-pub-ad-placeholder-') && s0.includes('does not exist')) return true;
+          return false;
+        } catch (e) {
+          return false;
+        }
+      };
+
+      const wrap = (method) => {
+        const orig = console[method];
+        if (typeof orig !== 'function') return;
+        console[method] = function (...args) {
+          if (shouldMute(args)) return;
+          return orig.apply(console, args);
+        };
+      };
+
+      wrap('log');
+      wrap('info');
+      wrap('warn');
+      wrap('error');
+    } catch (e) {}
+  }
+
   
 
 function isFilledNode(node) {
@@ -145,19 +185,88 @@ function tightenEzoicMinHeight(wrap) {
 function watchWrapForFill(wrap) {
   try {
     if (!wrap || wrap.__ezFillObs) return;
-    const obs = new MutationObserver(() => {
+
+    // Ezoic can (re)apply inline styles after fill; keep tightening for a short window.
+    const start = now();
+    const tightenBurst = () => {
+      try { tightenEzoicMinHeight(wrap); } catch (e) {}
+      if (now() - start < 6000) {
+        setTimeout(tightenBurst, 350);
+      }
+    };
+
+    const obs = new MutationObserver((muts) => {
+      // If anything that looks like ad content appears, treat as filled.
       if (isFilledNode(wrap)) {
         wrap.classList.remove('is-empty');
-        tightenEzoicMinHeight(wrap);
+        tightenBurst();
+      }
+
+      // If Ezoic changes inline style on descendants (min-height:400!important), tighten again.
+      for (const m of muts) {
+        if (m.type === 'attributes' && m.attributeName === 'style') {
+          try { tightenEzoicMinHeight(wrap); } catch (e) {}
+          break;
+        }
+      }
+
+      // Disconnect only after the burst window to avoid missing late style rewrites.
+      if (now() - start > 7000) {
         try { obs.disconnect(); } catch (e) {}
         wrap.__ezFillObs = null;
       }
     });
-    obs.observe(wrap, { childList: true, subtree: true });
+
+    obs.observe(wrap, { childList: true, subtree: true, attributes: true, attributeFilter: ['style'] });
     wrap.__ezFillObs = obs;
   } catch (e) {}
 }
 
+// Global safety net: sometimes Ezoic swaps nodes in ways that bypass our per-wrap observers.
+// When we see an Ezoic container with min-height:400!important inside posts/topics, shrink it.
+function globalGapFixInit() {
+  try {
+    if (window.__nodebbEzoicGapFix) return;
+    window.__nodebbEzoicGapFix = true;
+
+    const inPostArea = (el) => {
+      try {
+        return !!(el && el.closest && el.closest('[component="post"], .topic, .posts, [component="topic"]'));
+      } catch (e) { return false; }
+    };
+
+    const maybeFix = (root) => {
+      if (!root || !root.querySelectorAll) return;
+      const nodes = root.querySelectorAll('.ezoic-ad[style*="min-height"], .ezoic-ad-adaptive[style*="min-height"]');
+      nodes.forEach((n) => {
+        const st = (n.getAttribute('style') || '').toLowerCase();
+        if (!st.includes('min-height:400')) return;
+        if (!inPostArea(n)) return;
+        try {
+          const tmpWrap = n.closest('.' + WRAP_CLASS) || n.parentElement;
+          tightenEzoicMinHeight(tmpWrap || n);
+        } catch (e) {}
+      });
+    };
+
+    requestAnimationFrame(() => maybeFix(document));
+
+    const obs = new MutationObserver((muts) => {
+      for (const m of muts) {
+        const t = m.target;
+        if (m.type === 'attributes') {
+          maybeFix(t && t.nodeType === 1 ? t : t && t.parentElement);
+        } else if (m.addedNodes && m.addedNodes.length) {
+          m.addedNodes.forEach((n) => {
+            if (n && n.nodeType === 1) maybeFix(n);
+          });
+        }
+      }
+    });
+    obs.observe(document.documentElement, { subtree: true, childList: true, attributes: true, attributeFilter: ['style'] });
+  } catch (e) {}
+}
+
 // ---------------- state ----------------
 
   const state = {
@@ -477,6 +586,10 @@ function watchWrapForFill(wrap) {
     wrap.setAttribute('data-ezoic-after', String(afterPos));
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.setAttribute('data-created', String(now()));
+    // "Pinned" placements (after the first item) should remain stable.
+    if (afterPos === 1) {
+      wrap.setAttribute('data-ezoic-pin', '1');
+    }
     wrap.style.width = '100%';
 
     if (createPlaceholder) {
@@ -535,8 +648,9 @@ function watchWrapForFill(wrap) {
   }
 
   function pruneOrphanWraps(kindClass, items) {
-    // On mobile topics/messages, keep wraps alive longer to avoid 'disappearing' ads.
-    if (kindClass === 'ezoic-ad-message' && isMobile()) return 0;
+    // Message ads should remain stable (desktop + mobile). Pruning them can make it look like
+    // ads vanish on scroll and can reduce fill on long topics.
+    if (kindClass === 'ezoic-ad-message') return 0;
     if (!items || !items.length) return 0;
     const itemSet = new Set(items);
     const wraps = document.querySelectorAll(`.${WRAP_CLASS}.${kindClass}`);
@@ -562,6 +676,11 @@ function watchWrapForFill(wrap) {
     };
 
     wraps.forEach((wrap) => {
+      // Never prune pinned placements.
+      try {
+        if (wrap.getAttribute('data-ezoic-pin') === '1') return;
+      } catch (e) {}
+
       if (isFilled(wrap)) return; // never prune filled ads
 
       // Never prune a fresh wrap: it may fill late.
@@ -601,9 +720,19 @@ function watchWrapForFill(wrap) {
 
     let removed = 0;
     for (const w of wraps) {
+      // Never decluster pinned placements.
+      try {
+        if (w.getAttribute && w.getAttribute('data-ezoic-pin') === '1') continue;
+      } catch (e) {}
+
       let prev = w.previousElementSibling;
       for (let i = 0; i < 3 && prev; i++) {
         if (isWrap(prev)) {
+          // If the previous wrap is pinned, keep this one (spacing is intentional).
+          try {
+            if (prev.getAttribute && prev.getAttribute('data-ezoic-pin') === '1') break;
+          } catch (e) {}
+
           // Don't decluster two "fresh" empty wraps — it can reduce fill on slow auctions.
           // Only decluster when at least one is filled, or when the newer one is stale.
           const prevFilled = isFilled(prev);
@@ -951,6 +1080,10 @@ function watchWrapForFill(wrap) {
 
     state.heroDoneForPage = true;
     observePlaceholder(id);
+    // Hero placement is expected to be visible right away (after first item),
+    // so kick a fill request immediately instead of waiting only for IO callbacks.
+    enqueueShow(id);
+    startShowQueue();
   }
 
   // ---------------- scheduler ----------------
@@ -1085,8 +1218,10 @@ function watchWrapForFill(wrap) {
       state.pageKey = getPageKey();
       blockedUntil = 0;
 
+      muteNoisyConsole();
       warmUpNetwork();
       patchShowAds();
+      globalGapFixInit();
       ensurePreloadObserver();
       ensureDomObserver();
 
@@ -1138,6 +1273,7 @@ function watchWrapForFill(wrap) {
   // ---------------- boot ----------------
 
   state.pageKey = getPageKey();
+  muteNoisyConsole();
   warmUpNetwork();
   patchShowAds();
   ensurePreloadObserver();