nodebb-plugin-ezoic-infinite 1.5.69 → 1.5.70

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.69",
+  "version": "1.5.70",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -393,12 +393,22 @@
 
     wraps.forEach((wrap) => {
       let ok = false;
+      // NodeBB/skins can insert helper nodes between posts (clearfix, separators, etc.).
+      // Be tolerant so we don't remove a valid ad too early ("disappears too fast").
       let prev = wrap.previousElementSibling;
-      for (let i = 0; i < 3 && prev; i++) {
+      for (let i = 0; i < 8 && prev; i++) {
         if (itemSet.has(prev)) { ok = true; break; }
         prev = prev.previousElementSibling;
       }
 
+      if (!ok) {
+        let next = wrap.nextElementSibling;
+        for (let i = 0; i < 3 && next; i++) {
+          if (itemSet.has(next)) { ok = true; break; }
+          next = next.nextElementSibling;
+        }
+      }
+
       if (!ok) {
         withInternalDomChange(() => releaseWrapNode(wrap));
         removed++;
@@ -469,6 +479,9 @@
     if (!ph || !ph.isConnected) return;
     ph.setAttribute('data-ezoic-id', String(id));
 
+    // When the ad actually fills, tighten height to the real iframe height and remove empty-collapsing.
+    armFillObserver(ph);
+
     const io = ensurePreloadObserver();
     try { io && io.observe(ph); } catch (e) {}
 
@@ -481,6 +494,56 @@
     } catch (e) {}
   }
 
+  // ---------------- fill tightening ----------------
+
+  const _fillObserved = new WeakSet();
+  function tightenFilled(ph) {
+    if (!ph || !ph.isConnected) return;
+    const wrap = ph.closest ? ph.closest(`.${WRAP_CLASS}`) : null;
+    if (!wrap) return;
+
+    // If we have any real ad content, we should not be in "empty" mode.
+    const frame = ph.querySelector ? ph.querySelector('iframe') : null;
+    const hasAd = !!(frame || (ph.querySelector && ph.querySelector('ins, img, .ez-ad, .ezoic-ad')));
+    if (!hasAd) return;
+
+    try { wrap.classList.remove('is-empty'); } catch (e) {}
+
+    // Remove the common "extra reserved space" created by Ezoic's min-height styles.
+    // Set minHeight to the actual iframe height when available.
+    try {
+      if (frame && frame.offsetHeight) {
+        const h = frame.offsetHeight;
+        const ezoicSpan = ph.closest ? ph.closest('span.ezoic-ad, .ezoic-ad') : null;
+        if (ezoicSpan && ezoicSpan.style) {
+          ezoicSpan.style.minHeight = `${h}px`;
+        }
+        // Also tighten the wrapper itself to avoid "space under" when the parent is taller.
+        wrap.style.minHeight = `${h}px`;
+      }
+    } catch (e) {}
+  }
+
+  function armFillObserver(ph) {
+    if (!ph || _fillObserved.has(ph)) return;
+    _fillObserved.add(ph);
+
+    // Fast path: already filled
+    try { tightenFilled(ph); } catch (e) {}
+
+    // Observe until it fills, then disconnect.
+    try {
+      const mo = new MutationObserver(() => {
+        try {
+          tightenFilled(ph);
+          const hasFrame = !!(ph.querySelector && ph.querySelector('iframe'));
+          if (hasFrame) mo.disconnect();
+        } catch (e) {}
+      });
+      mo.observe(ph, { childList: true, subtree: true });
+    } catch (e) {}
+  }
+
   function enqueueShow(id) {
     if (!id || isBlocked()) return;
 

package/public/style.css

@@ -22,6 +22,10 @@
 .nodebb-ezoic-wrap .ezoic-ad {
   margin: 0 !important;
   padding: 0 !important;
+  /* Ezoic sometimes reserves extra height (e.g. min-height: 400px) even when the filled iframe is smaller.
+     We prefer zero unused space; JS will also tighten after fill to the real iframe height. */
+  min-height: 0 !important;
+  height: auto !important;
 }
 
 /* Remove the classic "gap under iframe" (baseline/inline-block) */