nodebb-plugin-ezoic-infinite 1.5.67 → 1.5.68

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.67",
+  "version": "1.5.68",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -100,6 +100,36 @@
 
   const insertingIds = new Set();
 
+  // Hidden pool where we keep placeholder DIVs when they are not currently
+  // mounted in the content flow. This avoids:
+  //  - Ezoic trying to act on ids that were removed from the DOM ("does not exist")
+  //  - re-defining placeholders (we re-use the same node)
+  const POOL_ID = 'nodebb-ezoic-placeholder-pool';
+  function getPoolEl() {
+    let el = document.getElementById(POOL_ID);
+    if (el) return el;
+    el = document.createElement('div');
+    el.id = POOL_ID;
+    el.style.cssText = 'position:fixed;left:-99999px;top:-99999px;width:1px;height:1px;overflow:hidden;opacity:0;pointer-events:none;';
+    (document.body || document.documentElement).appendChild(el);
+    return el;
+  }
+
+  function isInPool(ph) {
+    try { return !!(ph && ph.closest && ph.closest('#' + POOL_ID)); } catch (e) { return false; }
+  }
+
+  function releaseWrapNode(wrap) {
+    try {
+      const ph = wrap && wrap.querySelector && wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`);
+      if (ph) {
+        try { getPoolEl().appendChild(ph); } catch (e) {}
+        try { if (state.io) state.io.unobserve(ph); } catch (e) {}
+      }
+    } catch (e) {}
+    try { wrap && wrap.remove && wrap.remove(); } catch (e) {}
+  }
+
 
   function markEmptyWrapper(id) {
     try {
@@ -354,11 +384,11 @@ function withInternalDomChange(fn) {
       }
 
       if (!ok) {
-        const id = getWrapIdFromWrap(wrap);
         withInternalDomChange(() => {
           try {
-            if (id) safeDestroyById(id);
-            wrap.remove();
+            // Do not destroy placeholders; move them back to the pool so
+            // Ezoic won't log "does not exist" and we can reuse them later.
+            releaseWrapNode(wrap);
           } catch (e) {}
         });
         removed++;
@@ -384,17 +414,19 @@ function withInternalDomChange(fn) {
     }, 3500);
   }
 
-function buildWrap(id, kindClass, afterPos) {
+function buildWrap(id, kindClass, afterPos, createPlaceholder) {
     const wrap = document.createElement('div');
     wrap.className = `${WRAP_CLASS} ${kindClass}`;
     wrap.setAttribute('data-ezoic-after', String(afterPos));
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.style.width = '100%';
 
-    const ph = document.createElement('div');
-    ph.id = `${PLACEHOLDER_PREFIX}${id}`;
-    ph.setAttribute('data-ezoic-id', String(id));
-    wrap.appendChild(ph);
+    if (createPlaceholder) {
+      const ph = document.createElement('div');
+      ph.id = `${PLACEHOLDER_PREFIX}${id}`;
+      ph.setAttribute('data-ezoic-id', String(id));
+      wrap.appendChild(ph);
+    }
 
     return wrap;
   }
@@ -412,16 +444,20 @@ function buildWrap(id, kindClass, afterPos) {
 
     insertingIds.add(id);
     try {
-      const wrap = buildWrap(id, kindClass, afterPos);
+      // If a placeholder already exists (either in content or in our pool),
+      // do NOT create a new DOM node with the same id even temporarily.
+      const wrap = buildWrap(id, kindClass, afterPos, !existingPh);
       target.insertAdjacentElement('afterend', wrap);
 
       // If a placeholder with this id already exists elsewhere (some Ezoic flows
       // pre-create placeholders), move it into our wrapper instead of aborting.
       // replaceChild moves the node atomically (no detach window).
-      if (existingPh && existingPh !== wrap.firstElementChild) {
+      if (existingPh) {
         try {
           existingPh.setAttribute('data-ezoic-id', String(id));
-          wrap.replaceChild(existingPh, wrap.firstElementChild);
+          // If we didn't create a placeholder, just append.
+          if (!wrap.firstElementChild) wrap.appendChild(existingPh);
+          else wrap.replaceChild(existingPh, wrap.firstElementChild);
         } catch (e) {
           // Keep the new placeholder if replace fails.
         }
@@ -443,7 +479,9 @@ function buildWrap(id, kindClass, afterPos) {
 
       const id = allIds[idx];
       const ph = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
-      if (ph && ph.isConnected) continue;
+      // If placeholder is currently mounted in the content flow, skip.
+      // If it's in our hidden pool, it's available for reuse.
+      if (ph && ph.isConnected && !isInPool(ph)) continue;
 
       return id;
     }
@@ -465,13 +503,7 @@ function buildWrap(id, kindClass, afterPos) {
       // Otherwise remove the earliest one in the document
       if (!victim) victim = wraps[0];
 
-      // Unobserve placeholder if still observed
-      try {
-        const ph = victim.querySelector && victim.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`);
-        if (ph && state.io) state.io.unobserve(ph);
-      } catch (e) {}
-
-      victim.remove();
+      releaseWrapNode(victim);
       return true;
     } catch (e) {
       return false;
@@ -625,15 +657,6 @@ function startShow(id) {
       if (i % interval === 0) out.push(i);
     }
     return Array.from(new Set(out)).sort((a, b) => a - b);
-    // If we inserted the maximum batch, likely there are more targets.
-    // Schedule a follow-up pass (bounded via scheduleRun coalescing).
-    const maxInserts = MAX_INSERTS_PER_RUN + (isBoosted() ? 1 : 0);
-    if (insertedThisRun >= maxInserts) {
-      scheduleRun(120);
-      scheduleRun(420);
-    }
-  }
-
   }
 
   function injectBetween(kindClass, items, interval, showFirst, allIds, cursorKey) {
@@ -838,7 +861,7 @@ function startShow(id) {
     // remove all wrappers
     try {
       document.querySelectorAll(`.${WRAP_CLASS}`).forEach((el) => {
-        try { el.remove(); } catch (e) {}
+        releaseWrapNode(el);
       });
     } catch (e) {}