nodebb-plugin-ezoic-infinite 1.5.62 → 1.5.63

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.62",
+  "version": "1.5.63",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -329,12 +329,12 @@ function withInternalDomChange(fn) {
   }
 
   function safeDestroyById(id) {
-    try {
-      const ez = window.ezstandalone;
-      if (ez && typeof ez.destroyPlaceholders === 'function') {
-        ez.destroyPlaceholders([`${PLACEHOLDER_PREFIX}${id}`]);
-      }
-    } catch (e) {}
+    // IMPORTANT:
+    // Do NOT call ez.destroyPlaceholders here.
+    // In NodeBB ajaxify/infinite-scroll flows, Ezoic can be mid-refresh.
+    // Destroy calls can create churn, reduce fill, and generate "does not exist" spam.
+    // We only remove our wrapper; Ezoic manages slot lifecycle.
+    return;
   }
 
   function pruneOrphanWraps(kindClass, items) {
@@ -408,12 +408,23 @@ function buildWrap(id, kindClass, afterPos) {
     if (insertingIds.has(id)) return null;
 
     const existingPh = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
-    if (existingPh && existingPh.isConnected) return null;
 
     insertingIds.add(id);
     try {
       const wrap = buildWrap(id, kindClass, afterPos);
       target.insertAdjacentElement('afterend', wrap);
+
+      // If a placeholder with this id already exists elsewhere (some Ezoic flows
+      // pre-create placeholders), move it into our wrapper instead of aborting.
+      // replaceChild moves the node atomically (no detach window).
+      if (existingPh && existingPh !== wrap.firstElementChild) {
+        try {
+          existingPh.setAttribute('data-ezoic-id', String(id));
+          wrap.replaceChild(existingPh, wrap.firstElementChild);
+        } catch (e) {
+          // Keep the new placeholder if replace fails.
+        }
+      }
       return wrap;
     } finally {
       insertingIds.delete(id);