nodebb-plugin-ezoic-infinite 1.5.57 → 1.5.59

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.57",
+  "version": "1.5.59",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -13,9 +13,24 @@
 // and eliminates "HTML element with id ... does not exist" noise.
 const POOL_ID = 'ezoic-placeholder-pool';
 
+function isInPool(el) {
+  try { return !!(el && el.closest && el.closest('#' + POOL_ID)); } catch (e) { return false; }
+}
+
+function isPlaceholderInUse(ph) {
+  // In use = connected AND not parked in our offscreen pool.
+  try { return !!(ph && ph.isConnected && !isInPool(ph)); } catch (e) { return false; }
+}
+
 function ensurePool() {
   let pool = document.getElementById(POOL_ID);
-  if (pool) return pool;
+  if (pool) {
+    // In rare cases (aggressive SPA navigation), the pool may get detached.
+    if (!pool.isConnected) {
+      try { (document.documentElement || document.body).appendChild(pool); } catch (e) {}
+    }
+    return pool;
+  }
   pool = document.createElement('div');
   pool.id = POOL_ID;
   pool.style.position = 'absolute';
@@ -77,6 +92,7 @@ function acquirePlaceholder(id) {
     if (ph.dataset) {
       ph.dataset.ezRequested = '0';
       ph.dataset.ezDefined = '0';
+      ph.dataset.ezActive = '0';
     }
   } catch (e) {}
   return ph;
@@ -87,6 +103,7 @@ function parkPlaceholderFromWrap(wrap) {
     const ph = wrap && wrap.querySelector ? wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`) : null;
     if (!ph) return;
     try { if (state && state.io) state.io.unobserve(ph); } catch (e) {}
+    try { if (ph.dataset) ph.dataset.ezActive = '0'; } catch (e) {}
     ensurePool().appendChild(ph);
   } catch (e) {}
 }
@@ -322,8 +339,24 @@ function parkPlaceholderFromWrap(wrap) {
           if (!Number.isFinite(id) || id <= 0 || seen.has(id)) continue;
 
           const domId = `${PLACEHOLDER_PREFIX}${id}`;
-          const ph = document.getElementById(domId);
-          if (!ph || !ph.isConnected) continue;
+          let ph = document.getElementById(domId);
+          if (!ph || !ph.isConnected) {
+            // If Ezoic (or another script) tries to show an id we haven't injected yet,
+            // create the placeholder in the offscreen pool so it exists, but don't load.
+            try {
+              ph = document.createElement('div');
+              ph.id = domId;
+              ph.setAttribute('data-ezoic-id', String(id));
+              if (ph.dataset) ph.dataset.ezActive = '0';
+              ensurePool().appendChild(ph);
+            } catch (e) {}
+            continue;
+          }
+
+          // Only allow loads for placeholders actively injected into the page (not parked in the pool)
+          // and currently marked active.
+          if (!isPlaceholderInUse(ph)) continue;
+          if (ph.dataset && ph.dataset.ezActive !== '1') continue;
 
           // Prevent repeated "define" attempts on the same placeholder while it remains in DOM.
           if (ph.dataset && (ph.dataset.ezRequested === '1' || ph.dataset.ezDefined === '1')) continue;
@@ -546,6 +579,7 @@ function buildWrap(id, kindClass, afterPos) {
     wrap.style.width = '100%';
 
     const ph = acquirePlaceholder(id);
+    try { if (ph.dataset) ph.dataset.ezActive = '1'; } catch (e) {}
     wrap.appendChild(ph);
 
     return wrap;
@@ -561,7 +595,7 @@ function buildWrap(id, kindClass, afterPos) {
     if (insertingIds.has(id)) return null;
 
     const existingPh = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
-    if (existingPh && existingPh.isConnected) return null;
+    if (existingPh && isPlaceholderInUse(existingPh)) return null;
 
     insertingIds.add(id);
     try {
@@ -584,7 +618,7 @@ function buildWrap(id, kindClass, afterPos) {
 
       const id = allIds[idx];
       const ph = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
-      if (ph && ph.isConnected) continue;
+      if (ph && isPlaceholderInUse(ph)) continue;
 
       return id;
     }