nodebb-plugin-ezoic-infinite 1.5.55 → 1.5.56

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.55",
+  "version": "1.5.56",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -25,10 +25,42 @@ function ensurePool() {
   pool.style.height = '1px';
   pool.style.overflow = 'hidden';
   pool.setAttribute('aria-hidden', 'true');
-  try { (document.body || document.documentElement).appendChild(pool); } catch (e) {}
+  // Attach early (documentElement exists before body), so placeholders are always connected.
+  try { (document.documentElement || document.body).appendChild(pool); } catch (e) {}
+  // If body exists later, move it under body (purely cosmetic).
+  try {
+    if (document.body && pool.parentNode !== document.body) {
+      document.body.appendChild(pool);
+    }
+  } catch (e) {}
   return pool;
 }
 
+// Create placeholder divs for all configured ids upfront.
+// Ezoic sometimes attempts to initialize/refresh a range of ids even if we
+// haven't injected them yet; keeping them in the offscreen pool prevents
+// "HTML element ... does not exist" spam.
+function primePool(ids) {
+  try {
+    if (!ids || !ids.length) return;
+    const pool = ensurePool();
+    for (const v of ids) {
+      const id = parseInt(v, 10);
+      if (!Number.isFinite(id) || id <= 0) continue;
+      const domId = `${PLACEHOLDER_PREFIX}${id}`;
+      let ph = document.getElementById(domId);
+      if (!ph) {
+        ph = document.createElement('div');
+        ph.id = domId;
+        ph.setAttribute('data-ezoic-id', String(id));
+        pool.appendChild(ph);
+      } else if (!ph.isConnected) {
+        pool.appendChild(ph);
+      }
+    }
+  } catch (e) {}
+}
+
 function acquirePlaceholder(id) {
   const domId = `${PLACEHOLDER_PREFIX}${id}`;
   let ph = document.getElementById(domId);
@@ -409,6 +441,12 @@ function withInternalDomChange(fn) {
     if (state.allTopics.length === 0) state.allTopics = parsePool(cfg.placeholderIds);
     if (state.allPosts.length === 0) state.allPosts = parsePool(cfg.messagePlaceholderIds);
     if (state.allCategories.length === 0) state.allCategories = parsePool(cfg.categoryPlaceholderIds);
+
+    // Keep placeholders alive even before they're injected.
+    // This avoids Ezoic trying to touch ids that we haven't inserted yet.
+    primePool(state.allTopics);
+    primePool(state.allPosts);
+    primePool(state.allCategories);
   }
 
   // ---------- insertion primitives ----------
@@ -786,6 +824,25 @@ function startShow(id) {
       inserted += 1;
     }
 
+    // Safety: if DOM churn results in two consecutive ad wrappers, remove the latter.
+    // (This can happen when NodeBB inserts/removes spacer elements around the anchor.)
+    try {
+      const wraps = Array.from(document.querySelectorAll(`.${WRAP_CLASS}.${kindClass}`));
+      for (const w of wraps) {
+        const prev = w.previousElementSibling;
+        if (prev && prev.classList && prev.classList.contains(WRAP_CLASS)) {
+          withInternalDomChange(() => {
+            try {
+              const id = getWrapIdFromWrap(w);
+              if (id) safeDestroyById(id);
+              parkPlaceholderFromWrap(w);
+              w.remove();
+            } catch (e) {}
+          });
+        }
+      }
+    } catch (e) {}
+
     return inserted;
   }