nodebb-plugin-ezoic-infinite 1.5.54 → 1.5.56

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.54",
+  "version": "1.5.56",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -7,6 +7,89 @@
   const WRAP_CLASS = 'ezoic-ad';
   const PLACEHOLDER_PREFIX = 'ezoic-pub-ad-placeholder-';
 
+
+// Offscreen pool to keep placeholder elements alive across ajaxify/navigation.
+// This prevents Ezoic from trying to define ids that are not currently injected,
+// and eliminates "HTML element with id ... does not exist" noise.
+const POOL_ID = 'ezoic-placeholder-pool';
+
+function ensurePool() {
+  let pool = document.getElementById(POOL_ID);
+  if (pool) return pool;
+  pool = document.createElement('div');
+  pool.id = POOL_ID;
+  pool.style.position = 'absolute';
+  pool.style.left = '-99999px';
+  pool.style.top = '0';
+  pool.style.width = '1px';
+  pool.style.height = '1px';
+  pool.style.overflow = 'hidden';
+  pool.setAttribute('aria-hidden', 'true');
+  // Attach early (documentElement exists before body), so placeholders are always connected.
+  try { (document.documentElement || document.body).appendChild(pool); } catch (e) {}
+  // If body exists later, move it under body (purely cosmetic).
+  try {
+    if (document.body && pool.parentNode !== document.body) {
+      document.body.appendChild(pool);
+    }
+  } catch (e) {}
+  return pool;
+}
+
+// Create placeholder divs for all configured ids upfront.
+// Ezoic sometimes attempts to initialize/refresh a range of ids even if we
+// haven't injected them yet; keeping them in the offscreen pool prevents
+// "HTML element ... does not exist" spam.
+function primePool(ids) {
+  try {
+    if (!ids || !ids.length) return;
+    const pool = ensurePool();
+    for (const v of ids) {
+      const id = parseInt(v, 10);
+      if (!Number.isFinite(id) || id <= 0) continue;
+      const domId = `${PLACEHOLDER_PREFIX}${id}`;
+      let ph = document.getElementById(domId);
+      if (!ph) {
+        ph = document.createElement('div');
+        ph.id = domId;
+        ph.setAttribute('data-ezoic-id', String(id));
+        pool.appendChild(ph);
+      } else if (!ph.isConnected) {
+        pool.appendChild(ph);
+      }
+    }
+  } catch (e) {}
+}
+
+function acquirePlaceholder(id) {
+  const domId = `${PLACEHOLDER_PREFIX}${id}`;
+  let ph = document.getElementById(domId);
+  if (!ph) {
+    ph = document.createElement('div');
+    ph.id = domId;
+    ph.setAttribute('data-ezoic-id', String(id));
+    ensurePool().appendChild(ph);
+  }
+  // Detach from wherever it currently is (pool or a previous wrap)
+  try { if (ph.parentNode) ph.parentNode.removeChild(ph); } catch (e) {}
+  // Clear request/defined flags when reusing
+  try {
+    if (ph.dataset) {
+      ph.dataset.ezRequested = '0';
+      ph.dataset.ezDefined = '0';
+    }
+  } catch (e) {}
+  return ph;
+}
+
+function parkPlaceholderFromWrap(wrap) {
+  try {
+    const ph = wrap && wrap.querySelector ? wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`) : null;
+    if (!ph) return;
+    try { if (state && state.io) state.io.unobserve(ph); } catch (e) {}
+    ensurePool().appendChild(ph);
+  } catch (e) {}
+}
   // Insert at most N ads per run to keep the UI smooth on infinite scroll
   const MAX_INSERTS_PER_RUN = 3;
 
@@ -358,6 +441,12 @@ function withInternalDomChange(fn) {
     if (state.allTopics.length === 0) state.allTopics = parsePool(cfg.placeholderIds);
     if (state.allPosts.length === 0) state.allPosts = parsePool(cfg.messagePlaceholderIds);
     if (state.allCategories.length === 0) state.allCategories = parsePool(cfg.categoryPlaceholderIds);
+
+    // Keep placeholders alive even before they're injected.
+    // This avoids Ezoic trying to touch ids that we haven't inserted yet.
+    primePool(state.allTopics);
+    primePool(state.allPosts);
+    primePool(state.allCategories);
   }
 
   // ---------- insertion primitives ----------
@@ -422,6 +511,7 @@ function withInternalDomChange(fn) {
         withInternalDomChange(() => {
           try {
             if (id) safeDestroyById(id);
+            parkPlaceholderFromWrap(wrap);
             wrap.remove();
           } catch (e) {}
         });
@@ -455,9 +545,7 @@ function buildWrap(id, kindClass, afterPos) {
     wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.style.width = '100%';
 
-    const ph = document.createElement('div');
-    ph.id = `${PLACEHOLDER_PREFIX}${id}`;
-    ph.setAttribute('data-ezoic-id', String(id));
+    const ph = acquirePlaceholder(id);
     wrap.appendChild(ph);
 
     return wrap;
@@ -524,6 +612,7 @@ function buildWrap(id, kindClass, afterPos) {
         if (ph && state.io) state.io.unobserve(ph);
       } catch (e) {}
 
+      parkPlaceholderFromWrap(victim);
       victim.remove();
       return true;
     } catch (e) {
@@ -735,6 +824,25 @@ function startShow(id) {
       inserted += 1;
     }
 
+    // Safety: if DOM churn results in two consecutive ad wrappers, remove the latter.
+    // (This can happen when NodeBB inserts/removes spacer elements around the anchor.)
+    try {
+      const wraps = Array.from(document.querySelectorAll(`.${WRAP_CLASS}.${kindClass}`));
+      for (const w of wraps) {
+        const prev = w.previousElementSibling;
+        if (prev && prev.classList && prev.classList.contains(WRAP_CLASS)) {
+          withInternalDomChange(() => {
+            try {
+              const id = getWrapIdFromWrap(w);
+              if (id) safeDestroyById(id);
+              parkPlaceholderFromWrap(w);
+              w.remove();
+            } catch (e) {}
+          });
+        }
+      }
+    } catch (e) {}
+
     return inserted;
   }
 
@@ -870,6 +978,7 @@ function startShow(id) {
     // remove all wrappers
     try {
       document.querySelectorAll(`.${WRAP_CLASS}`).forEach((el) => {
+        try { parkPlaceholderFromWrap(el); } catch (e) {}
         try { el.remove(); } catch (e) {}
       });
     } catch (e) {}

package/public/style.css

@@ -38,3 +38,5 @@
 .ezoic-ad > [id^="ezoic-pub-ad-placeholder-"] {
   min-height: 0 !important;
 }
+
+#ezoic-placeholder-pool{display:block;}