nodebb-plugin-ezoic-infinite 1.5.27 → 1.5.29

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.27",
+  "version": "1.5.29",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -259,10 +259,70 @@ function withInternalDomChange(fn) {
     return false;
   }
 
-  function buildWrap(id, kindClass, afterPos) {
+  
+  function getWrapIdFromWrap(wrap) {
+    try {
+      const v = wrap.getAttribute('data-ezoic-wrapid');
+      if (v) return String(v);
+      const ph = wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`);
+      if (ph && ph.id) return ph.id.replace(PLACEHOLDER_PREFIX, '');
+    } catch (e) {}
+    return null;
+  }
+
+  function safeDestroyById(id) {
+    try {
+      const ez = window.ezstandalone;
+      if (ez && typeof ez.destroyPlaceholders === 'function') {
+        ez.destroyPlaceholders([`${PLACEHOLDER_PREFIX}${id}`]);
+      }
+    } catch (e) {}
+  }
+
+  function pruneOrphanWraps(kindClass, items) {
+    if (!items || !items.length) return 0;
+    const itemSet = new Set(items);
+    const wraps = document.querySelectorAll(`.${WRAP_CLASS}.${kindClass}`);
+    let removed = 0;
+
+    wraps.forEach((wrap) => {
+      const prev = wrap.previousElementSibling;
+      if (!prev || !itemSet.has(prev)) {
+        const id = getWrapIdFromWrap(wrap);
+        withInternalDomChange(() => {
+          try {
+            if (id) safeDestroyById(id);
+            wrap.remove();
+          } catch (e) {}
+        });
+        removed++;
+      }
+    });
+
+    if (removed) dbg('prune-orphan', kindClass, { removed });
+    return removed;
+  }
+
+  function refreshEmptyState(id) {
+    // After Ezoic has had a moment to fill the placeholder, toggle the CSS class.
+    window.setTimeout(() => {
+      try {
+        const ph = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
+        if (!ph || !ph.isConnected) return;
+        const wrap = ph.closest(`.${WRAP_CLASS}`);
+        if (!wrap) return;
+        const hasContent = ph.childElementCount > 0 || ph.offsetHeight > 0;
+        if (hasContent) wrap.classList.remove('is-empty');
+        else wrap.classList.add('is-empty');
+      } catch (e) {}
+    }, 1800);
+  }
+
+function buildWrap(id, kindClass, afterPos) {
     const wrap = document.createElement('div');
-    wrap.className = `${WRAP_CLASS} ${kindClass}`;
+    wrap.className = `${WRAP_CLASS} ${kindClass} is-empty`;
     wrap.setAttribute('data-ezoic-after', String(afterPos));
+    wrap.setAttribute('data-ezoic-wrapid', String(id));
     wrap.style.width = '100%';
 
     const ph = document.createElement('div');
@@ -569,9 +629,11 @@ function withInternalDomChange(fn) {
 
     if (kind === 'topic') {
       if (normalizeBool(cfg.enableMessageAds)) {
+        const __items = getPostContainers();
+        pruneOrphanWraps('ezoic-ad-message', __items);
         injectBetween(
           'ezoic-ad-message',
-          getPostContainers(),
+          __items,
           Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3),
           normalizeBool(cfg.showFirstMessageAd),
           state.allPosts,
@@ -580,9 +642,11 @@ function withInternalDomChange(fn) {
       }
     } else if (kind === 'categoryTopics') {
       if (normalizeBool(cfg.enableBetweenAds)) {
+        const __items = getTopicItems();
+        pruneOrphanWraps('ezoic-ad-between', __items);
         injectBetween(
           'ezoic-ad-between',
-          getTopicItems(),
+          __items,
           Math.max(1, parseInt(cfg.intervalPosts, 10) || 6),
           normalizeBool(cfg.showFirstTopicAd),
           state.allTopics,
@@ -591,9 +655,11 @@ function withInternalDomChange(fn) {
       }
     } else if (kind === 'categories') {
       if (normalizeBool(cfg.enableCategoryAds)) {
+        const __items = getCategoryItems();
+        pruneOrphanWraps('ezoic-ad-categories', __items);
         injectBetween(
           'ezoic-ad-categories',
-          getCategoryItems(),
+          __items,
           Math.max(1, parseInt(cfg.intervalCategories, 10) || 4),
           normalizeBool(cfg.showFirstCategoryAd),
           state.allCategories,

package/public/style.css

@@ -19,3 +19,21 @@
   margin: 0 !important;
   padding: 0 !important;
 }
+
+
+/* Collapse empty ad blocks (prevents "holes" when an ad doesn't fill or gets destroyed) */
+.ezoic-ad.is-empty {
+  display: none !important;
+  margin: 0 !important;
+  padding: 0 !important;
+  height: 0 !important;
+  min-height: 0 !important;
+}
+
+.ezoic-ad {
+  min-height: 0 !important;
+}
+
+.ezoic-ad > [id^="ezoic-pub-ad-placeholder-"] {
+  min-height: 0 !important;
+}