nodebb-plugin-ezoic-infinite 1.5.1 → 1.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.5.1",
+  "version": "1.5.3",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -1,4 +1,7 @@
 'use strict';
+
+// Safety stub: some Ezoic scripts expect a global queue even when ads are disabled
+window._ezaq = window._ezaq || [];
 /**
  * Ezoic Infinite Ads for NodeBB 4.x
  * - Event-driven only (ajaxify hooks + MutationObserver + IntersectionObserver)
@@ -8,15 +11,6 @@
  */
 
 (function () {
-
-// --- Safety stubs: prevent crashes if Ezoic scripts execute when ads are disabled/excluded ---
-window._ezaq = window._ezaq || [];
-window.ezstandalone = window.ezstandalone || {};
-window.ezstandalone.cmd = window.ezstandalone.cmd || [];
-if (typeof window.ezstandalone.showAds !== 'function') {
-  window.ezstandalone.showAds = function () {};
-}
-
   const CFG_URL = '/api/plugins/ezoic-infinite/config';
 
   // -------------------------
@@ -99,18 +93,13 @@ if (typeof window.ezstandalone.showAds !== 'function') {
         Pool.ensurePlaceholder(id);
 
         const el = document.getElementById(id);
-        if (!el || !document.body.contains(el)) continue;
-
-        // If the placeholder is still in the hidden pool, DO NOT render into it (would be invisible).
-        // We only render when the placeholder has been moved into a visible wrapper.
-        const pool = Pool.ensurePool();
-        if (pool && pool.contains(el)) continue;
-
-        try {
-          // Call one-by-one to avoid batch logging on missing nodes
-          original.call(window.ezstandalone, id);
-        } catch (e) {
-          // swallow: Ezoic can throw if called during transitions
+        if (el && document.body.contains(el)) {
+          try {
+            // Call one-by-one to avoid batch logging on missing nodes
+            original.call(window.ezstandalone, id);
+          } catch (e) {
+            // swallow: Ezoic can throw if called during transitions
+          }
         }
       }
     };
@@ -119,35 +108,19 @@ if (typeof window.ezstandalone.showAds !== 'function') {
     return wrapped;
   }
 
-  function installShowAdsHook() {
-    // If ezstandalone already exists, wrap now.
-    if (window.ezstandalone && window.ezstandalone.showAds) {
-      window.ezstandalone.showAds = wrapShowAds(window.ezstandalone.showAds);
-    }
-
-    // Hook future assignment (no polling)
-    try {
-      if (!window.ezstandalone) window.ezstandalone = {};
-      const ez = window.ezstandalone;
-
-      // If already has a setter installed, do nothing
-      const desc = Object.getOwnPropertyDescriptor(ez, 'showAds');
-      if (desc && (desc.set || desc.get)) return;
-
-      let _showAds = ez.showAds;
-      Object.defineProperty(ez, 'showAds', {
-        configurable: true,
-        enumerable: true,
-        get() { return _showAds; },
-        set(v) { _showAds = wrapShowAds(v); }
-      });
-
-      // Re-assign current value through setter
-      ez.showAds = _showAds;
-    } catch (e) {
-      // If defineProperty fails, best-effort wrap is still in place above.
-    }
+  
+function installShowAdsHook() {
+  // NOTE: Do NOT use Object.defineProperty accessor tricks on `ezstandalone.showAds`.
+  // Ezoic's standalone loader may validate that property as a plain writable function,
+  // and accessor hooks can cause `defineScript failed` / `displayScript failed`.
+  // Instead, we only wrap it once it exists (event-driven paths will call this again).
+  const ez = window.ezstandalone;
+  if (!ez) return;
+  if (!Array.isArray(ez.cmd)) ez.cmd = [];
+  if (typeof ez.showAds === 'function' && !ez.showAds.__ezoicInfiniteWrapped) {
+    ez.showAds = wrapShowAds(ez.showAds);
   }
+}
 
   function ezCmd(fn) {
     // Tokenize so queued callbacks don't run after navigation