nodebb-plugin-ezoic-infinite 1.4.74 → 1.4.76

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.4.74",
+  "version": "1.4.76",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -23,10 +23,6 @@
   usedPosts: new Set(),
   usedCategories: new Set(),
 
-  liveTopics: [],
-  livePosts: [],
-  liveCategories: [],
-
   lastShowById: new Map(),
   pendingById: new Set(),
   definedIds: new Set(),
@@ -146,32 +142,22 @@
   const ph = wrapper.querySelector('[id^="ezoic-pub-ad-placeholder-"]');
   if (!ph) return;
   
-  // Supprimer TOUS les éléments après le placeholder rempli
-  // qui créent de l'espace vertical
-  let found = false;
+  // SÉCURISÉ: Supprimer TOUT sauf le placeholder
+  // CRITIQUE: Ne JAMAIS toucher au placeholder ou ses enfants
   Array.from(wrapper.children).forEach(child => {
-  if (child === ph || child.contains(ph)) {
-  found = true;
-  return;
-  }
+  // Vérifier que ce n'est PAS le placeholder
+  if (child === ph) return;
+  if (child.contains(ph)) return;
+  if (child.id && child.id.startsWith('ezoic-pub-ad-placeholder-')) return;
   
-  // Si élément APRÈS le placeholder
-  if (found) {
-  const rect = child.getBoundingClientRect();
-  const computed = window.getComputedStyle(child);
-  
-  // Supprimer si:
-  // 1. Height > 0 mais pas de texte/image visible
-  // 2. Ou opacity: 0
-  // 3. Ou visibility: hidden
-  const hasContent = child.textContent.trim().length > 0 || 
-                    child.querySelector('img, iframe, video');
-  
-  if (!hasContent || computed.opacity === '0' || computed.visibility === 'hidden') {
+  // Supprimer le reste
   child.remove();
-  }
-  }
   });
+  
+  // Forcer wrapper sans espace
+  wrapper.style.height = 'auto';
+  wrapper.style.overflow = 'hidden';
+  wrapper.style.lineHeight = '0';
   });
   } catch (e) {}
   }
@@ -247,7 +233,6 @@
   wrap.className = `${WRAP_CLASS} ${kindClass}`;
   wrap.setAttribute('data-ezoic-after', String(afterPos));
   wrap.style.width = '100%';
-  wrap.style.display = 'none';
 
   const ph = document.createElement('div');
   ph.id = `${PLACEHOLDER_PREFIX}${id}`;
@@ -323,31 +308,11 @@
   }
   }
 
-  
-  function forcePlaceholderAutoHeight(wrap, id) {
-  try {
-  if (!wrap) return;
-  const ph = id ? wrap.querySelector && wrap.querySelector(`#${PLACEHOLDER_PREFIX}${id}`) : (wrap.querySelector && wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`));
-  if (!ph) return;
-  ph.style.setProperty('height', 'auto', 'important');
-  ph.style.setProperty('min-height', '0px', 'important');
-  requestAnimationFrame(() => {
-  try {
-  ph.style.setProperty('height', 'auto', 'important');
-  ph.style.setProperty('min-height', '0px', 'important');
-  } catch (e) {}
-  });
-  } catch (e) {}
-  }
-
-  function markFilled(wrap, id) {
+  function markFilled(wrap) {
   try {
   if (!wrap) return;
   if (wrap.__ezoicFillObs) { wrap.__ezoicFillObs.disconnect(); wrap.__ezoicFillObs = null; }
   wrap.setAttribute('data-ezoic-filled', '1');
-  // show wrapper only when filled (avoid blank gaps if consent/CMP blocks)
-  wrap.style.display = 'block';
-  forcePlaceholderAutoHeight(wrap, id);
   } catch (e) {}
   }
 
@@ -361,13 +326,13 @@
   if (!ph) return;
   // Already filled?
   if (ph.childNodes && ph.childNodes.length > 0) {
-  markFilled(wrap, id); // Afficher wrapper
+  markFilled(wrap); // Afficher wrapper
   sessionDefinedIds.add(id);
   return;
   }
   const obs = new MutationObserver(() => {
   if (ph.childNodes && ph.childNodes.length > 0) {
-  markFilled(wrap, id); // CRITIQUE: Afficher wrapper maintenant
+  markFilled(wrap); // CRITIQUE: Afficher wrapper maintenant
   try { sessionDefinedIds.add(id); } catch (e) {}
   try { obs.disconnect(); } catch (e) {}
   }
@@ -387,7 +352,7 @@
   const filled = !!(ph.childNodes && ph.childNodes.length > 0);
   if (filled) {
   try { state.definedIds && state.definedIds.add(id); sessionDefinedIds.add(id); } catch (e) {}
-  try { markFilled(wrap, id); } catch (e) {}
+  try { markFilled(wrap); } catch (e) {}
   }
   return filled;
   }
@@ -419,6 +384,14 @@
   const idsArray = Array.from(pendingShowAdsIds);
   pendingShowAdsIds.clear();
 
+  // CRITIQUE: Vérifier que placeholders existent encore
+  const validIds = idsArray.filter(id => {
+  const ph = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`);
+  return ph && ph.isConnected;
+  });
+  
+  if (validIds.length === 0) return;
+
   // Appeler showAds avec TOUS les IDs en une fois
   try {
   window.ezstandalone = window.ezstandalone || {};
@@ -426,9 +399,9 @@
   window.ezstandalone.cmd.push(function() {
   if (typeof window.ezstandalone.showAds === 'function') {
   // Appel batch: showAds(id1, id2, id3...)
-  window.ezstandalone.showAds(...idsArray);
+  window.ezstandalone.showAds(...validIds);
   // Tracker tous les IDs
-  idsArray.forEach(id => {
+  validIds.forEach(id => {
   state.lastShowById.set(id, Date.now());
   sessionDefinedIds.add(id);
   });
@@ -439,7 +412,7 @@
   // CRITIQUE: Nettoyer éléments invisibles APRÈS que pubs soient chargées
   setTimeout(() => {
   cleanupInvisibleEzoicElements();
-  }, 800); // 1.5s pour laisser Ezoic charger
+  }, 1500); // 1.5s pour laisser Ezoic charger
   }, 100);
   }
 
@@ -454,8 +427,6 @@
   window.ezstandalone = window.ezstandalone || {};
   if (typeof window.ezstandalone.showAds === 'function') {
 
-  const elNow = document.getElementById(phId);
-  if (!elNow || !elNow.isConnected) return false;
   state.lastShowById.set(id, Date.now());
   window.ezstandalone.showAds(id);
   sessionDefinedIds.add(id);
@@ -531,7 +502,7 @@
   return Array.from(new Set(out)).sort((a, b) => a - b);
   }
 
-  function injectBetween(kindClass, items, interval, showFirst, kindPool, usedSet, liveArr) {
+  function injectBetween(kindClass, items, interval, showFirst, kindPool, usedSet) {
   if (!items.length) return 0;
   const targets = computeTargets(items.length, interval, showFirst);
 
@@ -552,7 +523,7 @@
 
   if (findWrap(kindClass, afterPos)) continue;
 
-  const pick = pickId(kindPool, liveArr || []);
+  const pick = pickId(kindPool, []);
   const id = pick.id;
   if (!id) break;
 
@@ -578,7 +549,7 @@
   callShowAdsWhenReady(id);
   }
 
-  if (liveArr) liveArr.push({ id, wrap });
+  liveArr.push({ id, wrap });
   if (wrap && (
   (wrap.previousElementSibling && wrap.previousElementSibling.classList && wrap.previousElementSibling.classList.contains(WRAP_CLASS)) || (wrap.nextElementSibling && wrap.nextElementSibling.classList && wrap.nextElementSibling.classList.contains(WRAP_CLASS))
   )) {
@@ -678,7 +649,7 @@
   Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3),
   normalizeBool(cfg.showFirstMessageAd),
   state.poolPosts,
-  state.usedPosts, state.livePosts);
+  state.usedPosts);
   }
   } else if (kind === 'categoryTopics') {
   if (normalizeBool(cfg.enableBetweenAds)) {
@@ -686,7 +657,7 @@
   Math.max(1, parseInt(cfg.intervalPosts, 10) || 6),
   normalizeBool(cfg.showFirstTopicAd),
   state.poolTopics,
-  state.usedTopics, state.liveTopics);
+  state.usedTopics);
   }
   } else if (kind === 'categories') {
   if (normalizeBool(cfg.enableCategoryAds)) {
@@ -694,7 +665,7 @@
   Math.max(1, parseInt(cfg.intervalCategories, 10) || 4),
   normalizeBool(cfg.showFirstCategoryAd),
   state.poolCategories,
-  state.usedCategories, state.liveCategories);
+  state.usedCategories);
   }
   }
 

package/public/style.css

@@ -1,40 +1,21 @@
-/* Ezoic Infinite Ads (NodeBB) - production safe */
-/* Hide wrappers until ad actually fills to avoid blank gaps (e.g., CMP/consent issues) */
-.ezoic-ad{ 
-  display:none;
-  height:auto !important;
-  min-height:0 !important;
-  padding:0 !important;
-  margin:0 !important;
-  width:100%;
+.ezoic-ad {
+  height: auto !important;
+  padding: 0 !important;
+  margin: 0 !important;
+  border: 0 !important;
+  overflow: hidden !important;
+  line-height: 0 !important;
 }
 
-/* Marked filled => show */
-.ezoic-ad[data-ezoic-filled="1"]{
-  display:block;
+.ezoic-ad * {
+  margin: 0 !important;
+  padding: 0 !important;
+  border: 0 !important;
 }
 
-/* Placeholder must not reserve fixed height */
-.ezoic-ad > [id^="ezoic-pub-ad-placeholder-"]{
-  height:auto !important;
-  min-height:0 !important;
-  margin:0 !important;
-  padding:0 !important;
-}
-
-/* Prevent baseline gaps under iframes/ins */
-.ezoic-ad iframe,
-.ezoic-ad ins{
-  display:block !important;
-}
-
-/* Remove empty spacer divs if any */
-.ezoic-ad > div:empty{
-  display:none !important;
-}
-
-/* Defensive: wipe margins/paddings inside wrapper */
-.ezoic-ad *{
-  margin:0 !important;
-  padding:0 !important;
-}
+.ezoic-ad::after {
+  content: '';
+  display: block;
+  height: 0 !important;
+  margin: 0 !important;
+}