nodebb-plugin-ezoic-infinite 1.4.72 → 1.4.74

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.4.72",
+  "version": "1.4.74",
   "description": "Production-ready Ezoic infinite ads integration for NodeBB 4.x",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -23,6 +23,10 @@
   usedPosts: new Set(),
   usedCategories: new Set(),
 
+  liveTopics: [],
+  livePosts: [],
+  liveCategories: [],
+
   lastShowById: new Map(),
   pendingById: new Set(),
   definedIds: new Set(),
@@ -243,6 +247,7 @@
   wrap.className = `${WRAP_CLASS} ${kindClass}`;
   wrap.setAttribute('data-ezoic-after', String(afterPos));
   wrap.style.width = '100%';
+  wrap.style.display = 'none';
 
   const ph = document.createElement('div');
   ph.id = `${PLACEHOLDER_PREFIX}${id}`;
@@ -321,31 +326,28 @@
   
   function forcePlaceholderAutoHeight(wrap, id) {
   try {
-    if (!wrap || !id) return;
-    const ph = wrap.querySelector && wrap.querySelector(`#${PLACEHOLDER_PREFIX}${id}`);
-    if (!ph) return;
-    // Neutraliser les hauteurs réservées (inline ou CSS) qui créent un espace après la pub
-    ph.style.setProperty('height', 'auto', 'important');
-    ph.style.setProperty('min-height', '0px', 'important');
-    // Eviter le gap baseline sous les iframes/ins
-    wrap.querySelectorAll && wrap.querySelectorAll('iframe, ins').forEach(n => {
-      try { n.style.setProperty('display', 'block', 'important'); } catch (e) {}
-    });
-    requestAnimationFrame(() => {
-      try {
-        ph.style.setProperty('height', 'auto', 'important');
-        ph.style.setProperty('min-height', '0px', 'important');
-      } catch (e) {}
-    });
+  if (!wrap) return;
+  const ph = id ? wrap.querySelector && wrap.querySelector(`#${PLACEHOLDER_PREFIX}${id}`) : (wrap.querySelector && wrap.querySelector(`[id^="${PLACEHOLDER_PREFIX}"]`));
+  if (!ph) return;
+  ph.style.setProperty('height', 'auto', 'important');
+  ph.style.setProperty('min-height', '0px', 'important');
+  requestAnimationFrame(() => {
+  try {
+  ph.style.setProperty('height', 'auto', 'important');
+  ph.style.setProperty('min-height', '0px', 'important');
+  } catch (e) {}
+  });
   } catch (e) {}
   }
 
-function markFilled(wrap, id) {
+  function markFilled(wrap, id) {
   try {
   if (!wrap) return;
   if (wrap.__ezoicFillObs) { wrap.__ezoicFillObs.disconnect(); wrap.__ezoicFillObs = null; }
   wrap.setAttribute('data-ezoic-filled', '1');
-  try { forcePlaceholderAutoHeight(wrap, id); } catch (e) {}
+  // show wrapper only when filled (avoid blank gaps if consent/CMP blocks)
+  wrap.style.display = 'block';
+  forcePlaceholderAutoHeight(wrap, id);
   } catch (e) {}
   }
 
@@ -424,8 +426,7 @@ function markFilled(wrap, id) {
   window.ezstandalone.cmd.push(function() {
   if (typeof window.ezstandalone.showAds === 'function') {
   // Appel batch: showAds(id1, id2, id3...)
-  const okIds = idsArray.filter(id => { const el = document.getElementById(`${PLACEHOLDER_PREFIX}${id}`); return el && el.isConnected; });
-  if (okIds.length) { window.ezstandalone.showAds(...okIds); }
+  window.ezstandalone.showAds(...idsArray);
   // Tracker tous les IDs
   idsArray.forEach(id => {
   state.lastShowById.set(id, Date.now());
@@ -453,6 +454,8 @@ function markFilled(wrap, id) {
   window.ezstandalone = window.ezstandalone || {};
   if (typeof window.ezstandalone.showAds === 'function') {
 
+  const elNow = document.getElementById(phId);
+  if (!elNow || !elNow.isConnected) return false;
   state.lastShowById.set(id, Date.now());
   window.ezstandalone.showAds(id);
   sessionDefinedIds.add(id);
@@ -528,7 +531,7 @@ function markFilled(wrap, id) {
   return Array.from(new Set(out)).sort((a, b) => a - b);
   }
 
-  function injectBetween(kindClass, items, interval, showFirst, kindPool, usedSet) {
+  function injectBetween(kindClass, items, interval, showFirst, kindPool, usedSet, liveArr) {
   if (!items.length) return 0;
   const targets = computeTargets(items.length, interval, showFirst);
 
@@ -549,7 +552,7 @@ function markFilled(wrap, id) {
 
   if (findWrap(kindClass, afterPos)) continue;
 
-  const pick = pickId(kindPool, []);
+  const pick = pickId(kindPool, liveArr || []);
   const id = pick.id;
   if (!id) break;
 
@@ -574,6 +577,18 @@ function markFilled(wrap, id) {
   // Appel immédiat au lieu de 10ms delay
   callShowAdsWhenReady(id);
   }
+
+  if (liveArr) liveArr.push({ id, wrap });
+  if (wrap && (
+  (wrap.previousElementSibling && wrap.previousElementSibling.classList && wrap.previousElementSibling.classList.contains(WRAP_CLASS)) || (wrap.nextElementSibling && wrap.nextElementSibling.classList && wrap.nextElementSibling.classList.contains(WRAP_CLASS))
+  )) {
+  try { wrap.remove(); } catch (e) {}
+  if (!(pick.recycled && pick.recycled.wrap)) {
+  try { kindPool.unshift(id); } catch (e) {}
+  usedSet.delete(id);
+  }
+  continue;
+  }
   inserted += 1;
   }
   return inserted;
@@ -663,7 +678,7 @@ function markFilled(wrap, id) {
   Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3),
   normalizeBool(cfg.showFirstMessageAd),
   state.poolPosts,
-  state.usedPosts);
+  state.usedPosts, state.livePosts);
   }
   } else if (kind === 'categoryTopics') {
   if (normalizeBool(cfg.enableBetweenAds)) {
@@ -671,7 +686,7 @@ function markFilled(wrap, id) {
   Math.max(1, parseInt(cfg.intervalPosts, 10) || 6),
   normalizeBool(cfg.showFirstTopicAd),
   state.poolTopics,
-  state.usedTopics);
+  state.usedTopics, state.liveTopics);
   }
   } else if (kind === 'categories') {
   if (normalizeBool(cfg.enableCategoryAds)) {
@@ -679,7 +694,7 @@ function markFilled(wrap, id) {
   Math.max(1, parseInt(cfg.intervalCategories, 10) || 4),
   normalizeBool(cfg.showFirstCategoryAd),
   state.poolCategories,
-  state.usedCategories);
+  state.usedCategories, state.liveCategories);
   }
   }
 

package/public/style.css

@@ -1,17 +1,20 @@
-
-/* Wrapper: invisible tant que la pub n'est pas réellement insérée */
-.ezoic-ad{
+/* Ezoic Infinite Ads (NodeBB) - production safe */
+/* Hide wrappers until ad actually fills to avoid blank gaps (e.g., CMP/consent issues) */
+.ezoic-ad{ 
   display:none;
-  width:100%;
   height:auto !important;
+  min-height:0 !important;
   padding:0 !important;
   margin:0 !important;
+  width:100%;
 }
+
+/* Marked filled => show */
 .ezoic-ad[data-ezoic-filled="1"]{
   display:block;
 }
 
-/* Le placeholder ne doit jamais réserver une hauteur fixe */
+/* Placeholder must not reserve fixed height */
 .ezoic-ad > [id^="ezoic-pub-ad-placeholder-"]{
   height:auto !important;
   min-height:0 !important;
@@ -19,13 +22,19 @@
   padding:0 !important;
 }
 
-/* Évite le gap baseline sous iframes/ins */
+/* Prevent baseline gaps under iframes/ins */
 .ezoic-ad iframe,
 .ezoic-ad ins{
   display:block !important;
 }
 
-/* Supprimer les spacers vides */
+/* Remove empty spacer divs if any */
 .ezoic-ad > div:empty{
   display:none !important;
 }
+
+/* Defensive: wipe margins/paddings inside wrapper */
+.ezoic-ad *{
+  margin:0 !important;
+  padding:0 !important;
+}