nodebb-plugin-ezoic-infinite 1.0.15 → 1.0.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "1.0.15",
+  "version": "1.0.16",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -186,16 +186,32 @@
   }
 
   function recycle(fifo, usedSet, selector) {
+    // Recycle only ads that are safely outside the viewport (to avoid ads “disappearing” while reading)
+    const margin = 1200; // px
+    const vpTop = -margin;
+
     fifo.sort((a, b) => a.after - b.after);
-    while (fifo.length) {
-      const old = fifo.shift();
+
+    // Prefer recycling ads far ABOVE the current viewport (user has already passed them)
+    for (let i = 0; i < fifo.length; i++) {
+      const old = fifo[i];
       const el = document.querySelector(selector(old));
-      if (!el) continue;
-      el.remove();
-      usedSet.delete(old.id);
-      destroyPlaceholder(old.id);
-      return old.id;
+      if (!el) {
+        fifo.splice(i, 1);
+        i--;
+        continue;
+      }
+      const r = el.getBoundingClientRect();
+      if (r.bottom < vpTop) {
+        fifo.splice(i, 1);
+        el.remove();
+        usedSet.delete(old.id);
+        destroyPlaceholder(old.id);
+        return old.id;
+      }
     }
+
+    // If nothing is safely above, do NOT recycle.
     return null;
   }