nodebb-plugin-ezoic-infinite 0.6.5 → 0.6.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "0.6.5",
+  "version": "0.6.6",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -14,7 +14,7 @@ let rerunRequested = false;
 let pageKey = null;
 let injectedSlots = new Set();       // slot numbers already injected on this page
 let usedIds = new Set();             // IDs currently present in DOM
-let adsFIFO = [];                    // [{type, slot, id}] oldest first
+let adsFIFO = [];                    // [{slot, id}] oldest first
 
 function resetPageState() {
   injectedSlots = new Set();
@@ -73,14 +73,21 @@ function getCategoryTopicItems() {
   return $('li[component="category/topic"]').not('.ezoic-ad-topic');
 }
 
-function tagName($el) {
-  return ($el && $el.length ? (($el.prop('tagName') || '').toUpperCase()) : '');
+// IMPORTANT: Use the SAME tag type as the surrounding list container.
+// If posts/topics are in a <ul>/<ol>, the wrapper MUST be a <li> or the browser may move it outside the list (often to the top).
+function wrapperTagFor($target) {
+  if (!$target || !$target.length) return 'div';
+  const parentTag = ($target.parent().prop('tagName') || '').toUpperCase();
+  if (parentTag === 'UL' || parentTag === 'OL') return 'li';
+  const selfTag = ($target.prop('tagName') || '').toUpperCase();
+  if (selfTag === 'LI') return 'li';
+  return 'div';
 }
 
 function makeWrapperLike($target, classes, innerHtml, attrs) {
-  const t = tagName($target);
+  const tag = wrapperTagFor($target);
   const attrStr = attrs ? ' ' + attrs : '';
-  if (t === 'LI') {
+  if (tag === 'li') {
     return '<li class="' + classes + ' list-unstyled"' + attrStr + '>' + innerHtml + '</li>';
   }
   return '<div class="' + classes + '"' + attrStr + '>' + innerHtml + '</div>';
@@ -153,7 +160,6 @@ function injectBetweenIncremental($items, pool, interval, wrapperClass) {
 
     let id = pickNextId(pool);
     if (!id) {
-      // Pool full: evict oldest, then reuse freed ID
       if (!evictOldestOne()) break;
       id = pickNextId(pool);
       if (!id) break;
@@ -171,7 +177,7 @@ function injectBetweenIncremental($items, pool, interval, wrapperClass) {
 
     injectedSlots.add(slot);
     usedIds.add(id);
-    adsFIFO.push({ type: 'between', slot: slot, id: id });
+    adsFIFO.push({ slot: slot, id: id });
     newIds.push(id);
   }
 
@@ -211,7 +217,7 @@ function injectMessageIncremental($posts, pool, interval) {
 
     injectedSlots.add(slot);
     usedIds.add(id);
-    adsFIFO.push({ type: 'message', slot: slot, id: id });
+    adsFIFO.push({ slot: slot, id: id });
     newIds.push(id);
   }