nodebb-plugin-ezoic-infinite 0.5.8 → 0.5.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "0.5.8",
+  "version": "0.5.9",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -28,7 +28,16 @@ function parsePool(raw) {
   ));
 }
 
+function isTopicTemplate() {
+  return !!(ajaxify && ajaxify.data && (ajaxify.data.template === 'topic' || ajaxify.data.template === 'topicEvents'));
+}
+
+function isCategoryTemplate() {
+  return !!(ajaxify && ajaxify.data && ajaxify.data.template === 'category');
+}
+
 function getTopicPosts() {
+  if (!isTopicTemplate()) return $();
   const $primary = $('[component="post"][data-pid]');
   if ($primary.length) return $primary.not('.ezoic-ad-post');
 
@@ -44,8 +53,7 @@ function getTopicPosts() {
 }
 
 function getCategoryTopicItems() {
-  // Only on category topic list pages
-  if (!ajaxify || !ajaxify.data || ajaxify.data.template !== 'category') return $();
+  if (!isCategoryTemplate()) return $();
   return $('li[component="category/topic"]').not('.ezoic-ad-topic');
 }
 
@@ -191,29 +199,24 @@ async function refreshAds() {
     const combinedUnique = uniqueConcat(betweenPool, messagePool);
     const activeIds = [];
 
-    if (!$posts.length && $topicItems.length) {
+    // Category topic list page: use BETWEEN only
+    if ($topicItems.length) {
       if (cfg.enableBetweenAds && betweenPool.length) {
         activeIds.push(...insertBetweenGeneric($topicItems, combinedUnique.slice(0, betweenPool.length), betweenInterval, 'ezoic-ad-topic'));
       }
+      ezoicCall(activeIds);
+      return;
     }
 
+    // Topic page: ONLY message ads (as requested)
     if ($posts.length) {
-      let cursor = 0;
-
-      if (cfg.enableBetweenAds && betweenPool.length) {
-        const idsForBetween = combinedUnique.slice(cursor, cursor + betweenPool.length);
-        cursor += idsForBetween.length;
-        activeIds.push(...insertBetweenGeneric($posts, idsForBetween, betweenInterval, 'ezoic-ad-between'));
-      }
-
       if (cfg.enableMessageAds && messagePool.length) {
-        const idsForMessage = combinedUnique.slice(cursor, cursor + messagePool.length);
-        cursor += idsForMessage.length;
+        // Use messagePool slice from the combined unique set, but keep it stable
+        const idsForMessage = combinedUnique.slice(0, messagePool.length);
         activeIds.push(...insertAdMessagesBetweenReplies($posts, idsForMessage, messageInterval));
       }
+      ezoicCall(activeIds);
     }
-
-    ezoicCall(activeIds);
   } finally {
     inFlight = false;
     if (rerunRequested) {