nodebb-plugin-ezoic-infinite 0.5.7 → 0.5.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "0.5.7",
+  "version": "0.5.8",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -7,6 +7,10 @@ let cachedConfig;
 let lastFetch = 0;
 let debounceTimer;
 
+let lastSignature = null;
+let inFlight = false;
+let rerunRequested = false;
+
 async function fetchConfig() {
   if (cachedConfig && Date.now() - lastFetch < 10000) return cachedConfig;
   const res = await fetch('/api/plugins/ezoic-infinite/config', { credentials: 'same-origin' });
@@ -40,6 +44,8 @@ function getTopicPosts() {
 }
 
 function getCategoryTopicItems() {
+  // Only on category topic list pages
+  if (!ajaxify || !ajaxify.data || ajaxify.data.template !== 'category') return $();
   return $('li[component="category/topic"]').not('.ezoic-ad-topic');
 }
 
@@ -47,14 +53,11 @@ function tagName($el) {
   return ($el && $el.length ? (($el.prop('tagName') || '').toUpperCase()) : '');
 }
 
-function removePlaceholdersByPool(pool) {
-  pool.forEach(id => $('[id="ezoic-pub-ad-placeholder-' + id + '"]').remove());
-}
-
-function removeAdWrappers() {
+function removeExistingEzoicNodes() {
   $('.ezoic-ad-post').remove();
   $('.ezoic-ad-between').remove();
   $('.ezoic-ad-topic').remove();
+  $('[id^="ezoic-pub-ad-placeholder-"]').remove();
 }
 
 function computeWindowSlots(totalItems, interval, poolSize) {
@@ -130,14 +133,11 @@ function uniqueConcat(a, b) {
 function ezoicCall(ids) {
   if (!ids || !ids.length) return;
 
-  // Queue calls until Ezoic is ready (recommended pattern)
   window.ezstandalone = window.ezstandalone || {};
   window.ezstandalone.cmd = window.ezstandalone.cmd || [];
 
   window.ezstandalone.cmd.push(function () {
     try {
-      // IMPORTANT: destroy only the placeholders we are about to reuse,
-      // NOT all placeholders. Destroying too early/all can make ads disappear.
       if (typeof window.ezstandalone.destroyPlaceholders === 'function') {
         window.ezstandalone.destroyPlaceholders.apply(window.ezstandalone, ids);
       }
@@ -151,62 +151,83 @@ function ezoicCall(ids) {
   });
 }
 
+function computeSignature($posts, $topicItems) {
+  if ($posts.length) {
+    const lastPid = $posts.last().attr('data-pid') || '';
+    return 'topic:' + $posts.length + ':' + lastPid;
+  }
+  if ($topicItems.length) {
+    const lastTid = $topicItems.last().attr('data-tid') || '';
+    return 'category:' + $topicItems.length + ':' + lastTid;
+  }
+  return 'none';
+}
+
 async function refreshAds() {
-  let cfg;
-  try { cfg = await fetchConfig(); } catch (e) { return; }
-  if (!cfg || cfg.excluded) return;
+  if (inFlight) { rerunRequested = true; return; }
+  inFlight = true;
 
-  const betweenPool = parsePool(cfg.placeholderIds);
-  const betweenInterval = Math.max(1, parseInt(cfg.intervalPosts, 10) || 6);
+  try {
+    const cfg = await fetchConfig();
+    if (!cfg || cfg.excluded) return;
 
-  const messagePool = parsePool(cfg.messagePlaceholderIds);
-  const messageInterval = Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3);
+    const betweenPool = parsePool(cfg.placeholderIds);
+    const betweenInterval = Math.max(1, parseInt(cfg.intervalPosts, 10) || 6);
 
-  const $posts = getTopicPosts();
-  const $topicItems = getCategoryTopicItems();
+    const messagePool = parsePool(cfg.messagePlaceholderIds);
+    const messageInterval = Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3);
 
-  if (!$posts.length && !$topicItems.length) return;
+    const $posts = getTopicPosts();
+    const $topicItems = getCategoryTopicItems();
 
-  removeAdWrappers();
-  removePlaceholdersByPool(uniqueConcat(betweenPool, messagePool));
+    if (!$posts.length && !$topicItems.length) return;
 
-  const combinedUnique = uniqueConcat(betweenPool, messagePool);
+    const signature = computeSignature($posts, $topicItems);
+    if (signature === lastSignature) return;
+    lastSignature = signature;
 
-  const activeIds = [];
+    removeExistingEzoicNodes();
 
-  // Category topic list page
-  if (!$posts.length && $topicItems.length) {
-    if (cfg.enableBetweenAds && betweenPool.length) {
-      activeIds.push(...insertBetweenGeneric($topicItems, combinedUnique.slice(0, betweenPool.length), betweenInterval, 'ezoic-ad-topic'));
+    const combinedUnique = uniqueConcat(betweenPool, messagePool);
+    const activeIds = [];
+
+    if (!$posts.length && $topicItems.length) {
+      if (cfg.enableBetweenAds && betweenPool.length) {
+        activeIds.push(...insertBetweenGeneric($topicItems, combinedUnique.slice(0, betweenPool.length), betweenInterval, 'ezoic-ad-topic'));
+      }
     }
-  }
 
-  // Topic page
-  if ($posts.length) {
-    let cursor = 0;
+    if ($posts.length) {
+      let cursor = 0;
 
-    if (cfg.enableBetweenAds && betweenPool.length) {
-      const idsForBetween = combinedUnique.slice(cursor, cursor + betweenPool.length);
-      cursor += idsForBetween.length;
-      activeIds.push(...insertBetweenGeneric($posts, idsForBetween, betweenInterval, 'ezoic-ad-between'));
+      if (cfg.enableBetweenAds && betweenPool.length) {
+        const idsForBetween = combinedUnique.slice(cursor, cursor + betweenPool.length);
+        cursor += idsForBetween.length;
+        activeIds.push(...insertBetweenGeneric($posts, idsForBetween, betweenInterval, 'ezoic-ad-between'));
+      }
+
+      if (cfg.enableMessageAds && messagePool.length) {
+        const idsForMessage = combinedUnique.slice(cursor, cursor + messagePool.length);
+        cursor += idsForMessage.length;
+        activeIds.push(...insertAdMessagesBetweenReplies($posts, idsForMessage, messageInterval));
+      }
     }
 
-    if (cfg.enableMessageAds && messagePool.length) {
-      const idsForMessage = combinedUnique.slice(cursor, cursor + messagePool.length);
-      cursor += idsForMessage.length;
-      activeIds.push(...insertAdMessagesBetweenReplies($posts, idsForMessage, messageInterval));
+    ezoicCall(activeIds);
+  } finally {
+    inFlight = false;
+    if (rerunRequested) {
+      rerunRequested = false;
+      setTimeout(refreshAds, 50);
     }
   }
-
-  // Ask Ezoic to (re)fill ONLY the placeholders we inserted.
-  ezoicCall(activeIds);
 }
 
 function debounceRefresh() {
   clearTimeout(debounceTimer);
-  debounceTimer = setTimeout(refreshAds, 180);
+  debounceTimer = setTimeout(refreshAds, 220);
 }
 
 $(document).ready(debounceRefresh);
 $(window).on('action:ajaxify.end action:posts.loaded action:topic.loaded', debounceRefresh);
-setTimeout(debounceRefresh, 1800);
+setTimeout(debounceRefresh, 2200);