nodebb-plugin-ezoic-infinite 0.5.5 → 0.5.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "0.5.5",
+  "version": "0.5.7",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/client.js

@@ -39,11 +39,14 @@ function getTopicPosts() {
   return $('.posts .post').not('.ezoic-ad-post');
 }
 
+function getCategoryTopicItems() {
+  return $('li[component="category/topic"]').not('.ezoic-ad-topic');
+}
+
 function tagName($el) {
   return ($el && $el.length ? (($el.prop('tagName') || '').toUpperCase()) : '');
 }
 
-// Remove *all* nodes with a given id (duplicates are possible if misconfigured)
 function removePlaceholdersByPool(pool) {
   pool.forEach(id => $('[id="ezoic-pub-ad-placeholder-' + id + '"]').remove());
 }
@@ -51,6 +54,7 @@ function removePlaceholdersByPool(pool) {
 function removeAdWrappers() {
   $('.ezoic-ad-post').remove();
   $('.ezoic-ad-between').remove();
+  $('.ezoic-ad-topic').remove();
 }
 
 function computeWindowSlots(totalItems, interval, poolSize) {
@@ -70,8 +74,8 @@ function makeWrapperLike($target, classes, innerHtml) {
   return '<div class="' + classes + '" data-ezoic-ad="1">' + innerHtml + '</div>';
 }
 
-function insertBetweenPosts($posts, ids, interval) {
-  const total = $posts.length;
+function insertBetweenGeneric($items, ids, interval, wrapperClass) {
+  const total = $items.length;
   const slotsToRender = computeWindowSlots(total, interval, ids.length);
   if (!slotsToRender.length) return [];
 
@@ -80,10 +84,10 @@ function insertBetweenPosts($posts, ids, interval) {
     const slotNumber = slotsToRender[i];
     const id = ids[i];
     const index = slotNumber * interval - 1;
-    const $target = $posts.eq(index);
+    const $target = $items.eq(index);
     if (!$target.length) continue;
 
-    const html = makeWrapperLike($target, 'ezoic-ad-between', '<div id="ezoic-pub-ad-placeholder-' + id + '"></div>');
+    const html = makeWrapperLike($target, wrapperClass, '<div id="ezoic-pub-ad-placeholder-' + id + '"></div>');
     $target.after(html);
     activeIds.push(id);
   }
@@ -123,6 +127,30 @@ function uniqueConcat(a, b) {
   return out;
 }
 
+function ezoicCall(ids) {
+  if (!ids || !ids.length) return;
+
+  // Queue calls until Ezoic is ready (recommended pattern)
+  window.ezstandalone = window.ezstandalone || {};
+  window.ezstandalone.cmd = window.ezstandalone.cmd || [];
+
+  window.ezstandalone.cmd.push(function () {
+    try {
+      // IMPORTANT: destroy only the placeholders we are about to reuse,
+      // NOT all placeholders. Destroying too early/all can make ads disappear.
+      if (typeof window.ezstandalone.destroyPlaceholders === 'function') {
+        window.ezstandalone.destroyPlaceholders.apply(window.ezstandalone, ids);
+      }
+    } catch (e) {}
+
+    try {
+      if (typeof window.ezstandalone.showAds === 'function') {
+        window.ezstandalone.showAds.apply(window.ezstandalone, ids);
+      }
+    } catch (e) {}
+  });
+}
+
 async function refreshAds() {
   let cfg;
   try { cfg = await fetchConfig(); } catch (e) { return; }
@@ -135,50 +163,50 @@ async function refreshAds() {
   const messageInterval = Math.max(1, parseInt(cfg.messageIntervalPosts, 10) || 3);
 
   const $posts = getTopicPosts();
-  if (!$posts.length) return;
+  const $topicItems = getCategoryTopicItems();
+
+  if (!$posts.length && !$topicItems.length) return;
 
-  // Clean first (remove wrappers + any placeholders, even duplicates)
   removeAdWrappers();
   removePlaceholdersByPool(uniqueConcat(betweenPool, messagePool));
 
-  // IMPORTANT:
-  // IDs must be UNIQUE on the page. If admin reuses the same IDs for both pools,
-  // we allocate unique IDs across "between posts" and "message ads" to avoid duplicates.
   const combinedUnique = uniqueConcat(betweenPool, messagePool);
 
   const activeIds = [];
-  let cursor = 0;
 
-  if (cfg.enableBetweenAds && betweenPool.length) {
-    const idsForBetween = combinedUnique.slice(cursor, cursor + betweenPool.length);
-    cursor += idsForBetween.length;
-    activeIds.push(...insertBetweenPosts($posts, idsForBetween, betweenInterval));
+  // Category topic list page
+  if (!$posts.length && $topicItems.length) {
+    if (cfg.enableBetweenAds && betweenPool.length) {
+      activeIds.push(...insertBetweenGeneric($topicItems, combinedUnique.slice(0, betweenPool.length), betweenInterval, 'ezoic-ad-topic'));
+    }
   }
 
-  if (cfg.enableMessageAds && messagePool.length) {
-    const idsForMessage = combinedUnique.slice(cursor, cursor + messagePool.length);
-    cursor += idsForMessage.length;
-    activeIds.push(...insertAdMessagesBetweenReplies($posts, idsForMessage, messageInterval));
-  }
+  // Topic page
+  if ($posts.length) {
+    let cursor = 0;
+
+    if (cfg.enableBetweenAds && betweenPool.length) {
+      const idsForBetween = combinedUnique.slice(cursor, cursor + betweenPool.length);
+      cursor += idsForBetween.length;
+      activeIds.push(...insertBetweenGeneric($posts, idsForBetween, betweenInterval, 'ezoic-ad-between'));
+    }
 
-  // Ezoic render
-  if (activeIds.length && window.ezstandalone && typeof window.ezstandalone.destroyPlaceholders === 'function') {
-    try { window.ezstandalone.destroyPlaceholders(); } catch (e) {}
+    if (cfg.enableMessageAds && messagePool.length) {
+      const idsForMessage = combinedUnique.slice(cursor, cursor + messagePool.length);
+      cursor += idsForMessage.length;
+      activeIds.push(...insertAdMessagesBetweenReplies($posts, idsForMessage, messageInterval));
+    }
   }
-  activeIds.forEach(id => {
-    try {
-      if (window.ezstandalone && typeof window.ezstandalone.showAds === 'function') {
-        window.ezstandalone.showAds(id);
-      }
-    } catch (e) {}
-  });
+
+  // Ask Ezoic to (re)fill ONLY the placeholders we inserted.
+  ezoicCall(activeIds);
 }
 
 function debounceRefresh() {
   clearTimeout(debounceTimer);
-  debounceTimer = setTimeout(refreshAds, 150);
+  debounceTimer = setTimeout(refreshAds, 180);
 }
 
 $(document).ready(debounceRefresh);
 $(window).on('action:ajaxify.end action:posts.loaded action:topic.loaded', debounceRefresh);
-setTimeout(debounceRefresh, 1500);
+setTimeout(debounceRefresh, 1800);