nodebb-plugin-ezoic-infinite 0.4.3 → 0.4.5

package/library.js

@@ -23,9 +23,11 @@ function parseBool(v, def = false) {
 async function getAllGroups() {
   const names = await db.getSortedSetRange('groups:createtime', 0, -1);
   const filtered = names.filter(name => !groups.isPrivilegeGroup(name));
-  return groups.getGroupsData(filtered);
+  const data = await groups.getGroupsData(filtered);
+  // Sort alphabetically for ACP usability
+  data.sort((a, b) => String(a.name).localeCompare(String(b.name), 'fr', { sensitivity: 'base' }));
+  return data;
 }
-
 async function getSettings() {
   const s = await meta.settings.get(SETTINGS_KEY);
   return {
@@ -60,7 +62,7 @@ plugin.addAdminNavigation = async (header) => {
 };
 
 plugin.init = async ({ router, middleware }) => {
-  router.get('/admin/plugins/ezoic-infinite', middleware.admin.buildHeader, async (req, res) => {
+  async function render(req, res) {
     const settings = await getSettings();
     const allGroups = await getAllGroups();
 
@@ -71,21 +73,10 @@ plugin.init = async ({ router, middleware }) => {
       enableMessageAds_checked: settings.enableMessageAds ? 'checked' : '',
       allGroups,
     });
-  });
+  }
 
-  // Needed for ajaxify navigation in ACP (first click uses /api/admin/*)
-  router.get('/api/admin/plugins/ezoic-infinite', middleware.admin.buildHeader, async (req, res) => {
-    const settings = await getSettings();
-    const allGroups = await getAllGroups();
-
-    res.json({
-      title: 'Ezoic Infinite Ads',
-      ...settings,
-      enableBetweenAds_checked: settings.enableBetweenAds ? 'checked' : '',
-      enableMessageAds_checked: settings.enableMessageAds ? 'checked' : '',
-      allGroups,
-    });
-  });
+  router.get('/admin/plugins/ezoic-infinite', middleware.admin.buildHeader, render);
+  router.get('/api/admin/plugins/ezoic-infinite', render);
 
   router.get('/api/plugins/ezoic-infinite/config', middleware.buildHeader, async (req, res) => {
     const settings = await getSettings();
@@ -93,11 +84,9 @@ plugin.init = async ({ router, middleware }) => {
 
     res.json({
       excluded,
-
       enableBetweenAds: settings.enableBetweenAds,
       placeholderIds: settings.placeholderIds,
       intervalPosts: settings.intervalPosts,
-
       enableMessageAds: settings.enableMessageAds,
       messagePlaceholderIds: settings.messagePlaceholderIds,
       messageIntervalPosts: settings.messageIntervalPosts,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-ezoic-infinite",
-  "version": "0.4.3",
+  "version": "0.4.5",
   "description": "Ezoic ads with infinite scroll using a pool of placeholder IDs",
   "main": "library.js",
   "license": "MIT",

package/public/admin.js

@@ -1,31 +1,29 @@
-/* globals app, ajaxify */
+/* globals ajaxify */
 'use strict';
 
 (function () {
-  function isOurPage(data) {
-    const url = data?.url || ajaxify?.data?.url || window.location.pathname || '';
-    return url.includes('admin/plugins/ezoic-infinite') || url.includes('/plugins/ezoic-infinite');
-  }
-
   function init() {
     const $form = $('.ezoic-infinite-settings');
     if (!$form.length) return;
 
-    require(['settings'], function (Settings) {
+    require(['settings', 'alerts'], function (Settings, alerts) {
       Settings.load('ezoic-infinite', $form);
 
       $('#save').off('click.ezoicInfinite').on('click.ezoicInfinite', function (e) {
         e.preventDefault();
+
         Settings.save('ezoic-infinite', $form, function () {
-          // Toast vert par défaut
-          app.alertSuccess('Enregistré');
+          // Toast vert (NodeBB core)
+          if (alerts && typeof alerts.success === 'function') {
+            alerts.success('Enregistré');
+          } else if (window.app && typeof window.app.alertSuccess === 'function') {
+            window.app.alertSuccess('Enregistré');
+          }
         });
       });
     });
   }
 
   $(document).ready(init);
-  $(window).on('action:ajaxify.end', function (ev, data) {
-    if (isOurPage(data)) init();
-  });
+  $(window).on('action:ajaxify.end', init);
 })();

package/README.md

@@ -1,18 +0,0 @@
-# nodebb-plugin-ezoic-infinite
-
-Plugin NodeBB 4.x pour intégrer Ezoic avec infinite scroll.
-
-## Correctifs inclus
-- Route **/api/admin/plugins/ezoic-infinite** ajoutée (indispensable pour le 1er clic dans l'ACP via ajaxify)
-- Toast vert (app.alertSuccess) lors de l'enregistrement
-- package.json non-private (publication npm possible)
-
-## Installation (local)
-```bash
-cd /path/to/nodebb/node_modules
-unzip nodebb-plugin-ezoic-infinite.zip -d nodebb-plugin-ezoic-infinite
-cd /path/to/nodebb
-npm i ./node_modules/nodebb-plugin-ezoic-infinite
-./nodebb build
-./nodebb restart
-```