nodebb-plugin-discord-onekite 1.1.21 → 1.1.23

package/README.md

@@ -1,10 +1,7 @@
-# nodebb-plugin-discord-onekite v1.1.4.12
+# nodebb-plugin-discord-onekite v1.1.4.13
 
-ACP:
-- Uses official `settings.sync()` + `settings.persist()`
-- Toast title: "Succès" / message: "Paramètres enregistrés"
-- Adds a top button "Enregistrer les paramètres" (also keeps the standard bottom-right save button)
-- Categories multi-select is persisted as CSV via hidden `data-field="cids"` input for reliability.
-
-Discord:
-- Same as v1.1.4.10 line (embed only, message in embed description).
+Fixes ACP not applying JS / not persisting:
+- Uses `acpScripts` + modules key `admin/plugins/discord-onekite.js` to ensure admin script loads.
+- Removes bottom-right save button partial; uses only the top "Enregistrer les paramètres" button.
+- Persists categories via hidden CSV field `data-field="cids"`.
+- Toast uses title "Succès" and message "Paramètres enregistrés".

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.1.21",
+  "version": "1.1.23",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -22,7 +22,10 @@
     }
   ],
   "templates": "templates",
+  "acpScripts": [
+    "static/lib/admin.js"
+  ],
   "modules": {
-    "../admin/plugins/discord-onekite.js": "static/lib/admin.js"
+    "admin/plugins/discord-onekite.js": "static/lib/admin.js"
   }
 }

package/static/lib/admin.js

@@ -4,32 +4,28 @@
 define('admin/plugins/discord-onekite', ['settings'], function (settings) {
   const ACP = {};
 
-  function getSelectedCids() {
-    return $('#cidsMulti option:selected').map(function () { return String($(this).val()); }).get();
+  function parseCsv(v) {
+    if (!v) return [];
+    return String(v).split(',').map(s => s.trim()).filter(Boolean);
+  }
+  function toCsv(arr) {
+    return (arr || []).map(String).filter(Boolean).join(',');
   }
-
   function setSelectedCids(cids) {
     const set = new Set((cids || []).map(String));
     $('#cidsMulti option').each(function () {
       $(this).prop('selected', set.has(String($(this).val())));
     });
   }
-
-  function parseCsv(v) {
-    if (!v) return [];
-    if (Array.isArray(v)) return v.map(String).filter(Boolean);
-    return String(v).split(',').map(s => s.trim()).filter(Boolean);
-  }
-
-  function toCsv(arr) {
-    return (arr || []).map(String).filter(Boolean).join(',');
+  function getSelectedCids() {
+    return $('#cidsMulti option:selected').map(function () { return String($(this).val()); }).get();
   }
 
   function toastSuccess() {
     if (window.app && typeof app.alert === 'function') {
       app.alert({ type: 'success', title: 'Succès', message: 'Paramètres enregistrés' });
     } else if (window.app && typeof app.alertSuccess === 'function') {
-      app.alertSuccess('Paramètres enregistrés');
+      app.alertSuccess('Succès: Paramètres enregistrés');
     }
   }
 
@@ -37,32 +33,16 @@ define('admin/plugins/discord-onekite', ['settings'], function (settings) {
     const $form = $('.discord-onekite-settings');
     if (!$form.length) return;
 
-    // Sync settings into form fields (data-field)
     settings.sync('discord-onekite', $form, function () {
-      // After sync, update UI multiselect from persisted CSV value
-      const csv = $('#cids').val();
-      setSelectedCids(parseCsv(csv));
+      setSelectedCids(parseCsv($('#cids').val()));
     });
 
-    function persist() {
-      // Before persist, copy UI multiselect to hidden CSV field
+    $('#onekite-save').off('click.discordOnekite').on('click.discordOnekite', function (e) {
+      e.preventDefault();
       $('#cids').val(toCsv(getSelectedCids()));
-
       settings.persist('discord-onekite', $form, function () {
         toastSuccess();
       });
-    }
-
-    // bottom-right save button has id #save (from partial)
-    $('#save').off('click.discordOnekite').on('click.discordOnekite', function (e) {
-      e.preventDefault();
-      persist();
-    });
-
-    // top button
-    $('#save-top').off('click.discordOnekite').on('click.discordOnekite', function (e) {
-      e.preventDefault();
-      persist();
     });
   };
 

package/templates/admin/plugins/discord-onekite.tpl

@@ -4,17 +4,17 @@
       <h4 class="mb-1">Discord Onekite</h4>
       <p class="text-muted mb-0">Notifications Discord via webhook.</p>
     </div>
-    <button id="save-top" type="button" class="btn btn-primary">Enregistrer les paramètres</button>
+    <button id="onekite-save" type="button" class="btn btn-primary">Enregistrer les paramètres</button>
   </div>
 
   <form role="form" class="discord-onekite-settings">
     <div class="mb-3">
       <label class="form-label" for="webhookUrl">Discord Webhook URL</label>
-      <input type="text" class="form-control" id="webhookUrl" name="webhookUrl" data-field="webhookUrl" value="{settings.webhookUrl}" placeholder="https://discord.com/api/webhooks/..." />
+      <input type="text" class="form-control" id="webhookUrl" data-key="webhookUrl" value="{settings.webhookUrl}" placeholder="https://discord.com/api/webhooks/..." />
     </div>
 
     <div class="form-check mb-3">
-      <input class="form-check-input" type="checkbox" id="notifyReplies" name="notifyReplies" data-field="notifyReplies" <!-- IF settings.notifyReplies -->checked<!-- ENDIF settings.notifyReplies -->>
+      <input class="form-check-input" type="checkbox" id="notifyReplies" data-key="notifyReplies" <!-- IF settings.notifyReplies -->checked<!-- ENDIF settings.notifyReplies -->>
       <label class="form-check-label" for="notifyReplies">
         Notifier aussi les réponses (si décoché : uniquement les nouveaux sujets)
       </label>
@@ -23,22 +23,17 @@
     <div class="mb-3">
       <label class="form-label" for="cidsMulti">Catégories à notifier</label>
 
-      <!-- UI multi-select (not directly persisted) -->
       <select class="form-select" id="cidsMulti" multiple size="12">
         <!-- BEGIN categories -->
         <option value="{categories.cid}" <!-- IF categories.selected -->selected<!-- ENDIF categories.selected -->>{categories.name}</option>
         <!-- END categories -->
       </select>
 
-      <!-- Persisted field: comma-separated list of cids -->
-      <input type="hidden" id="cids" name="cids" data-field="cids" value="{settings.cids}" />
+      <input type="hidden" id="cids" data-key="cids" value="{settings.cids}" />
 
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
     </div>
-
-    <!-- Bottom-right official save button -->
-    <!-- IMPORT admin/partials/save_button.tpl -->
   </form>
 </div>