nodebb-plugin-discord-onekite 1.1.19 → 1.1.21

package/README.md

@@ -1,8 +1,10 @@
-# nodebb-plugin-discord-onekite v1.1.4.11
+# nodebb-plugin-discord-onekite v1.1.4.12
 
-Fixes ACP saving:
-- Inputs now use `data-field` attributes (required by NodeBB `settings` module), so values persist.
+ACP:
+- Uses official `settings.sync()` + `settings.persist()`
+- Toast title: "Succès" / message: "Paramètres enregistrés"
+- Adds a top button "Enregistrer les paramètres" (also keeps the standard bottom-right save button)
+- Categories multi-select is persisted as CSV via hidden `data-field="cids"` input for reliability.
 
-Toast:
-- Title: "Succès"
-- Message: "Paramètres enregistrés"
+Discord:
+- Same as v1.1.4.10 line (embed only, message in embed description).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.1.19",
+  "version": "1.1.21",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/static/lib/admin.js

@@ -4,19 +4,65 @@
 define('admin/plugins/discord-onekite', ['settings'], function (settings) {
   const ACP = {};
 
+  function getSelectedCids() {
+    return $('#cidsMulti option:selected').map(function () { return String($(this).val()); }).get();
+  }
+
+  function setSelectedCids(cids) {
+    const set = new Set((cids || []).map(String));
+    $('#cidsMulti option').each(function () {
+      $(this).prop('selected', set.has(String($(this).val())));
+    });
+  }
+
+  function parseCsv(v) {
+    if (!v) return [];
+    if (Array.isArray(v)) return v.map(String).filter(Boolean);
+    return String(v).split(',').map(s => s.trim()).filter(Boolean);
+  }
+
+  function toCsv(arr) {
+    return (arr || []).map(String).filter(Boolean).join(',');
+  }
+
+  function toastSuccess() {
+    if (window.app && typeof app.alert === 'function') {
+      app.alert({ type: 'success', title: 'Succès', message: 'Paramètres enregistrés' });
+    } else if (window.app && typeof app.alertSuccess === 'function') {
+      app.alertSuccess('Paramètres enregistrés');
+    }
+  }
+
   ACP.init = function () {
     const $form = $('.discord-onekite-settings');
     if (!$form.length) return;
 
-    settings.sync('discord-onekite', $form);
+    // Sync settings into form fields (data-field)
+    settings.sync('discord-onekite', $form, function () {
+      // After sync, update UI multiselect from persisted CSV value
+      const csv = $('#cids').val();
+      setSelectedCids(parseCsv(csv));
+    });
+
+    function persist() {
+      // Before persist, copy UI multiselect to hidden CSV field
+      $('#cids').val(toCsv(getSelectedCids()));
 
-    $('#save').off('click.discordOnekite').on('click.discordOnekite', function (e) {
-      e.preventDefault();
       settings.persist('discord-onekite', $form, function () {
-        if (window.app && typeof app.alertSuccess === 'function') {
-          if (typeof app.alert === 'function') { app.alert({ type: 'success', title: 'Succès', message: 'Paramètres enregistrés' }); } else { app.alertSuccess('Paramètres enregistrés'); }
-        }
+        toastSuccess();
       });
+    }
+
+    // bottom-right save button has id #save (from partial)
+    $('#save').off('click.discordOnekite').on('click.discordOnekite', function (e) {
+      e.preventDefault();
+      persist();
+    });
+
+    // top button
+    $('#save-top').off('click.discordOnekite').on('click.discordOnekite', function (e) {
+      e.preventDefault();
+      persist();
     });
   };
 

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,32 +1,44 @@
 <div class="acp-page-container">
-  <h4>Discord Onekite</h4>
-  <p class="text-muted">Notifications Discord via webhook.</p>
+  <div class="d-flex justify-content-between align-items-start mb-3">
+    <div>
+      <h4 class="mb-1">Discord Onekite</h4>
+      <p class="text-muted mb-0">Notifications Discord via webhook.</p>
+    </div>
+    <button id="save-top" type="button" class="btn btn-primary">Enregistrer les paramètres</button>
+  </div>
 
   <form role="form" class="discord-onekite-settings">
     <div class="mb-3">
       <label class="form-label" for="webhookUrl">Discord Webhook URL</label>
-      <input type="text" class="form-control" id="webhookUrl" data-field="webhookUrl" value="{settings.webhookUrl}" placeholder="https://discord.com/api/webhooks/..." />
+      <input type="text" class="form-control" id="webhookUrl" name="webhookUrl" data-field="webhookUrl" value="{settings.webhookUrl}" placeholder="https://discord.com/api/webhooks/..." />
     </div>
 
     <div class="form-check mb-3">
-      <input class="form-check-input" type="checkbox" id="notifyReplies" data-field="notifyReplies" <!-- IF settings.notifyReplies -->checked<!-- ENDIF settings.notifyReplies -->>
+      <input class="form-check-input" type="checkbox" id="notifyReplies" name="notifyReplies" data-field="notifyReplies" <!-- IF settings.notifyReplies -->checked<!-- ENDIF settings.notifyReplies -->>
       <label class="form-check-label" for="notifyReplies">
         Notifier aussi les réponses (si décoché : uniquement les nouveaux sujets)
       </label>
     </div>
 
     <div class="mb-3">
-      <label class="form-label" for="cids">Catégories à notifier</label>
-      <select class="form-select" id="cids" data-field="cids" multiple size="12">
+      <label class="form-label" for="cidsMulti">Catégories à notifier</label>
+
+      <!-- UI multi-select (not directly persisted) -->
+      <select class="form-select" id="cidsMulti" multiple size="12">
         <!-- BEGIN categories -->
         <option value="{categories.cid}" <!-- IF categories.selected -->selected<!-- ENDIF categories.selected -->>{categories.name}</option>
         <!-- END categories -->
       </select>
+
+      <!-- Persisted field: comma-separated list of cids -->
+      <input type="hidden" id="cids" name="cids" data-field="cids" value="{settings.cids}" />
+
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
     </div>
 
+    <!-- Bottom-right official save button -->
     <!-- IMPORT admin/partials/save_button.tpl -->
   </form>
 </div>