nodebb-plugin-discord-onekite 1.1.10 → 1.1.12

package/README.md

@@ -1,5 +1,4 @@
-# nodebb-plugin-discord-onekite v1.1.7
+# nodebb-plugin-discord-onekite v1.1.4.3
 
-Fixes webpack template build errors by removing `<!-- IMPORT admin/partials/save_button.tpl -->` and using an inline save button.
-
-Everything else unchanged from v1.1.6.
+Fix: syntax error in library.js (newline in join string).
+Keeps v1.1.4-based changes: single clickable link line + excerpt below.

package/library.js

@@ -8,6 +8,7 @@ const middleware = require.main.require('./src/middleware');
 
 const topics = require.main.require('./src/topics');
 const posts = require.main.require('./src/posts');
+const user = require.main.require('./src/user');
 
 const controllers = require('./lib/controllers');
 
@@ -37,6 +38,15 @@ function ensureAbsoluteUrl(baseUrl, maybeUrl) {
   return s;
 }
 
+function isValidHttpUrl(s) {
+  try {
+    const u = new URL(s);
+    return u.protocol === 'http:' || u.protocol === 'https:';
+  } catch {
+    return false;
+  }
+}
+
 function stripHtml(html) {
   if (!html) return '';
   return String(html)
@@ -89,15 +99,15 @@ async function postToDiscord(webhookUrl, payload) {
   }
 }
 
-async function sendDiscord(webhookUrl, payload) {
+async function sendDiscord(webhookUrl, payload, fallbackContent) {
   if (!webhookUrl) return;
+
   try {
     await postToDiscord(webhookUrl, payload);
   } catch (e) {
-    // If Discord rejects embeds, retry with plain content only.
-    if (e && e.statusCode === 400 && payload && payload.content) {
+    if (e && e.statusCode === 400 && fallbackContent) {
       try {
-        await postToDiscord(webhookUrl, { content: payload.content });
+        await postToDiscord(webhookUrl, { content: fallbackContent });
         return;
       } catch (e2) {
         console.error(e2);
@@ -121,25 +131,39 @@ async function getPostExcerpt(pid) {
 async function buildPayload({ tid, pid, isReply }) {
   const baseUrl = normalizeBaseUrl(meta.config.url);
 
-  const topicData = await topics.getTopicFields(tid, ['tid', 'cid', 'title', 'slug', 'mainPid']);
+  const topicData = await topics.getTopicFields(tid, ['tid', 'uid', 'cid', 'title', 'slug', 'mainPid']);
   if (!topicData) return null;
 
+  // Always build the forum link like the example: https://www.onekite.com/topic/<tid or slug>
   const topicUrl = ensureAbsoluteUrl(baseUrl, `/topic/${topicData.slug || topicData.tid}`);
-  const targetUrl = (isReply && pid) ? `${topicUrl}/${pid}` : topicUrl;
 
+  // For replies, link directly to the post if possible
+  const postUrl = (isReply && pid) ? `${topicUrl}/${pid}` : topicUrl;
+
+  const u = await user.getUserFields(topicData.uid, ['username']);
   const title = (topicData.title || (isReply ? 'Nouvelle réponse' : 'Nouveau sujet')).toString().slice(0, 256);
+  const authorName = (u && u.username ? String(u.username) : 'Utilisateur').slice(0, 256);
+
   const excerpt = await getPostExcerpt(isReply ? pid : topicData.mainPid);
+  const description = truncate(excerpt || (isReply ? `Réponse de ${authorName}` : `Sujet créé par ${authorName}`), 500);
+
+  // Minimal embed but with URL so the title is clickable
+  const embed = {
+    title,
+    description,
+  };
+  if (isValidHttpUrl(postUrl)) embed.url = postUrl;
 
-  // Single clickable link line + excerpt below
+  // Message format:
+  // 1) A single clickable link line: "🆕 Nouveau sujet : [Titre](URL)" (or reply variant)
+  // 2) Excerpt below
   const linkLine = isReply
-    ? `🗨️ Nouvelle réponse : [${title}](${targetUrl})`
+    ? `🗨️ Nouvelle réponse : [${title}](${postUrl})`
     : `🆕 Nouveau sujet : [${title}](${topicUrl})`;
 
-  const content = [linkLine, excerpt].filter(Boolean).join('\n');
-
-  const embed = { title, description: excerpt || '' , url: targetUrl };
+  const content = [linkLine, description].filter(Boolean).join('\n');
 
-  return { topicData, content, embed };
+  return { topicData, embed, content };
 }
 
 function extractTidPid(data) {
@@ -158,8 +182,8 @@ Plugin.init = async ({ router }) => {
     controllers.renderAdminPage
   );
 
-  // AJAX save endpoint (used by admin.js via api.post)
-  router.post('/admin/plugins/discord-onekite/save',
+  // AJAX save endpoint for ACP (used by admin.js)
+  router.post('/api/admin/plugins/discord-onekite/save',
     middleware.admin.checkPrivileges,
     async (req, res) => {
       try {
@@ -196,9 +220,11 @@ Plugin.onTopicPost = async (data) => {
 
   const built = await buildPayload({ tid, isReply: false });
   if (!built) return;
+
   if (!cidAllowed(built.topicData.cid, settings.cids)) return;
 
-  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] });
+  // Send content + embed (content ensures clickable link always)
+  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] }, built.content);
 };
 
 Plugin.onTopicReply = async (data) => {
@@ -211,9 +237,12 @@ Plugin.onTopicReply = async (data) => {
 
   const built = await buildPayload({ tid, pid, isReply: true });
   if (!built) return;
+
+  if (built.topicData?.mainPid && String(built.topicData.mainPid) === String(pid)) return;
+
   if (!cidAllowed(built.topicData.cid, settings.cids)) return;
 
-  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] });
+  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] }, built.content);
 };
 
 module.exports = Plugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.1.10",
+  "version": "1.1.12",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/static/lib/admin.js

@@ -21,7 +21,6 @@ define('admin/plugins/discord-onekite', ['api'], function (api) {
         cids: getMultiSelectValues('#cids'),
       };
 
-      // api.post prefixes /api automatically, so server route must be /admin/...
       api.post('/admin/plugins/discord-onekite/save', payload).then(function () {
         if (window.app && typeof app.alertSuccess === 'function') {
           app.alertSuccess('Paramètres enregistrés !');

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,13 +1,8 @@
 <div class="acp-page-container">
-  <div class="d-flex justify-content-between align-items-start mb-3">
-    <div>
-      <h4 class="mb-1">Discord Onekite</h4>
-      <p class="text-muted mb-0">Notifications Discord via webhook.</p>
-    </div>
-    <button id="save" class="btn btn-primary">
-      <i class="fa fa-save"></i> Enregistrer
-    </button>
-  </div>
+  <h4>Discord Onekite</h4>
+  <p class="text-muted">
+    Notifications Discord via webhook.
+  </p>
 
   <form role="form" class="discord-onekite-settings">
     <div class="mb-3">
@@ -33,5 +28,7 @@
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
     </div>
+
+    <!-- IMPORT admin/partials/save_button.tpl -->
   </form>
 </div>