nodebb-plugin-discord-onekite 1.0.8 → 1.0.10

package/README.md

@@ -1,5 +1,2 @@
-# nodebb-plugin-discord-onekite — v1.0.6
-
-Fixes:
-- Form action/redirect no longer uses `{config.relative_path}` (was rendering as `undefined` on your install).
-- Categories are fetched server-side via `categories.getCategoriesByPrivilege('categories:cid', uid, 'read', ...)` (returns category objects). citeturn0search10
+# nodebb-plugin-discord-onekite v1.0.8
+Clean build (no debug). Server-side ACP + success alert.

package/lib/controllers.js

@@ -13,8 +13,6 @@ function normalizeCids(v) {
 }
 
 async function getReadableCategories(uid) {
-  // NodeBB core uses this helper to get categories for a user by privilege.
-  // It returns an array of category objects (cid, name, slug, ...). citeturn0search10
   return await new Promise((resolve) => {
     categories.getCategoriesByPrivilege('categories:cid', uid || 0, 'read', (err, categoriesData) => {
       if (err || !Array.isArray(categoriesData)) return resolve([]);
@@ -42,6 +40,7 @@ controllers.renderAdminPage = async function (req, res) {
   res.render('admin/plugins/discord-onekite', {
     settings: settings || {},
     categories: categoriesForTpl,
+    saved: req.query && (req.query.saved === '1' || req.query.saved === 'true'),
   });
 };
 

package/library.js

@@ -82,7 +82,6 @@ Plugin.init = async ({ router }) => {
     controllers.renderAdminPage
   );
 
-  // POST save - keep it very simple and redirect to the canonical path
   router.post('/admin/plugins/discord-onekite/save',
     middleware.admin.checkPrivileges,
     async (req, res) => {
@@ -94,9 +93,10 @@ Plugin.init = async ({ router }) => {
         };
         await meta.settings.set(SETTINGS_KEY, payload);
       } catch (e) {
+        // eslint-disable-next-line no-console
         console.error('[discord-onekite] save failed', e);
       }
-      res.redirect('/admin/plugins/discord-onekite');
+      res.redirect('/admin/plugins/discord-onekite?saved=1');
     }
   );
 };
@@ -132,6 +132,7 @@ Plugin.onTopicSave = async (data) => {
 
     await postToDiscord(settings.webhookUrl, { embeds: [built.embed] });
   } catch (err) {
+    // eslint-disable-next-line no-console
     console.error(err);
   }
 };
@@ -157,6 +158,7 @@ Plugin.onPostSave = async (data) => {
 
     await postToDiscord(settings.webhookUrl, { embeds: [built.embed] });
   } catch (err) {
+    // eslint-disable-next-line no-console
     console.error(err);
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.8",
+  "version": "1.0.10",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,9 +1,15 @@
 <div class="acp-page-container">
   <h4>Discord Onekite</h4>
   <p class="text-muted">
-    Notifications Discord via webhook (page ACP en rendu serveur).
+    Notifications Discord via webhook (rendu serveur).
   </p>
 
+  <!-- IF saved -->
+  <div class="alert alert-success" role="alert">
+    Paramètres enregistrés !
+  </div>
+  <!-- ENDIF saved -->
+
   <form role="form" method="post" action="/admin/plugins/discord-onekite/save">
     <input type="hidden" name="_csrf" value="{config.csrf_token}" />