nodebb-plugin-discord-onekite 1.0.6 → 1.0.7

package/README.md

@@ -1,8 +1,5 @@
-# nodebb-plugin-discord-onekite — v1.0.5 (server-side ACP)
+# nodebb-plugin-discord-onekite — v1.0.6
 
-If your ACP JS is not loading for any reason (custom admin theme, aggressive bundling, CSP, etc.),
-this version avoids it entirely:
-
-- Categories are rendered server-side.
-- Settings are saved via a normal POST form submit.
-- CSRF token is provided via `{config.csrf_token}`.
+Fixes:
+- Form action/redirect no longer uses `{config.relative_path}` (was rendering as `undefined` on your install).
+- Categories are fetched server-side via `categories.getCategoriesByPrivilege('categories:cid', uid, 'read', ...)` (returns category objects). citeturn0search10

package/lib/controllers.js

@@ -12,21 +12,14 @@ function normalizeCids(v) {
   return [];
 }
 
-async function getCategoriesForAdmin(uid) {
-  // This API exists in NodeBB and is used in various plugins/examples.
-  // If it ever changes, the fallback is to just return an empty array.
+async function getReadableCategories(uid) {
+  // NodeBB core uses this helper to get categories for a user by privilege.
+  // It returns an array of category objects (cid, name, slug, ...). citeturn0search10
   return await new Promise((resolve) => {
-    try {
-      categories.getCategoriesByPrivilege('categories:cid', uid, 'read', (err, cids) => {
-        if (err || !Array.isArray(cids)) return resolve([]);
-        categories.getCategoriesData(cids, uid, (err2, data) => {
-          if (err2 || !Array.isArray(data)) return resolve([]);
-          resolve(data);
-        });
-      });
-    } catch (e) {
-      resolve([]);
-    }
+    categories.getCategoriesByPrivilege('categories:cid', uid || 0, 'read', (err, categoriesData) => {
+      if (err || !Array.isArray(categoriesData)) return resolve([]);
+      resolve(categoriesData.filter(Boolean));
+    });
   });
 }
 
@@ -36,7 +29,7 @@ controllers.renderAdminPage = async function (req, res) {
   const settings = await meta.settings.get(SETTINGS_KEY);
   const savedCids = normalizeCids(settings && settings.cids);
 
-  const cats = await getCategoriesForAdmin(req.uid);
+  const cats = await getReadableCategories(req.uid);
   const categoriesForTpl = (cats || [])
     .filter(c => c && typeof c.cid !== 'undefined' && c.name)
     .map(c => ({

package/library.js

@@ -75,7 +75,6 @@ async function buildTopicEmbed({ tid, pid, type }) {
 const Plugin = {};
 
 Plugin.init = async ({ router }) => {
-  // GET admin page
   routeHelpers.setupAdminPageRoute(
     router,
     '/admin/plugins/discord-onekite',
@@ -83,8 +82,7 @@ Plugin.init = async ({ router }) => {
     controllers.renderAdminPage
   );
 
-  // POST save (server-side, no ACP JS needed)
-  // Protect via admin middleware; CSRF is checked globally by NodeBB when _csrf is present.
+  // POST save - keep it very simple and redirect to the canonical path
   router.post('/admin/plugins/discord-onekite/save',
     middleware.admin.checkPrivileges,
     async (req, res) => {
@@ -92,15 +90,13 @@ Plugin.init = async ({ router }) => {
         const payload = {
           webhookUrl: req.body.webhookUrl || '',
           notifyReplies: req.body.notifyReplies ? 'on' : '',
-          // multiple select may come as string or array
           cids: req.body.cids || '',
         };
         await meta.settings.set(SETTINGS_KEY, payload);
       } catch (e) {
-        // eslint-disable-next-line no-console
         console.error('[discord-onekite] save failed', e);
       }
-      res.redirect(`${meta.config.relative_path}/admin/plugins/discord-onekite`);
+      res.redirect('/admin/plugins/discord-onekite');
     }
   );
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,10 +1,10 @@
 <div class="acp-page-container">
   <h4>Discord Onekite</h4>
   <p class="text-muted">
-    Notifications Discord via webhook (sans JS côté ACP).
+    Notifications Discord via webhook (page ACP en rendu serveur).
   </p>
 
-  <form role="form" method="post" action="{config.relative_path}/admin/plugins/discord-onekite/save">
+  <form role="form" method="post" action="/admin/plugins/discord-onekite/save">
     <input type="hidden" name="_csrf" value="{config.csrf_token}" />
 
     <div class="mb-3">