nodebb-plugin-discord-onekite 1.0.5 → 1.0.7

package/README.md

@@ -1,7 +1,5 @@
-# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.4
+# nodebb-plugin-discord-onekite — v1.0.6
 
-This version follows the most compatible ACP pattern used by many official/community plugins:
-
-- Templates are in `templates/` (not `static/templates/`)
-- ACP script is loaded via `acpScripts` and runs globally on `action:ajaxify.end`
-- No reliance on `modules` name matching
+Fixes:
+- Form action/redirect no longer uses `{config.relative_path}` (was rendering as `undefined` on your install).
+- Categories are fetched server-side via `categories.getCategoriesByPrivilege('categories:cid', uid, 'read', ...)` (returns category objects). citeturn0search10

package/lib/controllers.js

@@ -1,9 +1,48 @@
 'use strict';
 
+const meta = require.main.require('./src/meta');
+const categories = require.main.require('./src/categories');
+
+const SETTINGS_KEY = 'discord-onekite';
+
+function normalizeCids(v) {
+  if (!v) return [];
+  if (Array.isArray(v)) return v.map(String).filter(Boolean);
+  if (typeof v === 'string') return v.split(',').map(s => s.trim()).filter(Boolean);
+  return [];
+}
+
+async function getReadableCategories(uid) {
+  // NodeBB core uses this helper to get categories for a user by privilege.
+  // It returns an array of category objects (cid, name, slug, ...). citeturn0search10
+  return await new Promise((resolve) => {
+    categories.getCategoriesByPrivilege('categories:cid', uid || 0, 'read', (err, categoriesData) => {
+      if (err || !Array.isArray(categoriesData)) return resolve([]);
+      resolve(categoriesData.filter(Boolean));
+    });
+  });
+}
+
 const controllers = {};
 
 controllers.renderAdminPage = async function (req, res) {
-  res.render('admin/plugins/discord-onekite', {});
+  const settings = await meta.settings.get(SETTINGS_KEY);
+  const savedCids = normalizeCids(settings && settings.cids);
+
+  const cats = await getReadableCategories(req.uid);
+  const categoriesForTpl = (cats || [])
+    .filter(c => c && typeof c.cid !== 'undefined' && c.name)
+    .map(c => ({
+      cid: String(c.cid),
+      name: c.name,
+      selected: savedCids.includes(String(c.cid)),
+    }))
+    .sort((a, b) => a.name.localeCompare(b.name));
+
+  res.render('admin/plugins/discord-onekite', {
+    settings: settings || {},
+    categories: categoriesForTpl,
+  });
 };
 
 module.exports = controllers;

package/library.js

@@ -4,6 +4,7 @@ const { request } = require('undici');
 
 const routeHelpers = require.main.require('./src/routes/helpers');
 const meta = require.main.require('./src/meta');
+const middleware = require.main.require('./src/middleware');
 
 const topics = require.main.require('./src/topics');
 const user = require.main.require('./src/user');
@@ -80,6 +81,24 @@ Plugin.init = async ({ router }) => {
     [],
     controllers.renderAdminPage
   );
+
+  // POST save - keep it very simple and redirect to the canonical path
+  router.post('/admin/plugins/discord-onekite/save',
+    middleware.admin.checkPrivileges,
+    async (req, res) => {
+      try {
+        const payload = {
+          webhookUrl: req.body.webhookUrl || '',
+          notifyReplies: req.body.notifyReplies ? 'on' : '',
+          cids: req.body.cids || '',
+        };
+        await meta.settings.set(SETTINGS_KEY, payload);
+      } catch (e) {
+        console.error('[discord-onekite] save failed', e);
+      }
+      res.redirect('/admin/plugins/discord-onekite');
+    }
+  );
 };
 
 Plugin.addAdminNavigation = (header) => {

package/package.json

@@ -1,14 +1,20 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",
-  "keywords": ["nodebb", "plugin", "discord", "webhook", "notifications"],
+  "keywords": [
+    "nodebb",
+    "plugin",
+    "discord",
+    "webhook",
+    "notifications"
+  ],
   "dependencies": {
     "undici": "^6.0.0"
   },
   "nbbpm": {
     "compatibility": "^4.0.0"
   }
-}
+}

package/plugin.json

@@ -1,14 +1,25 @@
 {
   "id": "nodebb-plugin-discord-onekite",
   "name": "Discord Onekite Notifier",
-  "description": "Notifie Discord via webhook pour nouveaux sujets et/ou réponses, filtrable par catégories (NodeBB v4.x uniquement).",
+  "description": "Notifie Discord via webhook pour nouveaux sujets et/ou r\u00e9ponses, filtrable par cat\u00e9gories (NodeBB v4.x uniquement).",
   "library": "./library.js",
   "hooks": [
-    { "hook": "static:app.load", "method": "init" },
-    { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },
-    { "hook": "action:topic.save", "method": "onTopicSave" },
-    { "hook": "action:post.save", "method": "onPostSave" }
+    {
+      "hook": "static:app.load",
+      "method": "init"
+    },
+    {
+      "hook": "filter:admin.header.build",
+      "method": "addAdminNavigation"
+    },
+    {
+      "hook": "action:topic.save",
+      "method": "onTopicSave"
+    },
+    {
+      "hook": "action:post.save",
+      "method": "onPostSave"
+    }
   ],
-  "templates": "templates",
-  "acpScripts": ["static/lib/admin.js"]
-}
+  "templates": "templates"
+}

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,17 +1,19 @@
 <div class="acp-page-container">
   <h4>Discord Onekite</h4>
   <p class="text-muted">
-    Notifications Discord via webhook.
+    Notifications Discord via webhook (page ACP en rendu serveur).
   </p>
 
-  <form role="form" class="discord-onekite-settings">
+  <form role="form" method="post" action="/admin/plugins/discord-onekite/save">
+    <input type="hidden" name="_csrf" value="{config.csrf_token}" />
+
     <div class="mb-3">
       <label class="form-label" for="webhookUrl">Discord Webhook URL</label>
-      <input type="text" class="form-control" id="webhookUrl" name="webhookUrl" placeholder="https://discord.com/api/webhooks/..." />
+      <input type="text" class="form-control" id="webhookUrl" name="webhookUrl" value="{settings.webhookUrl}" placeholder="https://discord.com/api/webhooks/..." />
     </div>
 
     <div class="form-check mb-3">
-      <input class="form-check-input" type="checkbox" id="notifyReplies" name="notifyReplies">
+      <input class="form-check-input" type="checkbox" id="notifyReplies" name="notifyReplies" <!-- IF settings.notifyReplies -->checked<!-- ENDIF settings.notifyReplies -->>
       <label class="form-check-label" for="notifyReplies">
         Notifier aussi les réponses (si décoché : uniquement les nouveaux sujets)
       </label>
@@ -19,12 +21,16 @@
 
     <div class="mb-3">
       <label class="form-label" for="cids">Catégories à notifier</label>
-      <select class="form-select" id="cids" name="cids" multiple size="12"></select>
+      <select class="form-select" id="cids" name="cids" multiple size="12">
+        <!-- BEGIN categories -->
+        <option value="{categories.cid}" <!-- IF categories.selected -->selected<!-- ENDIF categories.selected -->>{categories.name}</option>
+        <!-- END categories -->
+      </select>
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
     </div>
 
-    <!-- IMPORT admin/partials/save_button.tpl -->
+    <button type="submit" class="btn btn-primary">Enregistrer</button>
   </form>
 </div>

package/static/lib/admin.js

@@ -1,67 +0,0 @@
-'use strict';
-/* global $, app, ajaxify */
-
-(function () {
-  function initOnekiteACP() {
-    if (!ajaxify || !ajaxify.data || ajaxify.data.template !== 'admin/plugins/discord-onekite') {
-      return;
-    }
-
-    // Use NodeBB's AMD loader to access core helpers
-    require(['settings', 'api'], function (settings, api) {
-      const $form = $('.discord-onekite-settings');
-      if (!$form.length) return;
-
-      // Avoid double-binding
-      if ($form.data('onekite-initialized')) return;
-      $form.data('onekite-initialized', true);
-
-      function normalizeCids(v) {
-        if (!v) return [];
-        if (Array.isArray(v)) return v.map(String).filter(Boolean);
-        if (typeof v === 'string') return v.split(',').map(s => s.trim()).filter(Boolean);
-        return [];
-      }
-
-      // Load saved settings into the form
-      settings.load('discord-onekite', $form);
-
-      // Get raw settings so we can pre-select categories
-      settings.get('discord-onekite', function (saved) {
-        saved = saved || {};
-        const savedCids = normalizeCids(saved.cids);
-
-        // Load categories (admin should have access)
-        api.get('/categories').then(function (res) {
-          const categories = (res && res.categories) ? res.categories : [];
-          const $select = $('#cids');
-          $select.empty();
-
-          categories
-            .filter(c => c && typeof c.cid !== 'undefined' && c.name)
-            .forEach(c => {
-              const cid = String(c.cid);
-              const $opt = $('<option/>').val(cid).text(c.name);
-              if (savedCids.includes(cid)) $opt.prop('selected', true);
-              $opt.appendTo($select);
-            });
-        }).catch(function (e) {
-          // eslint-disable-next-line no-console
-          console.error('[discord-onekite] GET /api/categories failed', e);
-          if (app && app.alertError) app.alertError('Impossible de charger les catégories (GET /api/categories).');
-        });
-      });
-
-      // Save
-      $('#save').off('click.discordOnekite').on('click.discordOnekite', function () {
-        settings.save('discord-onekite', $form, function () {
-          if (app && app.alertSuccess) app.alertSuccess('Paramètres enregistrés !');
-        });
-      });
-    });
-  }
-
-  // Run on initial load and after ajax navigation in ACP
-  $(window).on('action:ajaxify.end', initOnekiteACP);
-  $(initOnekiteACP);
-})();