nodebb-plugin-discord-onekite 1.0.4 → 1.0.5

package/README.md

@@ -1,8 +1,7 @@
-# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.3
+# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.4
 
-This version aligns more closely with the official Quickstart pattern:
-- uses `modules` mapping (no leading ./) to expose `admin/plugins/discord-onekite`
-- template has no inline script
-- admin.js logs `[discord-onekite] admin init` when loaded
+This version follows the most compatible ACP pattern used by many official/community plugins:
 
-If you still don't see that log, NodeBB isn't loading the module, so we can narrow it down quickly.
+- Templates are in `templates/` (not `static/templates/`)
+- ACP script is loaded via `acpScripts` and runs globally on `action:ajaxify.end`
+- No reliance on `modules` name matching

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -2,15 +2,13 @@
   "id": "nodebb-plugin-discord-onekite",
   "name": "Discord Onekite Notifier",
   "description": "Notifie Discord via webhook pour nouveaux sujets et/ou réponses, filtrable par catégories (NodeBB v4.x uniquement).",
-  "library": "library.js",
+  "library": "./library.js",
   "hooks": [
     { "hook": "static:app.load", "method": "init" },
     { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },
     { "hook": "action:topic.save", "method": "onTopicSave" },
     { "hook": "action:post.save", "method": "onPostSave" }
   ],
-  "templates": "static/templates",
-  "modules": {
-    "../admin/plugins/discord-onekite.js": "static/lib/admin.js"
-  }
+  "templates": "templates",
+  "acpScripts": ["static/lib/admin.js"]
 }

package/static/lib/admin.js

@@ -1,70 +1,67 @@
 'use strict';
 /* global $, app, ajaxify */
 
-define('admin/plugins/discord-onekite', ['settings', 'api'], function (settings, api) {
-  const ACP = {};
+(function () {
+  function initOnekiteACP() {
+    if (!ajaxify || !ajaxify.data || ajaxify.data.template !== 'admin/plugins/discord-onekite') {
+      return;
+    }
 
-  function normalizeCids(v) {
-    if (!v) return [];
-    if (Array.isArray(v)) return v.map(String).filter(Boolean);
-    if (typeof v === 'string') return v.split(',').map(s => s.trim()).filter(Boolean);
-    return [];
-  }
+    // Use NodeBB's AMD loader to access core helpers
+    require(['settings', 'api'], function (settings, api) {
+      const $form = $('.discord-onekite-settings');
+      if (!$form.length) return;
 
-  async function fetchCategories() {
-    // In NodeBB, api.get('/categories') => GET /api/categories
-    const res = await api.get('/categories');
-    return (res && res.categories) ? res.categories : [];
-  }
+      // Avoid double-binding
+      if ($form.data('onekite-initialized')) return;
+      $form.data('onekite-initialized', true);
 
-  ACP.init = async function () {
-    // This should be called automatically by NodeBB when template admin/plugins/discord-onekite is loaded.
-    // Also safe to call multiple times.
-    console.log('[discord-onekite] admin init');
+      function normalizeCids(v) {
+        if (!v) return [];
+        if (Array.isArray(v)) return v.map(String).filter(Boolean);
+        if (typeof v === 'string') return v.split(',').map(s => s.trim()).filter(Boolean);
+        return [];
+      }
 
-    const $form = $('.discord-onekite-settings');
-    if (!$form.length) return;
+      // Load saved settings into the form
+      settings.load('discord-onekite', $form);
 
-    // Load current settings
-    const saved = await new Promise((resolve) => {
-      settings.get('discord-onekite', (data) => resolve(data || {}));
-    });
+      // Get raw settings so we can pre-select categories
+      settings.get('discord-onekite', function (saved) {
+        saved = saved || {};
+        const savedCids = normalizeCids(saved.cids);
 
-    settings.load('discord-onekite', $form);
-    const savedCids = normalizeCids(saved.cids);
+        // Load categories (admin should have access)
+        api.get('/categories').then(function (res) {
+          const categories = (res && res.categories) ? res.categories : [];
+          const $select = $('#cids');
+          $select.empty();
 
-    // Populate categories select
-    const $select = $('#cids');
-    try {
-      const categories = await fetchCategories();
-      $select.empty();
-      categories
-        .filter(c => c && typeof c.cid !== 'undefined' && c.name)
-        .forEach(c => {
-          const cid = String(c.cid);
-          const $opt = $('<option />').val(cid).text(c.name);
-          if (savedCids.includes(cid)) $opt.prop('selected', true);
-          $opt.appendTo($select);
+          categories
+            .filter(c => c && typeof c.cid !== 'undefined' && c.name)
+            .forEach(c => {
+              const cid = String(c.cid);
+              const $opt = $('<option/>').val(cid).text(c.name);
+              if (savedCids.includes(cid)) $opt.prop('selected', true);
+              $opt.appendTo($select);
+            });
+        }).catch(function (e) {
+          // eslint-disable-next-line no-console
+          console.error('[discord-onekite] GET /api/categories failed', e);
+          if (app && app.alertError) app.alertError('Impossible de charger les catégories (GET /api/categories).');
         });
-    } catch (e) {
-      console.error('[discord-onekite] failed to fetch categories', e);
-      if (app && app.alertError) app.alertError('Impossible de charger la liste des catégories (GET /api/categories).');
-    }
+      });
 
-    // Save
-    $('#save').off('click.discordOnekite').on('click.discordOnekite', function () {
-      settings.save('discord-onekite', $form, function () {
-        if (app && app.alertSuccess) app.alertSuccess('Paramètres enregistrés !');
+      // Save
+      $('#save').off('click.discordOnekite').on('click.discordOnekite', function () {
+        settings.save('discord-onekite', $form, function () {
+          if (app && app.alertSuccess) app.alertSuccess('Paramètres enregistrés !');
+        });
       });
     });
-  };
-
-  // Fallback for ajaxified ACP navigation
-  $(window).off('action:ajaxify.end.discordOnekite').on('action:ajaxify.end.discordOnekite', function (ev, data) {
-    if (data && data.template === 'admin/plugins/discord-onekite') {
-      ACP.init();
-    }
-  });
+  }
 
-  return ACP;
-});
+  // Run on initial load and after ajax navigation in ACP
+  $(window).on('action:ajaxify.end', initOnekiteACP);
+  $(initOnekiteACP);
+})();

package/{static/templates → templates}/admin/plugins/discord-onekite.tpl

@@ -1,7 +1,7 @@
 <div class="acp-page-container">
   <h4>Discord Onekite</h4>
   <p class="text-muted">
-    Envoie une notification dans Discord via webhook, avec filtres par catégories.
+    Notifications Discord via webhook.
   </p>
 
   <form role="form" class="discord-onekite-settings">
@@ -23,9 +23,6 @@
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
-      <p class="form-text">
-        <em>Astuce debug :</em> ouvre la console navigateur, tu dois voir <code>[discord-onekite] admin init</code>.
-      </p>
     </div>
 
     <!-- IMPORT admin/partials/save_button.tpl -->