nodebb-plugin-discord-onekite 1.0.3 → 1.0.4

package/README.md

@@ -1,8 +1,8 @@
-# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.2
+# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.3
 
-Fix ACP issues:
-- Uses `modules` mapping so `require('admin/plugins/discord-onekite')` always resolves.
-- Multi-select uses `name="cids[]"` so selections persist.
-- Also hooks `action:ajaxify.end` as a fallback in admin to re-init after navigation.
+This version aligns more closely with the official Quickstart pattern:
+- uses `modules` mapping (no leading ./) to expose `admin/plugins/discord-onekite`
+- template has no inline script
+- admin.js logs `[discord-onekite] admin init` when loaded
 
-Requirement: no categories selected => notify all.
+If you still don't see that log, NodeBB isn't loading the module, so we can narrow it down quickly.

package/library.js

@@ -21,7 +21,6 @@ function normalizeCids(value) {
 
 async function getSettings() {
   const s = await meta.settings.get(SETTINGS_KEY);
-  // Note: when select name is cids[], nodebb may save it as array or comma string; normalize handles both.
   return {
     webhookUrl: (s && s.webhookUrl) ? String(s.webhookUrl).trim() : '',
     notifyReplies: !!(s && (s.notifyReplies === true || s.notifyReplies === 'on' || s.notifyReplies === 'true')),
@@ -30,7 +29,7 @@ async function getSettings() {
 }
 
 function cidAllowed(topicCid, allowedCids) {
-  if (!allowedCids || allowedCids.length === 0) return true; // none selected => ALL
+  if (!allowedCids || allowedCids.length === 0) return true;
   return allowedCids.includes(String(topicCid));
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -2,7 +2,7 @@
   "id": "nodebb-plugin-discord-onekite",
   "name": "Discord Onekite Notifier",
   "description": "Notifie Discord via webhook pour nouveaux sujets et/ou réponses, filtrable par catégories (NodeBB v4.x uniquement).",
-  "library": "./library.js",
+  "library": "library.js",
   "hooks": [
     { "hook": "static:app.load", "method": "init" },
     { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },
@@ -11,6 +11,6 @@
   ],
   "templates": "static/templates",
   "modules": {
-    "../admin/plugins/discord-onekite.js": "./static/lib/admin.js"
+    "../admin/plugins/discord-onekite.js": "static/lib/admin.js"
   }
 }

package/static/lib/admin.js

@@ -3,7 +3,6 @@
 
 define('admin/plugins/discord-onekite', ['settings', 'api'], function (settings, api) {
   const ACP = {};
-  let initialized = false;
 
   function normalizeCids(v) {
     if (!v) return [];
@@ -12,69 +11,57 @@ define('admin/plugins/discord-onekite', ['settings', 'api'], function (settings,
     return [];
   }
 
-  async function loadCategoriesIntoSelect(savedCids) {
-    const $select = $('#cids');
-    if (!$select.length) return;
-
+  async function fetchCategories() {
+    // In NodeBB, api.get('/categories') => GET /api/categories
     const res = await api.get('/categories');
-
-    // Depending on endpoint, categories may be at res.categories or res.category
-    const categories = (res && (res.categories || res.category || res.data || [])) || [];
-    const list = Array.isArray(categories) ? categories : [];
-
-    $select.empty();
-    list
-      .filter(c => c && typeof c.cid !== 'undefined' && c.name)
-      .forEach(c => {
-        const cid = String(c.cid);
-        const $opt = $('<option />').val(cid).text(c.name);
-        if (savedCids.includes(cid)) $opt.prop('selected', true);
-        $opt.appendTo($select);
-      });
+    return (res && res.categories) ? res.categories : [];
   }
 
   ACP.init = async function () {
-    // NodeBB will call init() on page load for template admin/plugins/discord-onekite.
-    // But ACP is ajaxified; ensure we don't double-bind.
-    if (initialized) {
-      return;
-    }
-    initialized = true;
+    // This should be called automatically by NodeBB when template admin/plugins/discord-onekite is loaded.
+    // Also safe to call multiple times.
+    console.log('[discord-onekite] admin init');
 
     const $form = $('.discord-onekite-settings');
     if (!$form.length) return;
 
-    // 1) Load raw settings first (to get cids)
+    // Load current settings
     const saved = await new Promise((resolve) => {
       settings.get('discord-onekite', (data) => resolve(data || {}));
     });
 
-    const savedCids = normalizeCids(saved.cids);
-
-    // 2) Populate fields
     settings.load('discord-onekite', $form);
+    const savedCids = normalizeCids(saved.cids);
 
-    // 3) Populate categories + apply selection
+    // Populate categories select
+    const $select = $('#cids');
     try {
-      await loadCategoriesIntoSelect(savedCids);
+      const categories = await fetchCategories();
+      $select.empty();
+      categories
+        .filter(c => c && typeof c.cid !== 'undefined' && c.name)
+        .forEach(c => {
+          const cid = String(c.cid);
+          const $opt = $('<option />').val(cid).text(c.name);
+          if (savedCids.includes(cid)) $opt.prop('selected', true);
+          $opt.appendTo($select);
+        });
     } catch (e) {
-      // eslint-disable-next-line no-console
-      console.error('[discord-onekite] categories load failed', e);
-      app.alertError('Impossible de charger la liste des catégories.');
+      console.error('[discord-onekite] failed to fetch categories', e);
+      if (app && app.alertError) app.alertError('Impossible de charger la liste des catégories (GET /api/categories).');
     }
 
-    // 4) Save
+    // Save
     $('#save').off('click.discordOnekite').on('click.discordOnekite', function () {
       settings.save('discord-onekite', $form, function () {
-        app.alertSuccess('Paramètres enregistrés !');
+        if (app && app.alertSuccess) app.alertSuccess('Paramètres enregistrés !');
       });
     });
   };
 
-  // In case NodeBB doesn't call init (theme/custom admin), also listen for ajaxify end
-  $(window).off('action:ajaxify.end.discordOnekite').on('action:ajaxify.end.discordOnekite', function () {
-    if (ajaxify && ajaxify.data && ajaxify.data.template === 'admin/plugins/discord-onekite') {
-      initialized = false;
+  // Fallback for ajaxified ACP navigation
+  $(window).off('action:ajaxify.end.discordOnekite').on('action:ajaxify.end.discordOnekite', function (ev, data) {
+    if (data && data.template === 'admin/plugins/discord-onekite') {
       ACP.init();
     }
   });

package/static/templates/admin/plugins/discord-onekite.tpl

@@ -19,10 +19,13 @@
 
     <div class="mb-3">
       <label class="form-label" for="cids">Catégories à notifier</label>
-      <select class="form-select" id="cids" name="cids[]" multiple size="12"></select>
+      <select class="form-select" id="cids" name="cids" multiple size="12"></select>
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
+      <p class="form-text">
+        <em>Astuce debug :</em> ouvre la console navigateur, tu dois voir <code>[discord-onekite] admin init</code>.
+      </p>
     </div>
 
     <!-- IMPORT admin/partials/save_button.tpl -->