nodebb-plugin-discord-onekite 1.0.2 → 1.0.4

package/README.md

@@ -1,7 +1,8 @@
-# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.1
+# nodebb-plugin-discord-onekite (NodeBB v4.x) — v1.0.3
 
-Fix: template build errors by removing inline <script> from the .tpl and using acpScripts properly.
+This version aligns more closely with the official Quickstart pattern:
+- uses `modules` mapping (no leading ./) to expose `admin/plugins/discord-onekite`
+- template has no inline script
+- admin.js logs `[discord-onekite] admin init` when loaded
 
-- Categories list loads in ACP
-- Settings save works
-- No categories selected => notify all
+If you still don't see that log, NodeBB isn't loading the module, so we can narrow it down quickly.

package/library.js

@@ -15,9 +15,7 @@ const SETTINGS_KEY = 'discord-onekite';
 function normalizeCids(value) {
   if (!value) return [];
   if (Array.isArray(value)) return value.map(v => String(v)).filter(Boolean);
-  if (typeof value === 'string') {
-    return value.split(',').map(s => s.trim()).filter(Boolean);
-  }
+  if (typeof value === 'string') return value.split(',').map(s => s.trim()).filter(Boolean);
   return [];
 }
 
@@ -31,7 +29,6 @@ async function getSettings() {
 }
 
 function cidAllowed(topicCid, allowedCids) {
-  // none selected => ALL
   if (!allowedCids || allowedCids.length === 0) return true;
   return allowedCids.includes(String(topicCid));
 }
@@ -69,9 +66,7 @@ async function buildTopicEmbed({ tid, pid, type }) {
     footer: { text: 'NodeBB → Discord (Onekite)' },
   };
 
-  if (isReply) {
-    embed.description = 'Nouvelle réponse dans un sujet.';
-  }
+  if (isReply) embed.description = 'Nouvelle réponse dans un sujet.';
 
   return { topicData, embed };
 }
@@ -118,7 +113,6 @@ Plugin.onTopicSave = async (data) => {
 
     await postToDiscord(settings.webhookUrl, { embeds: [built.embed] });
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error(err);
   }
 };
@@ -144,7 +138,6 @@ Plugin.onPostSave = async (data) => {
 
     await postToDiscord(settings.webhookUrl, { embeds: [built.embed] });
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error(err);
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -2,7 +2,7 @@
   "id": "nodebb-plugin-discord-onekite",
   "name": "Discord Onekite Notifier",
   "description": "Notifie Discord via webhook pour nouveaux sujets et/ou réponses, filtrable par catégories (NodeBB v4.x uniquement).",
-  "library": "./library.js",
+  "library": "library.js",
   "hooks": [
     { "hook": "static:app.load", "method": "init" },
     { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },
@@ -10,5 +10,7 @@
     { "hook": "action:post.save", "method": "onPostSave" }
   ],
   "templates": "static/templates",
-  "acpScripts": ["static/lib/admin.js"]
+  "modules": {
+    "../admin/plugins/discord-onekite.js": "static/lib/admin.js"
+  }
 }

package/static/lib/admin.js

@@ -1,5 +1,5 @@
 'use strict';
-/* global $, app */
+/* global $, app, ajaxify */
 
 define('admin/plugins/discord-onekite', ['settings', 'api'], function (settings, api) {
   const ACP = {};
@@ -7,61 +7,64 @@ define('admin/plugins/discord-onekite', ['settings', 'api'], function (settings,
   function normalizeCids(v) {
     if (!v) return [];
     if (Array.isArray(v)) return v.map(String).filter(Boolean);
-    if (typeof v === 'string') {
-      return v.split(',').map(s => s.trim()).filter(Boolean);
-    }
+    if (typeof v === 'string') return v.split(',').map(s => s.trim()).filter(Boolean);
     return [];
   }
 
+  async function fetchCategories() {
+    // In NodeBB, api.get('/categories') => GET /api/categories
+    const res = await api.get('/categories');
+    return (res && res.categories) ? res.categories : [];
+  }
+
   ACP.init = async function () {
+    // This should be called automatically by NodeBB when template admin/plugins/discord-onekite is loaded.
+    // Also safe to call multiple times.
+    console.log('[discord-onekite] admin init');
+
     const $form = $('.discord-onekite-settings');
-    const $select = $('#cids');
+    if (!$form.length) return;
 
-    // Load current saved settings (including cids) BEFORE fetching categories,
-    // so we can apply selection after options are created.
-    let saved = {};
-    try {
-      saved = await new Promise((resolve) => {
-        settings.get('discord-onekite', (data) => resolve(data || {}));
-      });
-    } catch (e) {
-      saved = {};
-    }
+    // Load current settings
+    const saved = await new Promise((resolve) => {
+      settings.get('discord-onekite', (data) => resolve(data || {}));
+    });
 
-    // Populate simple fields (webhookUrl, notifyReplies, etc.)
     settings.load('discord-onekite', $form);
-
     const savedCids = normalizeCids(saved.cids);
 
-    // Fetch categories list and populate select
+    // Populate categories select
+    const $select = $('#cids');
     try {
-      const res = await api.get('/categories');
-      const categories = (res && res.categories) ? res.categories : [];
-
+      const categories = await fetchCategories();
       $select.empty();
       categories
         .filter(c => c && typeof c.cid !== 'undefined' && c.name)
         .forEach(c => {
           const cid = String(c.cid);
           const $opt = $('<option />').val(cid).text(c.name);
-          if (savedCids.includes(cid)) {
-            $opt.prop('selected', true);
-          }
+          if (savedCids.includes(cid)) $opt.prop('selected', true);
           $opt.appendTo($select);
         });
     } catch (e) {
-      // eslint-disable-next-line no-console
-      console.error('[discord-onekite] Could not load categories', e);
-      app.alertError('Impossible de charger la liste des catégories.');
+      console.error('[discord-onekite] failed to fetch categories', e);
+      if (app && app.alertError) app.alertError('Impossible de charger la liste des catégories (GET /api/categories).');
     }
 
-    // Save button
+    // Save
     $('#save').off('click.discordOnekite').on('click.discordOnekite', function () {
       settings.save('discord-onekite', $form, function () {
-        app.alertSuccess('Paramètres enregistrés !');
+        if (app && app.alertSuccess) app.alertSuccess('Paramètres enregistrés !');
       });
     });
   };
 
+  // Fallback for ajaxified ACP navigation
+  $(window).off('action:ajaxify.end.discordOnekite').on('action:ajaxify.end.discordOnekite', function (ev, data) {
+    if (data && data.template === 'admin/plugins/discord-onekite') {
+      ACP.init();
+    }
+  });
+
   return ACP;
 });

package/static/templates/admin/plugins/discord-onekite.tpl

@@ -8,9 +8,6 @@
     <div class="mb-3">
       <label class="form-label" for="webhookUrl">Discord Webhook URL</label>
       <input type="text" class="form-control" id="webhookUrl" name="webhookUrl" placeholder="https://discord.com/api/webhooks/..." />
-      <p class="form-text text-muted">
-        Discord → Salon #notifications → Intégrations → Webhooks → Copier l’URL.
-      </p>
     </div>
 
     <div class="form-check mb-3">
@@ -26,6 +23,9 @@
       <p class="form-text text-muted">
         Si aucune catégorie n’est sélectionnée : <strong>toutes les catégories</strong> seront notifiées.
       </p>
+      <p class="form-text">
+        <em>Astuce debug :</em> ouvre la console navigateur, tu dois voir <code>[discord-onekite] admin init</code>.
+      </p>
     </div>
 
     <!-- IMPORT admin/partials/save_button.tpl -->