nodebb-plugin-discord-onekite 1.0.14 → 1.0.15

package/README.md

@@ -1,10 +1,8 @@
-# nodebb-plugin-discord-onekite v1.1.3
+# nodebb-plugin-discord-onekite v1.1.4
 
-ACP:
-- Uses the standard NodeBB save "disk" button (IMPORT admin/partials/save_button.tpl)
-- Saves via AJAX to `/api/admin/plugins/discord-onekite/save` and shows NodeBB toast (bottom-right)
+Discord:
+- Always sends the forum topic link (example: https://www.onekite.com/topic/16024/test-discord)
+- First line is the raw URL, then a Markdown clickable link `[title](url)`
+- Still sends an embed (title clickable via embed.url) + fallback to plain content if embeds are rejected
 
-Discord message:
-- Notification content starts with the direct post URL
-- Includes an excerpt of the post content (truncated)
-- Keeps embed minimal + fallback to plain content if Discord rejects embeds
+ACP remains with the "disk" save button and NodeBB toast.

package/library.js

@@ -122,7 +122,7 @@ async function getPostExcerpt(pid) {
   try {
     const p = await posts.getPostFields(pid, ['content']);
     const text = stripHtml(p && p.content);
-    return truncate(text, 350);
+    return truncate(text, 500);
   } catch {
     return '';
   }
@@ -134,33 +134,32 @@ async function buildPayload({ tid, pid, isReply }) {
   const topicData = await topics.getTopicFields(tid, ['tid', 'uid', 'cid', 'title', 'slug', 'mainPid']);
   if (!topicData) return null;
 
+  // Always build the forum link like the example: https://www.onekite.com/topic/<tid or slug>
   const topicUrl = ensureAbsoluteUrl(baseUrl, `/topic/${topicData.slug || topicData.tid}`);
-  const postUrl = isReply && pid ? `${topicUrl}/${pid}` : `${topicUrl}/${topicData.mainPid || ''}`.replace(/\/$/, '');
+
+  // For replies, link directly to the post if possible
+  const postUrl = (isReply && pid) ? `${topicUrl}/${pid}` : topicUrl;
 
   const u = await user.getUserFields(topicData.uid, ['username']);
   const title = (topicData.title || (isReply ? 'Nouvelle réponse' : 'Nouveau sujet')).toString().slice(0, 256);
   const authorName = (u && u.username ? String(u.username) : 'Utilisateur').slice(0, 256);
 
   const excerpt = await getPostExcerpt(isReply ? pid : topicData.mainPid);
-  const description = truncate(excerpt || (isReply ? `Réponse de ${authorName}` : `Sujet créé par ${authorName}`), 350);
+  const description = truncate(excerpt || (isReply ? `Réponse de ${authorName}` : `Sujet créé par ${authorName}`), 500);
 
+  // Minimal embed but with URL so the title is clickable
   const embed = {
     title,
     description,
   };
+  if (isValidHttpUrl(postUrl)) embed.url = postUrl;
 
-  if (isValidHttpUrl(postUrl)) {
-    embed.url = postUrl;
-  }
-
-  // "Lien vers le message directement en début de notification"
-  const contentLines = [
-    postUrl,
-    isReply ? `🗨️ Nouvelle réponse : ${title}` : `🆕 Nouveau sujet : ${title}`,
-  ];
-  if (description) contentLines.push(description);
-
-  const content = contentLines.join('\n');
+  // Ensure the message is clickable: markdown link + also raw URL in first line
+  const content = [
+    postUrl,  // raw URL first line
+    isReply ? `🗨️ Nouvelle réponse : [${title}](${postUrl})` : `🆕 Nouveau sujet : [${title}](${topicUrl})`,
+    description ? description : '',
+  ].filter(Boolean).join('\n');
 
   return { topicData, embed, content };
 }
@@ -222,7 +221,8 @@ Plugin.onTopicPost = async (data) => {
 
   if (!cidAllowed(built.topicData.cid, settings.cids)) return;
 
-  await sendDiscord(settings.webhookUrl, { embeds: [built.embed] }, built.content);
+  // Send content + embed (content ensures clickable link always)
+  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] }, built.content);
 };
 
 Plugin.onTopicReply = async (data) => {
@@ -240,7 +240,7 @@ Plugin.onTopicReply = async (data) => {
 
   if (!cidAllowed(built.topicData.cid, settings.cids)) return;
 
-  await sendDiscord(settings.webhookUrl, { embeds: [built.embed] }, built.content);
+  await sendDiscord(settings.webhookUrl, { content: built.content, embeds: [built.embed] }, built.content);
 };
 
 module.exports = Plugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.14",
+  "version": "1.0.15",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",