nodebb-plugin-discord-onekite 1.0.12 → 1.0.13

package/README.md

@@ -1,5 +1,8 @@
-# nodebb-plugin-discord-onekite v1.1.1
+# nodebb-plugin-discord-onekite v1.1.2
 
-Fix:
-- Makes embeds ultra-minimal (title/description/url only).
-- On Discord 400 embed validation error, retries with plain `content` so a notification is always delivered.
+Fix build error:
+- Removed `acpScripts` and instead provides a proper AMD admin module via `modules` mapping.
+This avoids RequireJS build failures.
+
+- Toast "classique NodeBB" via app.alertSuccess when `?saved=1`.
+- Discord notifications: minimal embed + fallback to plain content if Discord rejects embed.

package/library.js

@@ -83,8 +83,6 @@ async function sendDiscord(webhookUrl, payload, fallbackContent) {
   try {
     await postToDiscord(webhookUrl, payload);
   } catch (e) {
-    // Discord embed validation error is commonly 400 with {"embeds":["0"]}
-    // Retry with plain content so notifications still arrive.
     if (e && e.statusCode === 400 && fallbackContent) {
       try {
         await postToDiscord(webhookUrl, { content: fallbackContent });
@@ -109,11 +107,9 @@ async function buildPayload({ tid, pid, isReply }) {
   const url = isReply && pid ? `${topicUrl}/${pid}` : topicUrl;
 
   const u = await user.getUserFields(topicData.uid, ['username']);
-
   const title = (topicData.title || (isReply ? 'Nouvelle réponse' : 'Nouveau sujet')).toString().slice(0, 256);
   const authorName = (u && u.username ? String(u.username) : 'Utilisateur').slice(0, 256);
 
-  // Super-minimal embed to avoid Discord rejecting unknown/invalid fields.
   const embed = {
     title,
     description: isReply ? `Réponse de **${authorName}**` : `Sujet créé par **${authorName}**`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-discord-onekite",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "Discord webhook notifier for Onekite (NodeBB v4.x only)",
   "main": "library.js",
   "license": "MIT",

package/plugin.json

@@ -22,7 +22,7 @@
     }
   ],
   "templates": "templates",
-  "acpScripts": [
-    "static/lib/acp-toast.js"
-  ]
+  "modules": {
+    "../admin/plugins/discord-onekite.js": "static/lib/admin.js"
+  }
 }

package/static/lib/{acp-toast.js → admin.js}

@@ -1,10 +1,10 @@
 'use strict';
-/* global $, app, ajaxify */
+/* global app */
 
-(function () {
-  function showToastIfSaved() {
-    if (!ajaxify || !ajaxify.data || ajaxify.data.template !== 'admin/plugins/discord-onekite') return;
+define('admin/plugins/discord-onekite', [], function () {
+  const ACP = {};
 
+  function toastIfSaved() {
     try {
       const url = new URL(window.location.href);
       const saved = url.searchParams.get('saved');
@@ -15,9 +15,14 @@
         url.searchParams.delete('saved');
         window.history.replaceState({}, document.title, url.toString());
       }
-    } catch (e) {}
+    } catch (e) {
+      // ignore
+    }
   }
 
-  $(window).on('action:ajaxify.end', showToastIfSaved);
-  $(showToastIfSaved);
-})();
+  ACP.init = function () {
+    toastIfSaved();
+  };
+
+  return ACP;
+});

package/templates/admin/plugins/discord-onekite.tpl

@@ -1,15 +1,9 @@
 <div class="acp-page-container">
   <h4>Discord Onekite</h4>
   <p class="text-muted">
-    Notifications Discord via webhook (rendu serveur).
+    Notifications Discord via webhook.
   </p>
 
-  <!-- IF saved -->
-  <div class="alert alert-success" role="alert">
-    Paramètres enregistrés !
-  </div>
-  <!-- ENDIF saved -->
-
   <form role="form" method="post" action="/admin/plugins/discord-onekite/save">
     <input type="hidden" name="_csrf" value="{config.csrf_token}" />
 
@@ -39,4 +33,10 @@
 
     <button type="submit" class="btn btn-primary">Enregistrer</button>
   </form>
+
+  <noscript>
+    <!-- IF saved -->
+    <div class="alert alert-success mt-3" role="alert">Paramètres enregistrés !</div>
+    <!-- ENDIF saved -->
+  </noscript>
 </div>