nodebb-plugin-composer-default 10.2.50 → 10.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-composer-default",
-  "version": "10.2.50",
+  "version": "10.3.0",
   "description": "Default composer for NodeBB",
   "main": "library.js",
   "repository": {
@@ -26,7 +26,7 @@
   },
   "readmeFilename": "README.md",
   "nbbpm": {
-    "compatibility": "^4.0.0"
+    "compatibility": "^4.5.0"
   },
   "dependencies": {
     "screenfull": "^5.0.2",

package/static/lib/composer/drafts.js

@@ -41,7 +41,6 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 		});
 
 		drafts.migrateGuest();
-		drafts.migrateThumbs(...arguments);
 	};
 
 	function getStorage(uid) {
@@ -100,6 +99,7 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 					draftData.tags = tags;
 					draftData.title = title;
 					draftData.cid = postData.cid;
+					draftData.thumbs = postData.thumbs || [];
 				} else if (postData.action === 'posts.reply') {
 					// new reply only
 					draftData.title = postData.title;
@@ -108,6 +108,7 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 				} else if (postData.action === 'posts.edit') {
 					draftData.pid = postData.pid;
 					draftData.title = title || postData.title;
+					draftData.thumbs = postData.thumbs || [];
 				}
 				if (!app.user.uid) {
 					draftData.handle = postContainer.find('input.handle').val();
@@ -208,26 +209,6 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 		}
 	};
 
-	drafts.migrateThumbs = function (postContainer, postData) {
-		if (!app.uid) {
-			return;
-		}
-
-		// If any thumbs were uploaded, migrate them to this new composer's uuid
-		const newUUID = postContainer.attr('data-uuid');
-		const draft = drafts.get(postData.save_id);
-
-		if (draft && draft.uuid) {
-			api.put(`/topics/${draft.uuid}/thumbs`, {
-				tid: newUUID,
-			}).then(() => {
-				require(['composer'], function (composer) {
-					composer.updateThumbCount(newUUID, postContainer);
-				});
-			});
-		}
-	};
-
 	drafts.listAvailable = function () {
 		const available = drafts.getList('available');
 		return available.map(drafts.get).filter(Boolean);
@@ -286,6 +267,7 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 					title: utils.escapeHTML(draft.title),
 					body: draft.text,
 					tags: String(draft.tags || '').split(','),
+					thumbs: draft.thumbs || [],
 				});
 			} else if (draft.action === 'posts.reply') {
 				api.get('/topics/' + draft.tid, {}, function (err, topicObj) {
@@ -307,6 +289,7 @@ define('composer/drafts', ['api', 'alerts'], function (api, alerts) {
 					pid: draft.pid,
 					title: draft.title ? utils.escapeHTML(draft.title) : undefined,
 					body: draft.text,
+					thumbs: draft.thumbs || [],
 				});
 			}
 		});

package/static/lib/composer/formatting.js

@@ -28,8 +28,8 @@ define('composer/formatting', [
 				const composerObj = composer.posts[uuid];
 
 				if (composerObj.action === 'topics.post' || (composerObj.action === 'posts.edit' && composerObj.isMain)) {
-					topicThumbs.modal.open({ id: uuid, pid: composerObj.pid }).then(() => {
-						postContainer.trigger('thumb.uploaded'); // toggle draft save
+					topicThumbs.modal.open({ id: uuid, postData: composerObj }).then(() => {
+						postContainer.trigger('thumb.uploaded');
 
 						// Update client-side with count
 						composer.updateThumbCount(uuid, postContainer);

package/static/lib/composer/uploads.js

@@ -19,7 +19,7 @@ define('composer/uploads', [
 		initializePaste(post_uuid);
 
 		addChangeHandlers(post_uuid);
-		addTopicThumbHandlers(post_uuid);
+
 		translator.translate('[[modules:composer.uploading, ' + 0 + '%]]', function (translated) {
 			uploadingText = translated;
 		});
@@ -37,36 +37,6 @@ define('composer/uploads', [
 		});
 	}
 
-	function addTopicThumbHandlers(post_uuid) {
-		var postContainer = $('.composer[data-uuid="' + post_uuid + '"]');
-
-		postContainer.on('click', '.topic-thumb-clear-btn', function (e) {
-			postContainer.find('input#topic-thumb-url').val('').trigger('change');
-			resetInputFile(postContainer.find('input#topic-thumb-file'));
-			$(this).addClass('hide');
-			e.preventDefault();
-		});
-
-		postContainer.on('paste change keypress', 'input#topic-thumb-url', function () {
-			var urlEl = $(this);
-			setTimeout(function () {
-				var url = urlEl.val();
-				if (url) {
-					postContainer.find('.topic-thumb-clear-btn').removeClass('hide');
-				} else {
-					resetInputFile(postContainer.find('input#topic-thumb-file'));
-					postContainer.find('.topic-thumb-clear-btn').addClass('hide');
-				}
-				postContainer.find('img.topic-thumb-preview').attr('src', url);
-			}, 100);
-		});
-	}
-
-	function resetInputFile($el) {
-		$el.wrap('<form />').closest('form').get(0).reset();
-		$el.unwrap();
-	}
-
 	function initializeDragAndDrop(post_uuid) {
 		var postContainer = $('.composer[data-uuid="' + post_uuid + '"]');
 		uploadHelpers.handleDragDrop({

package/static/lib/composer.js

@@ -201,6 +201,7 @@ define('composer', [
 			title: data.title || '',
 			body: data.body || '',
 			tags: data.tags || [],
+			thumbs: data.thumbs || [],
 			modified: !!((data.title && data.title.length) || (data.body && data.body.length)),
 			isMain: true,
 		};
@@ -417,7 +418,7 @@ define('composer', [
 		handleHelp(postContainer);
 		handleSearch(postContainer);
 		focusElements(postContainer);
-		if (postData.action === 'posts.edit') {
+		if (postData.action === 'posts.edit' || postData.action === 'topics.post') {
 			composer.updateThumbCount(post_uuid, postContainer);
 		}
 
@@ -736,6 +737,7 @@ define('composer', [
 				thumb: thumbEl.val() || '',
 				cid: categoryList.getSelectedCid(),
 				tags: tags.getTags(post_uuid),
+				thumbs: postData.thumbs || [],
 				timestamp: scheduler.getTimestamp(),
 			};
 		} else if (action === 'posts.reply') {
@@ -756,7 +758,7 @@ define('composer', [
 				handle: handleEl ? handleEl.val() : undefined,
 				content: bodyEl.val(),
 				title: titleEl.val(),
-				thumb: thumbEl.val() || '',
+				thumbs: postData.thumbs || [],
 				tags: tags.getTags(post_uuid),
 				timestamp: scheduler.getTimestamp(),
 			};
@@ -883,20 +885,12 @@ define('composer', [
 
 	composer.updateThumbCount = function (uuid, postContainer) {
 		const composerObj = composer.posts[uuid];
-		if (composerObj.action === 'topics.post' || (composerObj.action === 'posts.edit' && composerObj.isMain)) {
-			const calls = [
-				topicThumbs.get(uuid),
-			];
-			if (composerObj.pid) {
-				calls.push(topicThumbs.getByPid(composerObj.pid));
-			}
-			Promise.all(calls).then((thumbs) => {
-				const thumbCount = thumbs.flat().length;
-				const formatEl = postContainer.find('[data-format="thumbs"]');
-				formatEl.find('.badge')
-					.text(thumbCount)
-					.toggleClass('hidden', !thumbCount);
-			});
+		if (composerObj && (composerObj.action === 'topics.post' || (composerObj.action === 'posts.edit' && composerObj.isMain))) {
+			const thumbCount = composerObj.thumbs ? composerObj.thumbs.length : 0;
+			const formatEl = postContainer.find('[data-format="thumbs"]');
+			formatEl.find('.badge')
+				.text(thumbCount)
+				.toggleClass('hidden', !thumbCount);
 		}
 	};
 

package/static/templates/partials/composer-formatting.tpl

@@ -6,7 +6,7 @@
 			{{{ else }}}
 			{{{ if (./visibility.desktop && ((isTopicOrMain && ./visibility.main) || (!isTopicOrMain && ./visibility.reply))) }}}
 			{{{ if ./dropdownItems.length }}}
-			<li class="dropdown bottom-sheet" title="{./title}">
+			<li class="dropdown dropdown-left bottom-sheet" title="{./title}">
 				<button class="btn btn-sm btn-link text-reset" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false" aria-label="{./title}">
 					<i class="{./className}"></i>
 				</button>

package/websockets.js

@@ -19,9 +19,8 @@ Sockets.push = async function (socket, pid) {
 		throw new Error('[[error:invalid-pid]]');
 	}
 
-	const [topic, tags, isMain] = await Promise.all([
+	const [topic, isMain] = await Promise.all([
 		topics.getTopicDataByPid(pid),
-		topics.getTopicTags(postData.tid),
 		posts.isMain(pid),
 	]);
 
@@ -35,8 +34,8 @@ Sockets.push = async function (socket, pid) {
 		handle: parseInt(meta.config.allowGuestHandles, 10) ? postData.handle : undefined,
 		body: postData.sourceContent || postData.content,
 		title: topic.title,
-		thumb: topic.thumb,
-		tags: tags,
+		thumbs: topic.thumbs,
+		tags: topic.tags.map(t => t.value),
 		isMain: isMain,
 		timestamp: postData.timestamp,
 	});

package/.jshintrc

@@ -1,86 +0,0 @@
-{
-    // JSHint Default Configuration File (as on JSHint website)
-    // See http://jshint.com/docs/ for more details
-
-    "maxerr" : 50, // {int} Maximum error before stopping
-
-    // Enforcing
-    "bitwise" : true, // true: Prohibit bitwise operators (&, |, ^, etc.)
-    "camelcase" : false, // true: Identifiers must be in camelCase
-    "curly" : true, // true: Require {} for every new block or scope
-    "eqeqeq" : true, // true: Require triple equals (===) for comparison
-    "forin" : true, // true: Require filtering for..in loops with obj.hasOwnProperty()
-    "immed" : false, // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());`
-    "indent" : 4, // {int} Number of spaces to use for indentation
-    "latedef" : false, // true: Require variables/functions to be defined before being used
-    "newcap" : false, // true: Require capitalization of all constructor functions e.g. `new F()`
-    "noarg" : true, // true: Prohibit use of `arguments.caller` and `arguments.callee`
-    "noempty" : true, // true: Prohibit use of empty blocks
-    "nonew" : false, // true: Prohibit use of constructors for side-effects (without assignment)
-    "plusplus" : false, // true: Prohibit use of `++` & `--`
-    "quotmark" : false, // Quotation mark consistency:
-                                // false : do nothing (default)
-                                // true : ensure whatever is used is consistent
-                                // "single" : require single quotes
-                                // "double" : require double quotes
-    "undef" : true, // true: Require all non-global variables to be declared (prevents global leaks)
-    "unused" : true, // true: Require all defined variables be used
-    "strict" : true, // true: Requires all functions run in ES5 Strict Mode
-    "trailing" : false, // true: Prohibit trailing whitespaces
-    "maxparams" : false, // {int} Max number of formal params allowed per function
-    "maxdepth" : false, // {int} Max depth of nested blocks (within functions)
-    "maxstatements" : false, // {int} Max number statements per function
-    "maxcomplexity" : false, // {int} Max cyclomatic complexity per function
-    "maxlen" : false, // {int} Max number of characters per line
-
-    // Relaxing
-    "asi" : false, // true: Tolerate Automatic Semicolon Insertion (no semicolons)
-    "boss" : false, // true: Tolerate assignments where comparisons would be expected
-    "debug" : false, // true: Allow debugger statements e.g. browser breakpoints.
-    "eqnull" : false, // true: Tolerate use of `== null`
-    "es5" : false, // true: Allow ES5 syntax (ex: getters and setters)
-    "esnext" : false, // true: Allow ES.next (ES6) syntax (ex: `const`)
-    "moz" : false, // true: Allow Mozilla specific syntax (extends and overrides esnext features)
-                                 // (ex: `for each`, multiple try/catch, function expression…)
-    "evil" : false, // true: Tolerate use of `eval` and `new Function()`
-    "expr" : false, // true: Tolerate `ExpressionStatement` as Programs
-    "funcscope" : false, // true: Tolerate defining variables inside control statements"
-    "globalstrict" : false, // true: Allow global "use strict" (also enables 'strict')
-    "iterator" : false, // true: Tolerate using the `__iterator__` property
-    "lastsemic" : false, // true: Tolerate omitting a semicolon for the last statement of a 1-line block
-    "laxbreak" : false, // true: Tolerate possibly unsafe line breakings
-    "laxcomma" : false, // true: Tolerate comma-first style coding
-    "loopfunc" : false, // true: Tolerate functions being defined in loops
-    "multistr" : false, // true: Tolerate multi-line strings
-    "proto" : false, // true: Tolerate using the `__proto__` property
-    "scripturl" : false, // true: Tolerate script-targeted URLs
-    "smarttabs" : false, // true: Tolerate mixed tabs/spaces when used for alignment
-    "shadow" : false, // true: Allows re-define variables later in code e.g. `var x=1; x=2;`
-    "sub" : false, // true: Tolerate using `[]` notation when it can still be expressed in dot notation
-    "supernew" : false, // true: Tolerate `new function () { ... };` and `new Object;`
-    "validthis" : false, // true: Tolerate using this in a non-constructor function
-
-    // Environments
-    "browser" : true, // Web Browser (window, document, etc)
-    "couch" : false, // CouchDB
-    "devel" : true, // Development/debugging (alert, confirm, etc)
-    "dojo" : false, // Dojo Toolkit
-    "jquery" : true, // jQuery
-    "mootools" : false, // MooTools
-    "node" : true, // Node.js
-    "nonstandard" : false, // Widely adopted globals (escape, unescape, etc)
-    "prototypejs" : false, // Prototype and Scriptaculous
-    "rhino" : false, // Rhino
-    "worker" : false, // Web Workers
-    "wsh" : false, // Windows Scripting Host
-    "yui" : false, // Yahoo User Interface
-
-    // Legacy
-    "nomen" : false, // true: Prohibit dangling `_` in variables
-    "onevar" : false, // true: Allow only one `var` statement per function
-    "passfail" : false, // true: Stop on first error
-    "white" : false, // true: Check against strict whitespace and indentation rules
-
-    // Custom Globals
-    "globals" : {} // additional predefined global variables
-}

package/static/lib/.eslintrc

@@ -1,6 +0,0 @@
-{
-	"extends": "nodebb/public",
-  "rules": {
-    "no-cond-assign": ["error", "except-parens"]
-  }
-}