nodebb-plugin-calendar-onekite 11.1.5 → 11.1.6

package/lib/helloasso.js

@@ -1,62 +1,170 @@
 'use strict';
 
-// Minimal HelloAsso wrapper placeholder.
-// Returns null payment url if not configured; does not throw to keep plugin stable.
+/**
+ * HelloAsso API helper (NodeBB v4 compatible, no external deps).
+ * Uses native https to avoid optional dependencies.
+ */
 
-const request = require('request-promise-native');
+const https = require('https');
+const { URL } = require('url');
 const Settings = require('./settings');
 
 function baseUrl(env) {
   return env === 'production' ? 'https://api.helloasso.com' : 'https://api.helloasso-sandbox.com';
 }
 
+function httpsRequest(method, urlString, headers = {}, body = undefined) {
+  return new Promise((resolve, reject) => {
+    const url = new URL(urlString);
+
+    const opts = {
+      method,
+      protocol: url.protocol,
+      hostname: url.hostname,
+      port: url.port || (url.protocol === 'https:' ? 443 : 80),
+      path: url.pathname + (url.search || ''),
+      headers: headers || {},
+    };
+
+    const req = https.request(opts, (res) => {
+      let data = '';
+      res.setEncoding('utf8');
+      res.on('data', (chunk) => { data += chunk; });
+      res.on('end', () => resolve({ status: res.statusCode, headers: res.headers, body: data }));
+    });
+
+    req.on('error', reject);
+
+    if (body !== undefined && body !== null) {
+      req.write(body);
+    }
+    req.end();
+  });
+}
+
 async function getAccessToken() {
   const s = await Settings.get();
-  if (!s.helloassoClientId || !s.helloassoClientSecret) return null;
-  const url = baseUrl(s.helloassoEnv) + '/oauth2/token';
+  if (!s.helloassoClientId || !s.helloassoClientSecret) {
+    return null;
+  }
+
+  const tokenUrl = `${baseUrl(s.helloassoEnv)}/oauth2/token`;
+  const form = new URLSearchParams({
+    grant_type: 'client_credentials',
+    client_id: String(s.helloassoClientId),
+    client_secret: String(s.helloassoClientSecret),
+  }).toString();
+
+  const res = await httpsRequest('POST', tokenUrl, {
+    'Content-Type': 'application/x-www-form-urlencoded',
+    'Content-Length': Buffer.byteLength(form),
+  }, form);
+
+  if (res.status < 200 || res.status >= 300) {
+    // Keep plugin stable: return null token and let caller show a helpful message
+    return null;
+  }
+
   try {
-    const resp = await request({
-      method: 'POST',
-      url,
-      form: {
-        grant_type: 'client_credentials',
-        client_id: s.helloassoClientId,
-        client_secret: s.helloassoClientSecret,
-      },
-      json: true,
-    });
-    return resp && resp.access_token;
-  } catch (e) {
+    const json = JSON.parse(res.body || '{}');
+    return json.access_token || null;
+  } catch {
     return null;
   }
 }
 
-async function createCheckoutIntent(amountCents, metadata) {
-  // This is a simplified implementation; returns null if token missing.
+async function apiJson(method, path, { query, body } = {}) {
   const s = await Settings.get();
   const token = await getAccessToken();
-  if (!token || !s.helloassoOrganizationSlug || !s.helloassoFormType || !s.helloassoFormSlug) return null;
+  if (!token) {
+    return null;
+  }
+
+  const url = new URL(`${baseUrl(s.helloassoEnv)}${path}`);
+  if (query && typeof query === 'object') {
+    Object.entries(query).forEach(([k, v]) => {
+      if (v !== undefined && v !== null && v !== '') {
+        url.searchParams.set(k, String(v));
+      }
+    });
+  }
 
-  const url = baseUrl(s.helloassoEnv) + `/v5/organizations/${encodeURIComponent(s.helloassoOrganizationSlug)}/forms/${encodeURIComponent(s.helloassoFormType)}/${encodeURIComponent(s.helloassoFormSlug)}/checkout-intents`;
+  const payload = body ? JSON.stringify(body) : undefined;
+  const headers = {
+    Authorization: `Bearer ${token}`,
+    Accept: 'application/json',
+  };
+  if (payload) {
+    headers['Content-Type'] = 'application/json';
+    headers['Content-Length'] = Buffer.byteLength(payload);
+  }
+
+  const res = await httpsRequest(method, url.toString(), headers, payload);
 
+  if (res.status < 200 || res.status >= 300) {
+    return null;
+  }
   try {
-    const resp = await request({
-      method: 'POST',
-      url,
-      headers: { Authorization: `Bearer ${token}` },
-      body: {
-        // NOTE: Real payload depends on HelloAsso form; this is a safe placeholder.
-        // If it fails, admin can still manually handle payment.
-        totalAmount: Math.round(amountCents) / 100,
-        metadata: metadata || {},
-        returnUrl: metadata && metadata.returnUrl ? metadata.returnUrl : undefined,
-      },
-      json: true,
-    });
-    return resp && (resp.redirectUrl || resp.checkoutUrl || resp.url);
-  } catch (e) {
+    return JSON.parse(res.body || '{}');
+  } catch {
+    return null;
+  }
+}
+
+async function listItems() {
+  const s = await Settings.get();
+  if (!s.helloassoOrganizationSlug || !s.helloassoFormType || !s.helloassoFormSlug) {
+    return [];
+  }
+
+  // Endpoint used by HelloAsso to list form items
+  const data = await apiJson('GET', `/v5/organizations/${encodeURIComponent(s.helloassoOrganizationSlug)}/${encodeURIComponent(s.helloassoFormType)}/${encodeURIComponent(s.helloassoFormSlug)}/items`);
+  if (!data) {
+    return [];
+  }
+
+  // Normalize (HelloAsso returns {items:[...]} in many responses; be defensive)
+  const items = Array.isArray(data.items) ? data.items : (Array.isArray(data.data) ? data.data : []);
+  return items.map((it) => ({
+    id: it.id ?? it.itemId ?? it.slug ?? it.name,
+    name: it.name ?? it.label ?? 'Item',
+    price: it.amount ?? it.price ?? it.unitPrice ?? 0,
+    raw: it,
+  }));
+}
+
+async function createCheckoutIntent({ itemId, quantity = 1, payer = {} }) {
+  const s = await Settings.get();
+  if (!s.helloassoOrganizationSlug) {
+    return null;
+  }
+
+  // Minimal payload; depending on your HelloAsso form, you might need to add more fields.
+  const payload = {
+    totalAmount: undefined, // let HelloAsso compute if supported
+    initialAmount: undefined,
+    items: [{
+      itemId,
+      quantity,
+    }],
+    payer: {
+      firstName: payer.firstName || '',
+      lastName: payer.lastName || '',
+      email: payer.email || '',
+    },
+    backUrl: s.helloassoBackUrl || '',
+    errorUrl: s.helloassoErrorUrl || '',
+    returnUrl: s.helloassoReturnUrl || '',
+  };
+
+  const data = await apiJson('POST', `/v5/organizations/${encodeURIComponent(s.helloassoOrganizationSlug)}/checkout-intents`, { body: payload });
+  if (!data) {
     return null;
   }
+  return data.redirectUrl || data.checkoutUrl || data.url || null;
 }
 
-module.exports = { createCheckoutIntent };
+module.exports = {
+  listItems,
+  createCheckoutIntent,
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-calendar-onekite",
-  "version": "11.1.5",
+  "version": "11.1.6",
   "description": "Reservation calendar with validation workflow and HelloAsso payment (OneKite)",
   "main": "library.js",
   "author": "OneKite",