nodebb-plugin-admin-chats 3.8.3 → 3.8.4

package/lib/overrides.js

@@ -51,7 +51,8 @@ function overrideCoreChatRedirect(controllers, renderAdminChatsPage) {
 // its messages from that user's join timestamp, so for a private room the
 // user is not in it comes out empty (title only). Send the viewer to a URL
 // that can actually show the room — their own chats page if they are in it,
-// otherwise the all-chats page.
+// otherwise the all-chats page. This includes the viewer's own slug: an admin
+// reading a room they are not in must stay on the all-chats page.
 function overrideCoreChatsPage(controllers) {
     const chatsController = controllers && controllers.accounts && controllers.accounts.chats;
     if (!chatsController || typeof chatsController.get !== 'function' || chatsController.get._adminChatsWrapped) {
@@ -64,7 +65,7 @@ function overrideCoreChatsPage(controllers) {
         const isSwitch = res.locals.isAPI && parseInt(req.query.switch, 10) === 1;
         if (roomId && !isSwitch && req.uid && await canAccessAdminChats(req.uid)) {
             const uid = await User.getUidByUserslug(req.params.userslug);
-            if (uid && parseInt(uid, 10) !== parseInt(req.uid, 10)) {
+            if (uid) {
                 const [room, isOwnerInRoom, isCallerInRoom] = await Promise.all([
                     Messaging.getRoomData(roomId),
                     isUserMemberOfRoom(uid, roomId),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nodebb-plugin-admin-chats",
-  "version": "3.8.3",
+  "version": "3.8.4",
   "description": "A plugin that allows the administrator to view and manage user chats.",
   "main": "library.js",
   "nbbpm": {

package/static/lib/switch-chat.js

@@ -215,6 +215,48 @@ $(document).ready(function () {
         });
     }
 
+    // Core's chat scroll handler (updateUrlWithMessageIndex) always rewrites the
+    // address to user/<viewer-slug>/chats/<roomId>/<index>. On the all-chats page
+    // the viewer is usually not in the room, and that URL renders the room from
+    // the viewer's (missing) join timestamp — so a reload/back landed on a room
+    // that could not scroll past the first batch. Keep the admin URL scheme.
+    function patchReplaceStateForAdminAll() {
+        if (!history.replaceState || history.replaceState._adminAllChatsPatched) {
+            return;
+        }
+
+        const originalReplaceState = history.replaceState;
+        const patchedReplaceState = function (state, title, url) {
+            const userslug = ajaxify && ajaxify.data && ajaxify.data.userslug;
+            if (isAdminAllChatsPage() && userslug && typeof url === 'string') {
+                const prefix = `${config.relative_path || ''}/user/${userslug}/chats/`;
+                const parsed = new URL(url, window.location.href);
+                // Non-ASCII slugs come back percent-encoded in URL#pathname
+                let pathname = parsed.pathname;
+                try {
+                    pathname = decodeURIComponent(pathname);
+                } catch (err) {
+                    // keep the raw pathname
+                }
+                const match = pathname.startsWith(prefix) &&
+                    pathname.slice(prefix.length).match(/^(\d+(?:\/\d+)?)$/);
+                if (match) {
+                    const newUrl = getAdminChatsPageUrl(match[1]);
+                    parsed.pathname = `${config.relative_path || ''}/${newUrl}`;
+                    url = parsed.href;
+                    if (state && typeof state.url === 'string') {
+                        state = { ...state, url: newUrl + parsed.search };
+                    }
+                }
+            }
+            return originalReplaceState.call(this, state, title, url);
+        };
+        patchedReplaceState._adminAllChatsPatched = true;
+        history.replaceState = patchedReplaceState;
+    }
+
+    patchReplaceStateForAdminAll();
+
     $(window).on('action:ajaxify.end', function (ev, data) {
         if (isAdminAllChatsPage()) {
             patchForumChatsForAdminAll();