node-web-audio-api 0.5.0 → 0.7.0

package/CHANGELOG.md

@@ -1,8 +1,25 @@
-## v0.4.0
+## v0.7.0
+
+- Improve readme & doc
+- Fix AudioParam method names
+- 
+
+## v0.6.0 - Feb 2023
+
+- Basic support for mediaDevices & MediaStreamAudioSourceNode
+- Add bindings to ConvolverNode, AnalyserNode & Panner nodes
+- Update upstream crate to v0.26
+
+## v0.5.0 - Dec 2022
+
+- Implement AudioParam#setValueCurveAtTime
+- Offline context constructor 
+
+## v0.4.0 - Nov 2022
 
 - Implement offline audio context
-- Update web-audio-api-rs to v0.24.0 
-- Implement `audio_node.disconnect()`
+- Update upstream crate to v0.24 
+- Implement AudioNode#disconnect
 - Properly support ESM
 - Limit number of online contexts to 1 on Linux
 - Force latencyHint to 'playback' if not manually set on RPi

package/README.md

@@ -1,6 +1,13 @@
-# `node-web-audio-api`
+# Node Web Audio API
 
-> Nodejs bindings for [`orottier/web-audio-api-rs`](https://github.com/orottier/web-audio-api-rs/) using [`napi-rs`](https://github.com/napi-rs/napi-rs/)
+[![npm version](https://badge.fury.io/js/node-web-audio-api.svg)](https://badge.fury.io/js/node-web-audio-api)
+
+Node.js bindings for the Rust implementation of the Web Audio API Specification
+
+- see [`orottier/web-audio-api-rs`](https://github.com/orottier/web-audio-api-rs/) for the "real" audio guts
+- use [`napi-rs`](https://github.com/napi-rs/napi-rs/) for the Node.js bindigs
+
+The goal of the library is to provide an implementation that is both efficient and _exactly_ matches the browsers' API.
 
 ## Install
 
@@ -8,10 +15,12 @@
 npm install [--save] node-web-audio-api
 ```
 
-## Example
+## Example Use
 
 ```js
 import { AudioContext, OscillatorNode, GainNode } from 'node-web-audio-api';
+// or using old fashionned commonjs syntax:
+// const { AudioContext, OscillatorNode, GainNode } = require('node-web-audio-api');
 
 const audioContext = new AudioContext();
 
@@ -33,54 +42,52 @@ setInterval(() => {
 }, 80);
 ```
 
-or using with old fashionned commonjs syntax
+### Running the Examples
 
-```js
-const { AudioContext, OscillatorNode, GainNode } = require('node-web-audio-api');
+To run all examples locally on your machine you will need to:
 
-const audioContext = new AudioContext();
-//...
+1. Install Rust toolchain
+```sh
+curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
 ```
 
-## Caveats
-
-- Currently the library does not provide any way of chosing the output interface, system default interface will be used. As the spec and web-audio-api evolve evolve, thus should change in the future see [https://github.com/orottier/web-audio-api-rs/issues/216](https://github.com/orottier/web-audio-api-rs/issues/216)
-- On Linux systems, the audio backend is Alsa, which limits the number of online
-AudioContext to 1. This is subject to change in the future.
-
-### Raspberry Pi
-
-On Raspberry Pi, the default render quantum size (128) is too small and underruns 
-occurs frequently. To prevent that, if you do not explicitely provide a latency hint
-in the AudioContext options, the value is automatically set to 'playback' which uses
-a buffer of 1024 samples. While this is not per se spec compliant, it allow usage
-of the library in a more user friendly manner. In the future, this might change according
-to the support of other audio backend, which is now alsa.
+2. Clone the repo and build the binary on your machine
+```sh
+git clone https://github.com/ircam-ismm/node-web-audio-api.git
+cd node-web-audio-api
+npm install
+npm run build
+```
 
-```js
-const audioContext = new AudioContext({ latencyHint: 'playback' });
+3. Run the examples from the project's root directory
+```sh
+node examples/granular-scrub.mjs
 ```
 
-The 'playback' latency hint, 1024 samples / ~21ms at 48000Hz, has been found 
-a good value.
+## Caveats
+
+- The async methods are not trully async for now and are just patched on the JS side. This will evolve once the "trully" async version of the methods are implemented in the upstream library.
+- On Linux systems, the audio backend is currently Alsa, which limits the number of online `AudioContext` to 1. This is subject to change in the future.
+- On Raspberry Pi, the default render quantum size (128) is too small and underruns occurs frequently. To prevent that, if you do not explicitely provide a latency hint in the AudioContext options, the value is automatically set to 'playback' which uses a buffer of 1024 samples (~21ms at 48000Hz). While this is not per se spec compliant, it allows usage of the library in a more user friendly manner. In the future, this might change according to the support of other audio backend.
+- On Raspberry Pi, the `Linux arm gnueabihf` binary provided only works on 32bit OS. We will provide a version for the 64 bit OS in the future.
 
 ## Supported Platforms
 
-|                            | binaries | tested |
-| ---------------------------| ------   | ------ |
-| Windows x64                | ✓        |        |
-| Windows arm64              | ✓        |        |
-| macOS x64                  | ✓        | ✓      |
-| macOS aarch64              | ✓        |        |
-| Linux x64 gnu              | ✓        |        |
-| Linux arm gnueabihf (RPi)  | ✓        | ✓      |
+|                              | binaries | tested |
+| ---------------------------  | ------   | ------ |
+| Windows x64                  | ✓        |        |
+| Windows arm64                | ✓        |        |
+| macOS x64                    | ✓        | ✓      |
+| macOS aarch64                | ✓        |        |
+| Linux x64 gnu                | ✓        |        |
+| Linux arm gnueabihf (RPi)    | ✓        | ✓      |
 
 
 ### Manual Build
 
 If prebuilt binaries are not shippped for your platform, you will need to:
 
-1. Install rust toolchain
+1. Install the Rust toolchain
 
 ```sh
 curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
@@ -94,19 +101,11 @@ cd node_modules/node-web-audio-api
 npm run build
 ```
 
-The package will then be built on your machine, which might take some time
-
-## Known limitation / caveats
-
-- async function are not trully async but only monkey patched on the JS side, this will
-be updated once `web-audio-api-rs` provide async version of the methods.
-- see `web-audio-api-rs`
+The package will be built on your machine, which might take some time
 
 ## Development notes
 
-The npm script rely on [`cargo-bump`](https://crates.io/crates/cargo-bump) to maintain version synced between
-the `package.json` and the `Cargo.toml` files. Therefore, you will need to install 
-`cargo-bump` on your machine
+The npm `postversion` script rely on [`cargo-bump`](https://crates.io/crates/cargo-bump) to maintain versions synced between the `package.json` and the `Cargo.toml` files. Therefore, you will need to install `cargo-bump` on your machine
 
 ```
 cargo install cargo-bump
@@ -114,4 +113,4 @@ cargo install cargo-bump
 
 ## License
 
-This project is licensed under the [BSD-3-Clause license](./LICENSE).
+[BSD-3-Clause](./LICENSE)

package/index.cjs

@@ -93,5 +93,23 @@ nativeBinding.AudioContext = patchAudioContext(nativeBinding.AudioContext);
 nativeBinding.OfflineAudioContext = patchOfflineAudioContext(nativeBinding.OfflineAudioContext);
 nativeBinding.load = load;
 
+// ------------------------------------------------------------------
+// monkey patch proto media devices API
+// @todo - review
+// ------------------------------------------------------------------
+class MediaStream extends nativeBinding.Microphone {};
+// const Microphone = nativeBinding.Microphone;
+nativeBinding.Microphone = null;
+
+nativeBinding.mediaDevices = {}
+nativeBinding.mediaDevices.getUserMedia = function getUserMedia(options) {
+    if (options && options.audio === true) {
+        const mic = new MediaStream();
+        return Promise.resolve(mic);
+    } else {
+        throw new NotSupportedError(`Only { audio: true } is currently supported`);
+    }
+}
+
 module.exports = nativeBinding;
 

package/index.mjs

@@ -17,21 +17,28 @@ export const {
   OfflineAudioContext,
   AudioBuffer,
   PeriodicWave,
+  // manually written nodes
+  MediaStreamAudioSourceNode,
   // generated supported nodes
+  AnalyserNode,
   AudioBufferSourceNode,
   BiquadFilterNode,
   ChannelMergerNode,
   ChannelSplitterNode,
   ConstantSourceNode,
+  ConvolverNode,
   DelayNode,
   DynamicsCompressorNode,
   GainNode,
   IIRFilterNode,
   OscillatorNode,
+  PannerNode,
   StereoPannerNode,
   WaveShaperNode,
+
   // helper methods
   load,
+  mediaDevices,
 } = nativeModule;
 
 export default nativeModule;

package/monkey-patch.js

@@ -121,15 +121,6 @@ function patchOfflineAudioContext(NativeOfflineAudioContext) {
       }
 
       super(...args);
-
-      // not sure this is usefull, to be tested
-      const keepAwakeId = setInterval(() => {}, 10000);
-      Object.defineProperty(this, '__keepAwakeId', {
-        value: keepAwakeId,
-        enumerable: false,
-        writable: true,
-        configurable: false,
-      });
     }
 
     // promisify sync APIs

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-web-audio-api",
-  "version": "0.5.0",
+  "version": "0.7.0",
   "author": "Benjamin Matuszewski",
   "description": "Node.js bindings for web-audio-api-rs using napi-rs",
   "exports": {
@@ -33,24 +33,26 @@
     "generate": "node generator/index.mjs && cargo fmt",
     "lint": "eslint monkey-patch.js index.cjs index.mjs && eslint examples/*.mjs",
     "preversion": "yarn install && npm run generate",
-    "postversion": "cargo bump $npm_package_version && git commit -am \"v$npm_package_version\""
+    "postversion": "cargo bump $npm_package_version && git commit -am \"v$npm_package_version\" && node bin/check-changelog.mjs"
   },
   "devDependencies": {
-    "@ircam/eslint-config": "^1.2.0",
-    "@sindresorhus/slugify": "^2.1.0",
-    "camelcase": "^6.3.0",
-    "chalk": "^5.0.1",
-    "dotenv": "^16.0.2",
-    "eslint": "^8.27.0",
+    "@ircam/eslint-config": "^1.3.0",
+    "@ircam/sc-gettime": "^1.0.0",
+    "@sindresorhus/slugify": "^2.1.1",
+    "camelcase": "^7.0.1",
+    "chalk": "^5.2.0",
+    "cli-table": "^0.3.11",
+    "dotenv": "^16.0.3",
+    "eslint": "^8.32.0",
     "node-ssh": "^13.0.0",
-    "octokit": "^2.0.7",
+    "octokit": "^2.0.11",
     "ping": "^0.4.2",
     "template-literal": "^1.0.4",
     "waves-masters": "^2.3.1",
     "webidl2": "^24.2.0"
   },
   "dependencies": {
-    "@napi-rs/cli": "^2.10.0",
+    "@napi-rs/cli": "^2.14.3",
     "@node-rs/helper": "^1.3.3"
   }
 }

package/simple-test.cjs

@@ -1,4 +1,4 @@
-const { AudioContext } = require('./index.js');
+const { AudioContext } = require('./index.cjs');
 
 const audioContext = new AudioContext();
 process.audioContext = audioContext;

package/tests/audio-buffer.mjs

@@ -0,0 +1,70 @@
+import { after, before, describe, it } from 'node:test';
+import assert from 'node:assert';
+
+import { AudioBuffer, AudioContext } from '../index.mjs';
+
+describe('AudioBuffer', () => {
+  let audioContext;
+
+  before(() => {
+    console.log('before is run')
+    audioContext = new AudioContext();
+  });
+
+  after(() => {
+    audioContext.close();
+  });
+
+  describe(`audioContext.createBuffer`, () => {
+    // it('should properly create audio buffer', () => {
+    //   const audioBuffer = audioContext.createBuffer(1, 100, audioContext.sampleRate);
+
+    //   assert.equal(audioBuffer.numberOfChannels, 1);
+    //   assert.equal(audioBuffer.length, 100);
+    //   assert.equal(audioBuffer.sampleRate, audioContext.sampleRate);
+    // });
+
+    // it('should properly fail if missing argument', () => {
+    //   assert.throws(() => {
+    //     const audioBuffer = audioContext.createBuffer(1, 100);
+    //   }, {
+    //     name: 'Error', // should be 'NotSupportedError'
+    //     message: 'AudioBuffer: Invalid options, sampleRate is required',
+    //   });
+    // });
+  });
+
+  describe(`new AudioBuffer(options)`, () => {
+    // it('should properly create audio buffer', () => {
+    //   const audioBuffer = new AudioBuffer({
+    //     length: 100,
+    //     sampleRate: audioContext.sampleRate,
+    //   });
+
+    //   assert.equal(audioBuffer.numberOfChannels, 1);
+    //   assert.equal(audioBuffer.length, 100);
+    //   assert.equal(audioBuffer.sampleRate, audioContext.sampleRate);
+    // });
+
+    // it('should properly fail if missing argument', () => {
+    //   assert.throws(() => {
+    //     const audioBuffer = new AudioBuffer({
+    //       length: 100,
+    //     });
+    //   }, {
+    //     name: 'Error', // should be 'NotSupportedError'
+    //     message: 'AudioBuffer: Invalid options, sampleRate is required',
+    //   });
+    // });
+
+    it(`should have type error`, () => {
+      try {
+        new AudioBuffer(Date, 42);
+      } catch (err) {
+        console.log(err.type)
+        console.log(err.name)
+        console.log(err.message)
+      }
+    });
+  });
+});

package/dummy.mjs

@@ -1,19 +0,0 @@
-import { AudioContext } from './index.mjs';
-
-const audioContext = new AudioContext();
-
-const now = audioContext.currentTime;
-
-const gain = audioContext.createGain();
-gain.gain.setValueAtTime(0, now);
-gain.connect(audioContext.destination);
-
-const src = audioContext.createOscillator();
-src.connect(gain);
-src.start();
-
-
-gain.gain.setValueCurveAtTime(new Float32Array([0, 1, 0]), now + 1, 2);
-// gain.gain.setValueCurveAtTime(new Float32Array([0, 1, 0]), now + 1, 2);
-
-gain.gain.linear(new Float32Array([0, 1, 0]), now + 1, 2);