node-web-audio-api 0.4.0 → 0.5.0

package/.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": "@ircam"
+}

package/dummy.mjs

@@ -0,0 +1,19 @@
+import { AudioContext } from './index.mjs';
+
+const audioContext = new AudioContext();
+
+const now = audioContext.currentTime;
+
+const gain = audioContext.createGain();
+gain.gain.setValueAtTime(0, now);
+gain.connect(audioContext.destination);
+
+const src = audioContext.createOscillator();
+src.connect(gain);
+src.start();
+
+
+gain.gain.setValueCurveAtTime(new Float32Array([0, 1, 0]), now + 1, 2);
+// gain.gain.setValueCurveAtTime(new Float32Array([0, 1, 0]), now + 1, 2);
+
+gain.gain.linear(new Float32Array([0, 1, 0]), now + 1, 2);

package/index.cjs

@@ -1,6 +1,3 @@
-const { existsSync, readFileSync } = require('fs');
-const { join } = require('path');
-
 const { platform, arch } = process;
 
 let nativeBinding = null;
@@ -13,67 +10,67 @@ switch (platform) {
         try {
           nativeBinding = require('./node-web-audio-api.win32-x64-msvc.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       case 'arm64':
         try {
           nativeBinding = require('./node-web-audio-api.win32-arm64-msvc.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       default:
         throw new Error(`Unsupported architecture on Windows: ${arch}`);
     }
-    break
+    break;
   case 'darwin':
     switch (arch) {
       case 'x64':
         try {
           nativeBinding = require('./node-web-audio-api.darwin-x64.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       case 'arm64':
         try {
           nativeBinding = require('./node-web-audio-api.darwin-arm64.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       default:
         throw new Error(`Unsupported architecture on macOS: ${arch}`);
     }
-    break
+    break;
   case 'linux':
     switch (arch) {
       case 'x64':
         try {
           nativeBinding = require('./node-web-audio-api.linux-x64-gnu.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       case 'arm64':
         try {
           nativeBinding = require('./node-web-audio-api.linux-arm64-gnu.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       case 'arm':
         try {
           nativeBinding = require('./node-web-audio-api.linux-arm-gnueabihf.node');
         } catch (e) {
-          loadError = e
+          loadError = e;
         }
-        break
+        break;
       default:
         throw new Error(`Unsupported architecture on Linux: ${arch}`);
     }
-    break
+    break;
   default:
     throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`);
 }

package/index.mjs

@@ -31,7 +31,7 @@ export const {
   StereoPannerNode,
   WaveShaperNode,
   // helper methods
-  load
+  load,
 } = nativeModule;
 
 export default nativeModule;

package/monkey-patch.js

@@ -4,6 +4,21 @@ const isPlainObject = function(obj) {
   return Object.prototype.toString.call(obj) === '[object Object]';
 };
 
+const isPositiveInt = function(n) {
+  return Number.isSafeInteger(n) && 0 < n;
+};
+
+const isPositiveNumber = function(n) {
+  return Number(n) === n && 0 < n;
+};
+
+class NotSupportedError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'NotSupportedError';
+  }
+}
+
 const { platform, arch } = process;
 let contextId = 0;
 
@@ -88,8 +103,24 @@ function patchAudioContext(NativeAudioContext) {
 function patchOfflineAudioContext(NativeOfflineAudioContext) {
   class OfflineAudioContext extends NativeOfflineAudioContext {
     constructor(...args) {
+      // handle initialisation with either an options object or a sequence of parameters
+      // https://webaudio.github.io/web-audio-api/#dom-offlineaudiocontext-constructor-contextoptions-contextoptions
+      if (typeof args[0] === 'object'
+          && 'numberOfChannels' in args[0] && 'length' in args[0] && 'sampleRate' in args[0]
+      ) {
+        const { numberOfChannels, length, sampleRate } = args[0];
+        args = [numberOfChannels, length, sampleRate];
+      }
+
+      if (!isPositiveInt(args[0])) {
+        throw new NotSupportedError(`Unsupported value for numberOfChannels: ${args[0]}`);
+      } else if (!isPositiveInt(args[1])) {
+        throw new NotSupportedError(`Unsupported value for length: ${args[1]}`);
+      } else if (!isPositiveNumber(args[2])) {
+        throw new NotSupportedError(`Unsupported value for sampleRate: ${args[2]}`);
+      }
+
       super(...args);
-      console.log(args);
 
       // not sure this is usefull, to be tested
       const keepAwakeId = setInterval(() => {}, 10000);
@@ -141,4 +172,4 @@ module.exports.load = function(path) {
   }
 
   return { path };
-}
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-web-audio-api",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "author": "Benjamin Matuszewski",
   "description": "Node.js bindings for web-audio-api-rs using napi-rs",
   "exports": {
@@ -31,14 +31,17 @@
     "build:debug": "npm run generate && napi build --platform",
     "check": "cargo fmt && cargo clippy",
     "generate": "node generator/index.mjs && cargo fmt",
+    "lint": "eslint monkey-patch.js index.cjs index.mjs && eslint examples/*.mjs",
     "preversion": "yarn install && npm run generate",
     "postversion": "cargo bump $npm_package_version && git commit -am \"v$npm_package_version\""
   },
   "devDependencies": {
+    "@ircam/eslint-config": "^1.2.0",
     "@sindresorhus/slugify": "^2.1.0",
-    "chalk": "^5.0.1",
     "camelcase": "^6.3.0",
+    "chalk": "^5.0.1",
     "dotenv": "^16.0.2",
+    "eslint": "^8.27.0",
     "node-ssh": "^13.0.0",
     "octokit": "^2.0.7",
     "ping": "^0.4.2",