node-web-audio-api 0.19.0 → 0.20.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## v0.20.0 (29/04/2024)
+
+- Update upstream crate to [v0.44.0](https://github.com/orottier/web-audio-api-rs/blob/main/CHANGELOG.md#version-0440-2024-04-22)
+- Implement ScriptProcessorNode
+- Fix memory leak introduced in v0.19.0
+- Improve events compliance
+
 ## v0.19.0 (17/04/2024)
 
 - Update upstream crate to [1.0.0-rc.5](https://github.com/orottier/web-audio-api-rs/blob/main/CHANGELOG.md#version-0430--100-rc5-2024-04-15)

package/TODOS.md

@@ -5,8 +5,17 @@
 - [x] decode audio data in dedicated thread
 - [x] Use node DOMExeption <https://nodejs.org/api/globals.html#domexception>
 - [x] connect / disconnect
-- [ ] _napi_ review tsfn store implementation
-- [ ] implement ScriptProcesorNode
+- [x] _napi_ review tsfn store implementation _or remove_
+- [x] implement ScriptProcesorNode _on going_
+- [x] _napi_ clean internal audio_buffer __internal_caller__, use JsNull instead
+- [x] Refactor Events:
+    + [x] extend Event for all specific event types
+    + [x] Register AudioScheduledSourceNode listener only on start
+    
+- [ ] reuse event objects across calls
+
+-> proxy EventListener
+    
 - [ ] wpt: mock for `URL.createObjectURL`
 - [ ] wpt: mock for `requestAnimationFrame` cf. https://github.com/nodejs/help/issues/2483
 - [ ] make sure we don't try to use `in` operator on null values
@@ -14,16 +23,29 @@
 - [ ] _rust_ AudioParam failing tests
 - [ ] _rust_ AudioBufferSourceNode failing tests
 - [ ] _rust_ IIRFilter node
-- [ ] Register AudioScheduledSourceNode listener only on start
+
 - [ ] refactor - Add context string in `throwSanitizedError` and to `toSanitizedSequence`
 - [ ] Rust - review Symbol.toStringTag https://github.com/nodejs/node/issues/41358
+      cf. https://github.com/nodejs/node/issues/41358#issuecomment-1003595890
 ```
-// symbol as property name example
-let test_symbol = ctx.env.symbol_for("test").unwrap();
-js_this.set_property(test_symbol, &ctx.env.create_string("test").unwrap())?;
+// fails...
+let symbols = ctx
+    .env
+    .get_global()?
+    .get_named_property::<JsUnknown>("Symbol")?
+    .coerce_to_object()?;
+let to_string_tag = symbols.get_named_property("toStringTag")?;
+
+js_this.set_property(to_string_tag, &ctx.env.create_string("AudioContext")?);
+
+// ----
+151 |     js_this.set_property(to_string_tag, &ctx.env.create_string("AudioContext")?);
+    |             ------------ ^^^^^^^^^^^^^ the trait `napi::NapiRaw` is not implemented for `()`
 ```
+
 - [ ] wpt bot
 - [ ] wpt - handle loading of 4-channels sound file
+
 - [ ] _rust_ decodeAudioData should throw EncodingError
       - review JS side when done
 
@@ -114,36 +136,8 @@ Startup { graph } => {
 
 ------------------------------------------------------------------------
 
-
-#### main
-```
-RESULTS:
-  - # pass: 6848
-  - # fail: 706
-  - # type error issues: 5
-> wpt duration: 2:22.697 (m:ss.mmm)
-```
-
-#### feat/ended-events
-```
-RESULTS:
-  - # pass: 6854
-  - # fail: 704
-  - # type error issues: 5
-> wpt duration: 2:08.718 (m:ss.mmm)
-```
-
-#### refactor/napi-wrappers
-
-w/ https://github.com/orottier/web-audio-api-rs/pull/492
-
-```
-RESULTS:
-  - # pass: 6897
-  - # fail: 692
-  - # type error issues: 5
-> wpt duration: 1:59.505 (m:ss.mmm)
-```
-
 ls wpt/webaudio/the-audio-api/the-audiocontext-interface | xargs -I {} ./run-wpt.sh {} 
 ls wpt/webaudio/the-audio-api/the-dynamicscompressornode-interface | xargs -I {} ./run-wpt.sh {} 
+
+
+971

package/index.mjs

@@ -27,6 +27,11 @@ const require = createRequire(import.meta.url);
 
 const nativeModule = require('./index.cjs');
 export const {
+  // events
+  OfflineAudioCompletionEvent,
+  AudioProcessingEvent,
+
+  // manually written nodes
   BaseAudioContext,
   AudioContext,
   OfflineAudioContext,
@@ -39,7 +44,8 @@ export const {
 
   PeriodicWave,
   AudioBuffer,
-  // generated supported nodes
+  // generated nodes
+  ScriptProcessorNode,
   AnalyserNode,
   AudioBufferSourceNode,
   BiquadFilterNode,

package/js/AnalyserNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/AudioBuffer.js

@@ -1,4 +1,4 @@
-const conversions = require("webidl-conversions");
+const conversions = require('webidl-conversions');
 
 const {
   throwSanitizedError,
@@ -9,7 +9,6 @@ const {
 } = require('./lib/utils.js');
 const {
   kNapiObj,
-  kAudioBuffer,
 } = require('./lib/symbols.js');
 
 
@@ -21,7 +20,7 @@ module.exports = (_jsExport, nativeBinding) => {
       }
 
       if (typeof options !== 'object') {
-        throw new TypeError("Failed to construct 'AudioBuffer': argument 1 is not of type 'AudioBufferOptions'");
+        throw new TypeError(`Failed to construct 'AudioBuffer': argument 1 is not of type 'AudioBufferOptions'`);
       }
 
       if (kNapiObj in options) {
@@ -82,7 +81,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     get sampleRate() {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       return this[kNapiObj].sampleRate;
@@ -90,7 +89,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     get duration() {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       return this[kNapiObj].duration;
@@ -98,7 +97,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     get length() {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       return this[kNapiObj].length;
@@ -106,7 +105,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     get numberOfChannels() {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       return this[kNapiObj].numberOfChannels;
@@ -114,7 +113,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     copyFromChannel(destination, channelNumber, bufferOffset = 0) {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       if (arguments.length < 2) {
@@ -149,7 +148,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     copyToChannel(source, channelNumber, bufferOffset = 0) {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       if (arguments.length < 2) {
@@ -184,7 +183,7 @@ module.exports = (_jsExport, nativeBinding) => {
 
     getChannelData(channel) {
       if (!(this instanceof AudioBuffer)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioBuffer'`);
       }
 
       if (arguments.length < 1) {
@@ -220,7 +219,7 @@ module.exports = (_jsExport, nativeBinding) => {
     },
   });
 
-  Object.defineProperties(AudioBuffer.prototype,  {
+  Object.defineProperties(AudioBuffer.prototype, {
     [Symbol.toStringTag]: {
       __proto__: null,
       writable: false,

package/js/AudioBufferSourceNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioScheduledSourceNode = require('./AudioScheduledSourceNode.js');
@@ -142,9 +139,6 @@ module.exports = (jsExport, nativeBinding) => {
         this[kAudioBuffer] = options.buffer;
       }
 
-      // Bridge Rust native event to Node EventTarget
-      bridgeEventTarget(this);
-
       this.#playbackRate = new jsExport.AudioParam({
         [kNapiObj]: this[kNapiObj].playbackRate,
       });

package/js/AudioContext.js

@@ -1,17 +1,19 @@
-const conversions = require("webidl-conversions");
+const conversions = require('webidl-conversions');
 
 const {
   throwSanitizedError,
 } = require('./lib/errors.js');
 const {
   isFunction,
-  kEnumerableProperty
+  kEnumerableProperty,
 } = require('./lib/utils.js');
 const {
   kNapiObj,
+  kOnStateChange,
+  kOnSinkChange,
 } = require('./lib/symbols.js');
 const {
-  bridgeEventTarget,
+  propagateEvent,
 } = require('./lib/events.js');
 
 let contextId = 0;
@@ -81,8 +83,29 @@ module.exports = function(jsExport, nativeBinding) {
         this.#sinkId = options.sinkId;
       }
 
-      // Bridge Rust native event to Node EventTarget
-      bridgeEventTarget(this);
+      // Add function to Napi object to bridge from Rust events to JS EventTarget
+      this[kNapiObj][kOnStateChange] = (err, rawEvent) => {
+        if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+          throw new TypeError('Invalid [kOnStateChange] Invocation: rawEvent should have a type property');
+        }
+
+        const event = new Event(rawEvent.type);
+        propagateEvent(this, event);
+      };
+
+      this[kNapiObj][kOnSinkChange] = (err, rawEvent) => {
+        if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+          throw new TypeError('Invalid [kOnSinkChange] Invocation: rawEvent should have a type property');
+        }
+
+        const event = new Event(rawEvent.type);
+        propagateEvent(this, event);
+      };
+
+      // Workaround to bind the `sinkchange` and `statechange` events to EventTarget.
+      // This must be called from JS facade ctor as the JS handler are added to the Napi
+      // object after its instantiation, and that we don't have any initial `resume` call.
+      this[kNapiObj].listen_to_events();
 
       // @todo - check if this is still required
       // prevent garbage collection and process exit

package/js/AudioDestinationNode.js

@@ -20,7 +20,7 @@ class AudioDestinationNode extends AudioNode {
 
   get maxChannelCount() {
     if (!(this instanceof AudioDestinationNode)) {
-      throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'AudioDestinationNode'");
+      throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'AudioDestinationNode'`);
     }
 
     return this[kNapiObj].maxChannelCount;

package/js/AudioListener.js

@@ -1,4 +1,4 @@
-const conversions = require("webidl-conversions");
+const conversions = require('webidl-conversions');
 
 const { throwSanitizedError } = require('./lib/errors.js');
 const { kEnumerableProperty, kHiddenProperty } = require('./lib/utils.js');
@@ -160,7 +160,7 @@ class AudioListener {
       context: `Failed to execute 'setOrientation' on 'AudioListener': The provided float value`,
     });
 
-    Z = conversions['float'](Z, {
+    z = conversions['float'](z, {
       context: `Failed to execute 'setOrientation' on 'AudioListener': The provided float value`,
     });
 

package/js/AudioScheduledSourceNode.js

@@ -3,12 +3,16 @@ const conversions = require('webidl-conversions');
 const {
   throwSanitizedError,
 } = require('./lib/errors.js');
+const {
+  propagateEvent,
+} = require('./lib/events.js');
 const {
   isFunction,
   kEnumerableProperty,
 } = require('./lib/utils.js');
 const {
   kNapiObj,
+  kOnEnded,
 } = require('./lib/symbols.js');
 
 const AudioNode = require('./AudioNode.js');
@@ -26,6 +30,17 @@ class AudioScheduledSourceNode extends AudioNode {
     }
 
     super(context, options);
+
+    // Add function to Napi object to bridge from Rust events to JS EventTarget
+    // It will be effectively registered on rust side when `start` is called
+    this[kNapiObj][kOnEnded] = (err, rawEvent) => {
+      if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+        throw new TypeError('Invalid [kOnEnded] Invocation: rawEvent should have a type property');
+      }
+
+      const event = new Event(rawEvent.type);
+      propagateEvent(this, event);
+    };
   }
 
   get onended() {

package/js/BaseAudioContext.js

@@ -210,6 +210,20 @@ module.exports = (jsExport, _nativeBinding) => {
     // --------------------------------------------------------------------
     // Factory Methods (use the patched AudioNodes)
     // --------------------------------------------------------------------
+    createScriptProcessor(bufferSize = 0, numberOfInputChannels = 2, numberOfOutputChannels = 2) {
+      if (!(this instanceof BaseAudioContext)) {
+        throw new TypeError('Invalid Invocation: Value of \'this\' must be of type \'BaseAudioContext\'');
+      }
+
+      const options = {
+        bufferSize,
+        numberOfInputChannels,
+        numberOfOutputChannels,
+      };
+
+      return new jsExport.ScriptProcessorNode(this, options);
+    }
+
     createAnalyser() {
       if (!(this instanceof BaseAudioContext)) {
         throw new TypeError('Invalid Invocation: Value of \'this\' must be of type \'BaseAudioContext\'');
@@ -389,6 +403,7 @@ module.exports = (jsExport, _nativeBinding) => {
       configurable: true,
       value: 'BaseAudioContext',
     },
+    createScriptProcessor: kEnumerableProperty,
     createAnalyser: kEnumerableProperty,
     createBufferSource: kEnumerableProperty,
     createBiquadFilter: kEnumerableProperty,

package/js/BiquadFilterNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/ChannelMergerNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/ChannelSplitterNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/ConstantSourceNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioScheduledSourceNode = require('./AudioScheduledSourceNode.js');
@@ -82,9 +79,6 @@ module.exports = (jsExport, nativeBinding) => {
         [kNapiObj]: napiObj,
       });
 
-      // Bridge Rust native event to Node EventTarget
-      bridgeEventTarget(this);
-
       this.#offset = new jsExport.AudioParam({
         [kNapiObj]: this[kNapiObj].offset,
       });

package/js/ConvolverNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/DelayNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/DynamicsCompressorNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/Events.js

@@ -0,0 +1,84 @@
+const { kEnumerableProperty } = require('./lib/utils.js');
+
+class OfflineAudioCompletionEvent extends Event {
+  #renderedBuffer = null;
+
+  constructor(type, eventInitDict) {
+    super(type);
+
+    if (typeof eventInitDict !== 'object' || eventInitDict === null || !('renderedBuffer' in eventInitDict)) {
+      throw TypeError(`Failed to construct 'OfflineAudioCompletionEvent': Failed to read the 'renderedBuffer' property from 'OfflineAudioCompletionEvent': Required member is undefined.`);
+    }
+
+    this.#renderedBuffer = eventInitDict.renderedBuffer;
+  }
+
+  get renderedBuffer() {
+    return this.#renderedBuffer;
+  }
+}
+
+Object.defineProperties(OfflineAudioCompletionEvent.prototype, {
+  [Symbol.toStringTag]: {
+    __proto__: null,
+    writable: false,
+    enumerable: false,
+    configurable: true,
+    value: 'OfflineAudioCompletionEvent',
+  },
+
+  renderedBuffer: kEnumerableProperty,
+});
+
+class AudioProcessingEvent extends Event {
+  #playbackTime = null;
+  #inputBuffer = null;
+  #outputBuffer = null;
+
+  constructor(type, eventInitDict) {
+    if (
+      typeof eventInitDict !== 'object'
+      || eventInitDict === null
+      || !('playbackTime' in eventInitDict)
+      || !('inputBuffer' in eventInitDict)
+      || !('outputBuffer' in eventInitDict)
+    ) {
+      throw TypeError(`Failed to construct 'AudioProcessingEvent': Invalid 'AudioProcessingEventInit' given`);
+    }
+
+    super(type);
+
+    this.#playbackTime = eventInitDict.playbackTime;
+    this.#inputBuffer = eventInitDict.inputBuffer;
+    this.#outputBuffer = eventInitDict.outputBuffer;
+  }
+
+  get playbackTime() {
+    return this.#playbackTime;
+  }
+
+  get inputBuffer() {
+    return this.#inputBuffer;
+  }
+
+  get outputBuffer() {
+    return this.#outputBuffer;
+  }
+}
+
+Object.defineProperties(AudioProcessingEvent.prototype, {
+  [Symbol.toStringTag]: {
+    __proto__: null,
+    writable: false,
+    enumerable: false,
+    configurable: true,
+    value: 'AudioProcessingEvent',
+  },
+
+  playbackTime: kEnumerableProperty,
+  inputBuffer: kEnumerableProperty,
+  outputBuffer: kEnumerableProperty,
+});
+
+module.exports.OfflineAudioCompletionEvent = OfflineAudioCompletionEvent;
+module.exports.AudioProcessingEvent = AudioProcessingEvent;

package/js/GainNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/IIRFilterNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/MediaStreamAudioSourceNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/OfflineAudioContext.js

@@ -1,7 +1,7 @@
 const conversions = require('webidl-conversions');
 
 const {
-  bridgeEventTarget,
+  propagateEvent,
 } = require('./lib/events.js');
 const {
   throwSanitizedError,
@@ -11,19 +11,15 @@ const {
   kEnumerableProperty,
 } = require('./lib/utils.js');
 const {
-  kNapiObj
+  kNapiObj,
+  kOnStateChange,
+  kOnComplete,
 } = require('./lib/symbols.js');
 
-// constructor(OfflineAudioContextOptions contextOptions);
-// constructor(unsigned long numberOfChannels, unsigned long length, float sampleRate);
-// Promise<AudioBuffer> startRendering();
-// Promise<undefined> resume();
-// Promise<undefined> suspend(double suspendTime);
-// readonly attribute unsigned long length;
-// attribute EventHandler oncomplete;
-
 module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
   class OfflineAudioContext extends jsExport.BaseAudioContext {
+    #renderedBuffer = null;
+
     constructor(...args) {
       if (arguments.length < 1) {
         throw new TypeError(`Failed to construct 'OfflineAudioContext': 1 argument required, but only ${arguments.length} present`);
@@ -52,7 +48,7 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
         args = [
           options.numberOfChannels,
           options.length,
-          options.sampleRate
+          options.sampleRate,
         ];
       }
 
@@ -60,16 +56,16 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
 
       numberOfChannels = conversions['unsigned long'](numberOfChannels, {
         enforceRange: true,
-        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'numberOfChannels' property from OfflineContextOptions; The provided value (${numberOfChannels})`
+        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'numberOfChannels' property from OfflineContextOptions; The provided value (${numberOfChannels})`,
       });
 
       length = conversions['unsigned long'](length, {
         enforceRange: true,
-        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'length' property from OfflineContextOptions; The provided value (${length})`
+        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'length' property from OfflineContextOptions; The provided value (${length})`,
       });
 
       sampleRate = conversions['float'](sampleRate, {
-        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'sampleRate' property from OfflineContextOptions; The provided value (${sampleRate})`
+        context: `Failed to construct 'OfflineAudioContext': Failed to read the 'sampleRate' property from OfflineContextOptions; The provided value (${sampleRate})`,
       });
 
       let napiObj;
@@ -81,11 +77,41 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
       }
 
       super({ [kNapiObj]: napiObj });
+
+      // Add function to Napi object to bridge from Rust events to JS EventTarget
+      // They will be effectively registered on rust side when `startRendering` is called
+      this[kNapiObj][kOnStateChange] = (err, rawEvent) => {
+        if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+          throw new TypeError('Invalid [kOnStateChange] Invocation: rawEvent should have a type property');
+        }
+
+        const event = new Event(rawEvent.type);
+        propagateEvent(this, event);
+      };
+
+      // This event is, per spec, the last trigerred one
+      this[kNapiObj][kOnComplete] = (err, rawEvent) => {
+        if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+          throw new TypeError('Invalid [kOnComplete] Invocation: rawEvent should have a type property');
+        }
+
+        // @fixme: workaround the fact that this event seems to be triggered before
+        // startRendering fulfills and that we want to return the exact same instance
+        if (this.#renderedBuffer === null) {
+          this.#renderedBuffer = new jsExport.AudioBuffer({ [kNapiObj]: rawEvent.renderedBuffer });
+        }
+
+        const event = new jsExport.OfflineAudioCompletionEvent(rawEvent.type, {
+          renderedBuffer: this.#renderedBuffer,
+        });
+
+        propagateEvent(this, event);
+      };
     }
 
     get length() {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
       return this[kNapiObj].length;
@@ -93,7 +119,7 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
 
     get oncomplete() {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
       return this._complete || null;
@@ -101,7 +127,7 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
 
     set oncomplete(value) {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
       if (isFunction(value) || value === null) {
@@ -111,12 +137,9 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
 
     async startRendering() {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
-      // Lazily register event callback on rust side
-      bridgeEventTarget(this);
-
       let nativeAudioBuffer;
 
       try {
@@ -125,26 +148,18 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
         throwSanitizedError(err);
       }
 
-      const audioBuffer = new jsExport.AudioBuffer({ [kNapiObj]: nativeAudioBuffer });
-
-      // We dispatch the complete event manually to simplify the sharing of the
-      // `AudioBuffer` instance. This also simplifies code on the rust side as
-      // we don't need to deal with the `OfflineAudioCompletionEvent` type.
-      const event = new Event('complete');
-      event.renderedBuffer = audioBuffer;
-
-      if (isFunction(this[`oncomplete`])) {
-        this[`oncomplete`](event);
+      // @fixme: workaround the fact that this event seems to be triggered before
+      // startRendering fulfills and that we want to return the exact same instance
+      if (this.#renderedBuffer === null) {
+        this.#renderedBuffer = new jsExport.AudioBuffer({ [kNapiObj]: nativeAudioBuffer });
       }
 
-      this.dispatchEvent(event);
-
-      return audioBuffer;
+      return this.#renderedBuffer;
     }
 
     async resume() {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
       try {
@@ -156,7 +171,7 @@ module.exports = function patchOfflineAudioContext(jsExport, nativeBinding) {
 
     async suspend(suspendTime) {
       if (!(this instanceof OfflineAudioContext)) {
-        throw new TypeError("Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'");
+        throw new TypeError(`Invalid Invocation: Value of 'this' must be of type 'OfflineAudioContext'`);
       }
 
       if (arguments.length < 1) {

package/js/OscillatorNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioScheduledSourceNode = require('./AudioScheduledSourceNode.js');
@@ -140,9 +137,6 @@ module.exports = (jsExport, nativeBinding) => {
         [kNapiObj]: napiObj,
       });
 
-      // Bridge Rust native event to Node EventTarget
-      bridgeEventTarget(this);
-
       this.#frequency = new jsExport.AudioParam({
         [kNapiObj]: this[kNapiObj].frequency,
       });

package/js/PannerNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/ScriptProcessorNode.js

@@ -0,0 +1,179 @@
+/* eslint-disable no-unused-vars */
+const conversions = require('webidl-conversions');
+const {
+  toSanitizedSequence,
+} = require('./lib/cast.js');
+const {
+  isFunction,
+  kEnumerableProperty,
+} = require('./lib/utils.js');
+const {
+  throwSanitizedError,
+} = require('./lib/errors.js');
+const {
+  kNapiObj,
+  kAudioBuffer,
+  kOnAudioProcess,
+} = require('./lib/symbols.js');
+const {
+  propagateEvent,
+} = require('./lib/events.js');
+/* eslint-enable no-unused-vars */
+
+const AudioNode = require('./AudioNode.js');
+
+module.exports = (jsExport, nativeBinding) => {
+  class ScriptProcessorNode extends AudioNode {
+
+    #onaudioprocess = null;
+
+    constructor(context, options) {
+
+      if (arguments.length < 1) {
+        throw new TypeError(`Failed to construct 'ScriptProcessorNode': 1 argument required, but only ${arguments.length} present`);
+      }
+
+      if (!(context instanceof jsExport.BaseAudioContext)) {
+        throw new TypeError(`Failed to construct 'ScriptProcessorNode': argument 1 is not of type BaseAudioContext`);
+      }
+
+      // parsed version of the option to be passed to NAPI
+      const parsedOptions = {};
+
+      if (options && typeof options !== 'object') {
+        throw new TypeError('Failed to construct \'ScriptProcessorNode\': argument 2 is not of type \'ScriptProcessorNodeOptions\'');
+      }
+
+      // IDL defines bufferSize default value as 0
+      // cf. https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-createscriptprocessor
+      // > If it’s not passed in, or if the value is 0, then the implementation
+      // > will choose the best buffer size for the given environment, which will
+      // > be constant power of 2 throughout the lifetime of the node.
+      if (options && options.bufferSize !== undefined && options.bufferSize !== 0) {
+        parsedOptions.bufferSize = conversions['unsigned long'](options.bufferSize, {
+          enforceRange: true,
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'bufferSize' property from ScriptProcessorNodeOptions: The provided value '${options.bufferSize}'`,
+        });
+      } else {
+        parsedOptions.bufferSize = 256;
+      }
+
+      if (options && options.numberOfInputChannels !== undefined) {
+        parsedOptions.numberOfInputChannels = conversions['unsigned long'](options.numberOfInputChannels, {
+          enforceRange: true,
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'numberOfInputChannels' property from ScriptProcessorNodeOptions: The provided value '${options.numberOfInputChannels}'`,
+        });
+      } else {
+        parsedOptions.numberOfInputChannels = 2;
+      }
+
+      if (options && options.numberOfOutputChannels !== undefined) {
+        parsedOptions.numberOfOutputChannels = conversions['unsigned long'](options.numberOfOutputChannels, {
+          enforceRange: true,
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'numberOfOutputChannels' property from ScriptProcessorNodeOptions: The provided value '${options.numberOfOutputChannels}'`,
+        });
+      } else {
+        parsedOptions.numberOfOutputChannels = 2;
+      }
+
+      if (options && options.channelCount !== undefined) {
+        parsedOptions.channelCount = conversions['unsigned long'](options.channelCount, {
+          enforceRange: true,
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'channelCount' property from ScriptProcessorNodeOptions: The provided value '${options.channelCount}'`,
+        });
+      }
+
+      if (options && options.channelCountMode !== undefined) {
+        parsedOptions.channelCountMode = conversions['DOMString'](options.channelCountMode, {
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'channelCount' property from ScriptProcessorNodeOptions: The provided value '${options.channelCountMode}'`,
+        });
+      }
+
+      if (options && options.channelInterpretation !== undefined) {
+        parsedOptions.channelInterpretation = conversions['DOMString'](options.channelInterpretation, {
+          context: `Failed to construct 'ScriptProcessorNode': Failed to read the 'channelInterpretation' property from ScriptProcessorNodeOptions: The provided value '${options.channelInterpretation}'`,
+        });
+      }
+
+      let napiObj;
+
+      try {
+        napiObj = new nativeBinding.ScriptProcessorNode(context[kNapiObj], parsedOptions);
+      } catch (err) {
+        throwSanitizedError(err);
+      }
+
+      super(context, {
+        [kNapiObj]: napiObj,
+      });
+
+      this[kNapiObj][kOnAudioProcess] = (err, rawEvent) => {
+        if (typeof rawEvent !== 'object' && !('type' in rawEvent)) {
+          throw new TypeError('Invalid [kOnStateChange] Invocation: rawEvent should have a type property');
+        }
+
+        const audioProcessingEventInit = {
+          playbackTime: rawEvent.playbackTime,
+          inputBuffer: new jsExport.AudioBuffer({ [kNapiObj]: rawEvent.inputBuffer }),
+          outputBuffer: new jsExport.AudioBuffer({ [kNapiObj]: rawEvent.outputBuffer }),
+        };
+
+        const event = new jsExport.AudioProcessingEvent('audioprocess', audioProcessingEventInit);
+        propagateEvent(this, event);
+      };
+
+      this[kNapiObj].listen_to_events();
+    }
+
+    get bufferSize() {
+      if (!(this instanceof ScriptProcessorNode)) {
+        throw new TypeError('Invalid Invocation: Value of \'this\' must be of type \'ScriptProcessorNode\'');
+      }
+
+      return this[kNapiObj].bufferSize;
+    }
+
+    get onaudioprocess() {
+      if (!(this instanceof ScriptProcessorNode)) {
+        throw new TypeError('Invalid Invocation: Value of \'this\' must be of type \'ScriptProcessorNode\'');
+      }
+
+      return this.#onaudioprocess;
+    }
+
+    set onaudioprocess(value) {
+      if (!(this instanceof ScriptProcessorNode)) {
+        throw new TypeError('Invalid Invocation: Value of \'this\' must be of type \'ScriptProcessorNode\'');
+      }
+
+      if (isFunction(value) || value === null) {
+        this.#onaudioprocess = value;
+      }
+    }
+  }
+
+  Object.defineProperties(ScriptProcessorNode, {
+    length: {
+      __proto__: null,
+      writable: false,
+      enumerable: false,
+      configurable: true,
+      value: 0,
+    },
+  });
+
+  Object.defineProperties(ScriptProcessorNode.prototype, {
+    [Symbol.toStringTag]: {
+      __proto__: null,
+      writable: false,
+      enumerable: false,
+      configurable: true,
+      value: 'ScriptProcessorNode',
+    },
+    bufferSize: kEnumerableProperty,
+    onaudioprocess: kEnumerableProperty,
+
+  });
+
+  return ScriptProcessorNode;
+};

package/js/StereoPannerNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/WaveShaperNode.js

@@ -33,9 +33,6 @@ const {
   kNapiObj,
   kAudioBuffer,
 } = require('./lib/symbols.js');
-const {
-  bridgeEventTarget,
-} = require('./lib/events.js');
 /* eslint-enable no-unused-vars */
 
 const AudioNode = require('./AudioNode.js');

package/js/lib/events.js

@@ -1,20 +1,10 @@
-const { kNapiObj, kDispatchEvent } = require('./symbols.js');
 const { isFunction } = require('./utils.js');
 
-/**
- * Listen for events from Rust, and bridge them to Node EventTarget paradigm
- */
-module.exports.bridgeEventTarget = function bridgeEventTarget(jsObj) {
-    // Finalize event registration on Rust side
-  jsObj[kNapiObj][kDispatchEvent] = (err, eventType) => {
-    const event = new Event(eventType);
-    // call attribute first if exists
-    if (isFunction(jsObj[`on${event.type}`])) {
-      jsObj[`on${event.type}`](event);
-    }
-    // then distach to add event listeners
-    jsObj.dispatchEvent(event);
+module.exports.propagateEvent = function propagateEvent(eventTarget, event) {
+  // call attribute first if exists
+  if (isFunction(eventTarget[`on${event.type}`])) {
+    eventTarget[`on${event.type}`](event);
   }
-  // ask Rust to register `kDispatchEvent` as listener
-  jsObj[kNapiObj].__initEventTarget__();
+  // then distach to add event listeners
+  eventTarget.dispatchEvent(event);
 }

package/js/lib/symbols.js

@@ -1,5 +1,20 @@
 module.exports.kNapiObj = Symbol('node-web-audio-api:napi-obj');
 module.exports.kAudioBuffer = Symbol('node-web-audio-api:audio-buffer');
-// this needs to be shared with Rust ide
-module.exports.kDispatchEvent = Symbol.for('node-web-audio-api:napi-dispatch-event');
+
+
+// semi-private keys for events listeners
+
+// # BaseAudioContext
+module.exports.kOnStateChange = Symbol.for('node-web-audio-api:onstatechange');
+// AudioContext
+module.exports.kOnSinkChange = Symbol.for('node-web-audio-api:onsinkchange');
+// # OfflineAudioContext
+// > [The onstatechange] event is fired before the complete event is fired
+// cf. https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-onstatechange
+// @fixme: for now the `complete` event is triggered **before** startRenring fulfills
+module.exports.kOnComplete = Symbol.for('node-web-audio-api:oncomplete');
+// # AudioScheduledSourceNode
+module.exports.kOnEnded = Symbol.for('node-web-audio-api:onended');
+// # ScriptProcessorNode
+module.exports.kOnAudioProcess = Symbol.for('node-web-audio-api:onaudioprocess');
 

package/js/monkey-patch.js

@@ -19,13 +19,20 @@
 
 module.exports = function monkeyPatch(nativeBinding) {
   let jsExport = {};
+
+  // --------------------------------------------------------------------------
+  // Events
+  // --------------------------------------------------------------------------
+  jsExport.OfflineAudioCompletionEvent = require('./Events').OfflineAudioCompletionEvent;
+  jsExport.AudioProcessingEvent = require('./Events').AudioProcessingEvent;
   // --------------------------------------------------------------------------
-  // Monkey Patch Web Audio API
+  // Create Web Audio API facade
   // --------------------------------------------------------------------------
   jsExport.BaseAudioContext = require('./BaseAudioContext.js')(jsExport, nativeBinding);
   jsExport.AudioContext = require('./AudioContext.js')(jsExport, nativeBinding);
   jsExport.OfflineAudioContext = require('./OfflineAudioContext.js')(jsExport, nativeBinding);
 
+  jsExport.ScriptProcessorNode = require('./ScriptProcessorNode.js')(jsExport, nativeBinding);
   jsExport.AnalyserNode = require('./AnalyserNode.js')(jsExport, nativeBinding);
   jsExport.AudioBufferSourceNode = require('./AudioBufferSourceNode.js')(jsExport, nativeBinding);
   jsExport.BiquadFilterNode = require('./BiquadFilterNode.js')(jsExport, nativeBinding);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-web-audio-api",
-  "version": "0.19.0",
+  "version": "0.20.0",
   "author": "Benjamin Matuszewski",
   "description": "Node.js bindings for web-audio-api-rs using napi-rs",
   "exports": {