node-web-audio-api 0.17.0 → 0.18.0

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v0.18.0 (13/03/2024)
+
+- Fix `MediaStreamAudioSourceNode`
+
 ## v0.17.0 (08/03/2024)
 
 - Update upstream crate to [1.0.0-rc.2](https://github.com/orottier/web-audio-api-rs/blob/main/CHANGELOG.md#version-100-rc2-2024-03-07)

package/TODOS.md

@@ -0,0 +1,21 @@
+# TODO
+
+- [ ] Review AudioBuffer
+- [ ] Ended event in AudioScheduledSourceNode for offline audio context
+- [ ] `MediaStreamAudioSourceNode` 
+    + [x] properly handle `mediaStream`
+    + [ ] do not accept OfflineAudioContext (see if this can be delegated to upstream)
+
+- [ ] wpt bot
+
+- [ ] OfflineAudioContext should not lock the process w/ event listeners if startRendering has not been called
+  
+- [ ] wrap EventTarget::dispatchEvent in setTimeout(callback , 0); so that events are dispatched in the next microtask ?
+
+
+## AudioBuffer notes
+
+- [x] `AudioBuffer` has to be a facade because `startRendering`, `decodeAudioData`
+- [x] need to adapt `AudioBufferSourceNode` and `ConvolverNode` so 
+that `set buffer(value)` retrieve the wrapped value
+- [ ] No fucking sound when buffer comes from `decodeAudioData`..., but ok when `createBuffer`

package/index.mjs

@@ -31,8 +31,6 @@ export const {
   AudioDestinationNode,
   AudioBuffer,
   PeriodicWave,
-  // manually written nodes
-  MediaStreamAudioSourceNode,
   // generated supported nodes
   AnalyserNode,
   AudioBufferSourceNode,
@@ -45,6 +43,7 @@ export const {
   DynamicsCompressorNode,
   GainNode,
   IIRFilterNode,
+  MediaStreamAudioSourceNode,
   OscillatorNode,
   PannerNode,
   StereoPannerNode,

package/js/BaseAudioContext.mixin.js

@@ -33,6 +33,7 @@ module.exports = (superclass, bindings) => {
     DynamicsCompressorNode,
     GainNode,
     IIRFilterNode,
+    MediaStreamAudioSourceNode,
     OscillatorNode,
     PannerNode,
     StereoPannerNode,
@@ -128,6 +129,7 @@ module.exports = (superclass, bindings) => {
       return new IIRFilterNode(this, options);
     }
 
+
     createOscillator() {
       return new OscillatorNode(this);
     }

package/js/MediaStreamAudioSourceNode.js

@@ -0,0 +1,59 @@
+// -------------------------------------------------------------------------- //
+// -------------------------------------------------------------------------- //
+//                                                                            //
+//                                                                            //
+//                                                                            //
+//    ██╗    ██╗ █████╗ ██████╗ ███╗   ██╗██╗███╗   ██╗ ██████╗               //
+//    ██║    ██║██╔══██╗██╔══██╗████╗  ██║██║████╗  ██║██╔════╝               //
+//    ██║ █╗ ██║███████║██████╔╝██╔██╗ ██║██║██╔██╗ ██║██║  ███╗              //
+//    ██║███╗██║██╔══██║██╔══██╗██║╚██╗██║██║██║╚██╗██║██║   ██║              //
+//    ╚███╔███╔╝██║  ██║██║  ██║██║ ╚████║██║██║ ╚████║╚██████╔╝              //
+//     ╚══╝╚══╝ ╚═╝  ╚═╝╚═╝  ╚═╝╚═╝  ╚═══╝╚═╝╚═╝  ╚═══╝ ╚═════╝               //
+//                                                                            //
+//                                                                            //
+//    - This file has been generated ---------------------------              //
+//                                                                            //
+//                                                                            //
+// -------------------------------------------------------------------------- //
+// -------------------------------------------------------------------------- //
+
+// eslint-disable-next-line no-unused-vars
+const { throwSanitizedError } = require('./lib/errors.js');
+// eslint-disable-next-line no-unused-vars
+const { AudioParam } = require('./AudioParam.js');
+const EventTargetMixin = require('./EventTarget.mixin.js');
+const AudioNodeMixin = require('./AudioNode.mixin.js');
+
+
+module.exports = (NativeMediaStreamAudioSourceNode) => {
+
+  const EventTarget = EventTargetMixin(NativeMediaStreamAudioSourceNode);
+  const AudioNode = AudioNodeMixin(EventTarget);
+
+  class MediaStreamAudioSourceNode extends AudioNode {
+    constructor(context, options) {
+      if (options !== undefined && typeof options !== 'object') {
+        throw new TypeError("Failed to construct 'MediaStreamAudioSourceNode': argument 2 is not of type 'MediaStreamAudioSourceOptions'")
+      }
+
+      super(context, options);
+
+    }
+
+    // getters
+
+    get mediaStream() {
+      return super.mediaStream;
+    }
+
+    // setters
+
+    // methods
+    
+  }
+
+  return MediaStreamAudioSourceNode;
+};
+
+
+  

package/js/OfflineAudioContext.js

@@ -13,10 +13,12 @@ module.exports = function patchOfflineAudioContext(bindings) {
     constructor(...args) {
       // handle initialisation with either an options object or a sequence of parameters
       // https://webaudio.github.io/web-audio-api/#dom-offlineaudiocontext-constructor-contextoptions-contextoptions
-      if (isPlainObject(args[0])
-          && 'numberOfChannels' in args[0] && 'length' in args[0] && 'sampleRate' in args[0]
+      if (isPlainObject(args[0]) && 'length' in args[0] && 'sampleRate' in args[0]
       ) {
-        const { numberOfChannels, length, sampleRate } = args[0];
+        let { numberOfChannels, length, sampleRate } = args[0];
+        if (numberOfChannels === undefined) {
+            numberOfChannels = 1;
+        }
         args = [numberOfChannels, length, sampleRate];
       }
 

package/js/monkey-patch.js

@@ -33,6 +33,7 @@ module.exports = function monkeyPatch(nativeBinding) {
   nativeBinding.DynamicsCompressorNode = require('./DynamicsCompressorNode.js')(nativeBinding.DynamicsCompressorNode);
   nativeBinding.GainNode = require('./GainNode.js')(nativeBinding.GainNode);
   nativeBinding.IIRFilterNode = require('./IIRFilterNode.js')(nativeBinding.IIRFilterNode);
+  nativeBinding.MediaStreamAudioSourceNode = require('./MediaStreamAudioSourceNode.js')(nativeBinding.MediaStreamAudioSourceNode);
   nativeBinding.OscillatorNode = require('./OscillatorNode.js')(nativeBinding.OscillatorNode);
   nativeBinding.PannerNode = require('./PannerNode.js')(nativeBinding.PannerNode);
   nativeBinding.StereoPannerNode = require('./StereoPannerNode.js')(nativeBinding.StereoPannerNode);

package/package.json

@@ -1,13 +1,16 @@
 {
   "name": "node-web-audio-api",
-  "version": "0.17.0",
+  "version": "0.18.0",
   "author": "Benjamin Matuszewski",
   "description": "Node.js bindings for web-audio-api-rs using napi-rs",
   "exports": {
     "import": "./index.mjs",
     "require": "./index.cjs"
   },
-  "repository": "https://github.com/ircam-ismm/node-web-audio-api",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ircam-ismm/node-web-audio-api.git"
+  },
   "license": "BSD-3-Clause",
   "keywords": [
     "audio",