node-tdd 5.0.0 → 5.1.0

package/lib/modules/request-recorder/apply-modifiers.js

@@ -9,9 +9,7 @@ export default (input, modifiers) => {
         const unknownModifiers = modifierNames
           .filter((n) => typeof modifiers[n] !== 'function');
         if (unknownModifiers.length !== 0) {
-          // eslint-disable-next-line no-console
-          console.warn(`Unknown Modifier(s) detected: ${unknownModifiers.join(', ')}`);
-          return;
+          throw new Error(`Unknown Modifier(s) detected: ${unknownModifiers.join(', ')}`);
         }
         // eslint-disable-next-line no-param-reassign
         delete parent[k];

package/lib/modules/request-recorder/request-injector.js

@@ -56,7 +56,9 @@ export default (() => {
     getLast: () => ({
       protocol: lastProtocol,
       options: lastOptions,
-      body: lastBody.length === 0 ? undefined : lastBody.join('')
+      body: lastBody.length !== 0 || ['POST', 'PUT', 'PATCH'].includes(lastOptions.method)
+        ? lastBody.join('')
+        : undefined
     })
   };
 })();

package/lib/modules/request-recorder.js

@@ -178,10 +178,9 @@ export default (opts) => {
             scope.filteringRequestBody = (body) => {
               if (anyFlagPresent(['magic', 'body'])) {
                 const idx = pendingMocks.findIndex((m) => m.idx === scopeIdx);
-                const requestBody = tryParseJson(body);
-                const requestBodyStr = nullAsString(requestBody);
-                if (!isEqual(scope.body, requestBodyStr)) {
-                  pendingMocks[idx].record.body = requestBodyStr;
+                const requestBody = nullAsString(tryParseJson(body));
+                if (!isEqual(scope.body, requestBody)) {
+                  pendingMocks[idx].record.body = requestBody;
                 }
                 return scope.body;
               }
@@ -215,6 +214,18 @@ export default (opts) => {
                 interceptor.delayBody(pendingMocks[idx].record.delayBody);
               }
 
+              const hasSentBody = requestBodyString !== undefined;
+              // eslint-disable-next-line no-underscore-dangle
+              const hasRecordBody = interceptor._requestBody !== undefined;
+              if (hasSentBody !== hasRecordBody) {
+                if (anyFlagPresent(['magic', 'body'])) {
+                  pendingMocks[idx].record.body = nullAsString(tryParseJson(requestBodyString));
+                } else {
+                  // eslint-disable-next-line no-param-reassign
+                  interceptor.errorMessage = 'Recording body mismatch';
+                }
+              }
+
               if (anyFlagPresent(['magic', 'headers'])) {
                 // add new headers
                 const reqheaders = {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "node-tdd",
   "type": "module",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "description": "Drop in extension for mocha to abstract commonly used test setups",
   "main": "lib/index.js",
   "scripts": {