node-red-contrib-velbus-2026 0.9.2 → 0.9.3

package/CHANGELOG_FORUM.md

@@ -14,6 +14,41 @@ All feedback via GitHub issues, with examples and debug captures where possible.
 
 ---
 
+## v0.9.3 — 09/07/2026
+
+### velbus-scan — VMBGPOD still showed "unknown_0x28" after the v0.9.2 fix
+
+- **Reported by Stuart:** re-ran a scan against v0.9.2 pulled fresh from npm,
+  `VMBGPOD` still showed as `unknown_0x28`.
+- **Root cause:** `velbus-scan.js` has its **own, third, independent copy**
+  of the type table — `ALL_TYPES`, `NODE_SUGGESTION`, and `MODULE_CHANNELS`
+  — entirely separate from `lib/glass-panel-types.js` (used by
+  `velbus-glass-panel` at runtime) and the duplicate list inside
+  `velbus-glass-panel.html` (used for the editor dropdown), both already
+  fixed in v0.9.2. The v0.9.2 fix genuinely worked for the glass-panel node
+  itself; the bus scanner simply had no idea `VMBGPOD` existed, since it
+  never reads either of the other two files at all.
+- **This is now the third type table found in this codebase.** Searched
+  exhaustively this time (`grep -rln "VMBGPO'"` across the whole `nodes/`
+  and `lib/` tree) rather than assume these three are the only ones — they
+  are, confirmed by the search coming back with exactly these three files
+  and no others.
+- Added `0x28: 'VMBGPOD'` to all three tables in `velbus-scan.js`.
+- **Verified end-to-end this time, not just by inspecting the table.** Built
+  a full mock-harness test that triggers a real scan, feeds a simulated
+  `0xFF` response for `VMBGPOD` (using the exact build/serial from Stuart's
+  own scan output), and confirms the emitted `module_found` payload reports
+  `"module":"VMBGPOD"`, the correct suggested node, and the correct channel
+  count — not just that the table lookup would theoretically work.
+- **Worth remembering for any future module type addition:** check all
+  three of `lib/<family>-types[-20].js`, the corresponding node's own
+  `.html` (editor dropdown), and `velbus-scan.js` (bus-wide discovery).
+  Missing any one of the three produces a real, user-visible symptom in a
+  different part of the palette than wherever the fix was actually made —
+  exactly what happened here.
+
+---
+
 ## v0.9.2 — 09/07/2026
 
 ### velbus-glass-panel — VMBGPOD (0x28) registry gap fixed

package/HANDOVER.md

@@ -6,7 +6,7 @@ you're a new contributor, a new maintainer, or an AI assistant starting a fresh
 with no memory of previous work — this document should be sufficient on its own, together
 with the source code in this repository, to continue development competently.
 
-Current state at time of writing: **v0.9.2, 19 nodes, published on npm.**
+Current state at time of writing: **v0.9.3, 19 nodes, published on npm.**
 
 ---
 
@@ -144,6 +144,24 @@ boilerplate (bridge lookup, packet registration, status bar handling, firmware c
 V2 nodes) is consistent across every node and easy to get subtly wrong if rebuilt from
 scratch.
 
+**Adding or fixing a module type touches three separate files, not one — confirmed
+the hard way (v0.9.2 → v0.9.3).** A module type used to exist in exactly one place per
+node family; it doesn't. Check all three every time:
+1. `lib/<family>-types[-20].js` — used by the actual node at runtime (`velbus-glass-panel`,
+   `velbus-sensor`, etc.)
+2. The corresponding node's own `.html` file — a **separate, duplicate** copy used only
+   to populate the editor's address dropdown and type hint. Not read by the running node
+   at all.
+3. `nodes/velbus-scan/velbus-scan.js` — has its **own, third, entirely independent** copy
+   (`ALL_TYPES`, `NODE_SUGGESTION`, `MODULE_CHANNELS`), used only for bus-discovery
+   reporting. Doesn't read either of the other two files.
+
+Missing any one of the three produces a real, user-visible symptom in a *different* part
+of the palette than wherever the fix actually needs to happen — a scan reporting
+`unknown_0x28` while the glass-panel node itself handles that type perfectly correctly,
+for instance. When in doubt, `grep -rln "<ModuleName>'" nodes/ lib/` to find every file
+that mentions a given type by name, rather than assume you've found all the copies.
+
 ---
 
 ## 4. Architecture overview
@@ -894,6 +912,10 @@ git push --tags
   exceptions — see section 4.3 if this isn't already second nature.
 - **Numbers are always numbers in payloads, never strings.**
 - **`results.modules`, not `results`,** when reading the scan endpoint.
+- **A module type lives in three separate files, not one** (per-node `lib/` registry,
+  that node's own `.html` dropdown copy, and `velbus-scan.js`'s independent copy) —
+  see section 3 for the full explanation. Missing one produces a symptom in a
+  different part of the palette than wherever the type was actually added.
 - **Thermostat commands go to the primary address only,** never a subaddress.
 - **Respect the 20ms minimum between `0xFC` writes** on original-series modules — this
   is real EEPROM wear, not an arbitrary rate limit.

package/nodes/velbus-scan/velbus-scan.js

@@ -21,6 +21,7 @@ const ALL_TYPES = {
   // Glass panels - original
   0x1E: 'VMBGP1',      0x1F: 'VMBGP2',      0x20: 'VMBGP4',
   0x21: 'VMBGPO',      0x2D: 'VMBGP4PIR',
+  0x28: 'VMBGPOD',
   0x34: 'VMBEL1',      0x35: 'VMBEL2',        0x36: 'VMBEL4',
   0x37: 'VMBELO',      0x38: 'VMBELPIR',      0x39: 'VMBSIG',
   0x47: 'VMBEL2PIR',
@@ -78,6 +79,7 @@ const NODE_SUGGESTION = {
   // Glass panels - all via single node
   0x1E: 'velbus-glass-panel', 0x1F: 'velbus-glass-panel', 0x20: 'velbus-glass-panel',
   0x21: 'velbus-glass-panel', 0x2D: 'velbus-glass-panel',
+  0x28: 'velbus-glass-panel',
   0x34: 'velbus-glass-panel', 0x35: 'velbus-glass-panel', 0x36: 'velbus-glass-panel',
   0x37: 'velbus-glass-panel', 0x38: 'velbus-glass-panel', 0x47: 'velbus-glass-panel',
   0x3A: 'velbus-glass-panel', 0x3B: 'velbus-glass-panel', 0x3C: 'velbus-glass-panel',
@@ -114,6 +116,7 @@ const MODULE_CHANNELS = {
   // Glass panels - original
   0x1E: 1,  0x1F: 2,  0x20: 4,
   0x21: 32, 0x2D: 8,
+  0x28: 4,
   0x34: 1,  0x35: 2,  0x36: 4,
   0x37: 4,  0x38: 8,  0x47: 6,
   0x3A: 1,  0x3B: 2,  0x3C: 4,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-velbus-2026",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Node-RED palette for Velbus building automation \u2014 relay, dimmer, glass panel, PIR, blind, sensor, meteo, clock nodes. Original and V2 (-20) series.",
   "keywords": [
     "node-red",