node-red-contrib-uos-nats 0.1.32 → 0.1.34

package/nodes/datahub-input.js

@@ -51,16 +51,29 @@ module.exports = function (RED) {
       // Helper to find definition by ID (fuzzy match string/number)
       const getDef = (id) => defMap.get(id) || defMap.get(String(id)) || defMap.get(Number(id));
 
-      return states
-        .map((state) => ({
-          providerId: this.providerId,
-          id: state.id,
-          key: getDef(state.id)?.key || state.id,
-          value: state.value,
-          quality: state.quality,
-          timestampNs: state.timestampNs,
-        }))
-        .filter((state) => shouldInclude(state.key));
+      const mapped = states.map((state) => ({
+        providerId: this.providerId,
+        id: state.id,
+        key: getDef(state.id)?.key || state.id,
+        value: state.value,
+        quality: state.quality,
+        timestampNs: state.timestampNs,
+      }));
+
+      // Warn if we have filters but no definitions (all keys will be raw IDs)
+      if (this.variables.length > 0 && defMap.size === 0 && mapped.length > 0) {
+        this.warnOnce('Filtering active but Variable Definitions failed to load (API Error). Names cannot be resolved, so filters will likely block all data. Please fix the API error (check Provider ID/Permissions).');
+      }
+
+      return mapped.filter((state) => shouldInclude(state.key));
+    };
+
+    // Helper to warn only once per deployment to avoid log spam
+    this.warnOnce = (msg) => {
+      if (!this.warned) {
+        this.warn(msg);
+        this.warned = true;
+      }
     };
 
     let performSnapshot = async () => { }; // Placeholder
@@ -83,19 +96,38 @@ module.exports = function (RED) {
         this.status({ fill: 'green', shape: 'dot', text: 'connected' });
 
         performSnapshot = async () => {
-          // Only request snapshot if connected
-          if (!nc || nc.isClosed()) return;
+          // Debugging connection state
+          if (!nc || nc.isClosed()) {
+            this.warn('Snapshot skipped: Connection is closed or not ready.');
+            return;
+          }
+
           try {
+            // Log before request
+            // this.warn(`Requesting snapshot for ${this.providerId}... (DefMap size: ${defMap.size})`);
+
             const snapshotMsg = await nc.request(subjects.readVariablesQuery(this.providerId), payloads.buildReadVariablesQuery(), { timeout: 2000 });
+
             const bb = new flatbuffers.ByteBuffer(snapshotMsg.data);
             const snapshotObj = ReadVariablesQueryResponse.getRootAsReadVariablesQueryResponse(bb);
             const states = payloads.decodeVariableList(snapshotObj.variables());
+
+            // this.warn(`Received ${states.length} items from NATS.`);
+
             const filteredSnapshot = processStates(states);
+
+            // this.warn(`Filtered down to ${filteredSnapshot.length} items. (Selected vars: ${this.variables.length})`);
+
             if (filteredSnapshot.length) {
               this.send({ payload: { type: 'snapshot', variables: filteredSnapshot } });
+            } else {
+              if (states.length > 0) {
+                this.warn(`Snapshot received data but everything was filtered out. Check Variable selection. Debug: First raw ID: ${states[0].id}, DefMap has it? ${defMap.has(states[0].id)}`);
+              } else {
+                this.warn('Snapshot received empty list from Data Hub.');
+              }
             }
           } catch (requestErr) {
-            // Log snapshot failures to help debugging
             this.warn(`Snapshot failed: ${requestErr.message}`);
           }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-uos-nats",
-  "version": "0.1.32",
+  "version": "0.1.34",
   "description": "Node-RED nodes for u-OS Data Hub via NATS",
   "repository": {
     "type": "git",